[Wikidata-bugs] [Maniphest] [Commented On] T100991: General code-review of WikidataQuality extension
gerritbot added a comment. Change 215897 abandoned by Daniel Kinzler: [DNM] Patch current master directly on top of blank repo. Reason: done https://gerrit.wikimedia.org/r/215897 TASK DETAIL https://phabricator.wikimedia.org/T100991 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel, gerritbot Cc: Tamslo, gerritbot, JanZerebecki, Tobi_WMDE_SW, Wikibase-Quality, Aklapper, Lydia_Pintscher, Ricordisamoa, Reedy, hoo, greg, mmodell, Liuxinyu970226, Yair_rand, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T100991: General code-review of WikidataQuality extension
Tamslo added a subscriber: Tamslo. Tamslo added a comment. The URL of the repository changed, see the description. TASK DETAIL https://phabricator.wikimedia.org/T100991 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel, Tamslo Cc: Tamslo, gerritbot, JanZerebecki, Tobi_WMDE_SW, Wikibase-Quality, Aklapper, Lydia_Pintscher, Ricordisamoa, Reedy, hoo, greg, mmodell, Liuxinyu970226, Yair_rand, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T100991: General code-review of WikidataQuality extension
gerritbot added a comment. Change 218321 had a related patch set uploaded (by Soeren.oldag): Implemented further hints from review from Daniel. https://gerrit.wikimedia.org/r/218321 TASK DETAIL https://phabricator.wikimedia.org/T100991 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel, gerritbot Cc: gerritbot, JanZerebecki, Tobi_WMDE_SW, Wikidata-Quality, Aklapper, Lydia_Pintscher, Ricordisamoa, Reedy, hoo, greg, mmodell, Liuxinyu970226, Yair_rand, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T100991: General code-review of WikidataQuality extension
gerritbot added a comment. Change 218320 had a related patch set uploaded (by Soeren.oldag): Implemented further hints from review from Daniel https://gerrit.wikimedia.org/r/218320 TASK DETAIL https://phabricator.wikimedia.org/T100991 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel, gerritbot Cc: gerritbot, JanZerebecki, Tobi_WMDE_SW, Wikidata-Quality, Aklapper, Lydia_Pintscher, Ricordisamoa, Reedy, hoo, greg, mmodell, Liuxinyu970226, Yair_rand, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T100991: General code-review of WikidataQuality extension
gerritbot added a comment. Change 218319 merged by Dominic.sauer: Implemented further hints from review from Daniel. https://gerrit.wikimedia.org/r/218319 TASK DETAIL https://phabricator.wikimedia.org/T100991 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel, gerritbot Cc: gerritbot, JanZerebecki, Tobi_WMDE_SW, Wikidata-Quality, Aklapper, Lydia_Pintscher, Ricordisamoa, Reedy, hoo, greg, mmodell, Liuxinyu970226, Yair_rand, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T100991: General code-review of WikidataQuality extension
gerritbot added a comment. Change 218319 had a related patch set uploaded (by Soeren.oldag): Implemented further hints from review from Daniel. https://gerrit.wikimedia.org/r/218319 TASK DETAIL https://phabricator.wikimedia.org/T100991 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel, gerritbot Cc: gerritbot, JanZerebecki, Tobi_WMDE_SW, Wikidata-Quality, Aklapper, Lydia_Pintscher, Ricordisamoa, Reedy, hoo, greg, mmodell, Liuxinyu970226, Yair_rand, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T100991: General code-review of WikidataQuality extension
JanZerebecki added a comment. In https://phabricator.wikimedia.org/T100991#1337514, @JanZerebecki wrote: @JanZerebecki TODO: try a build with the quality extensions. Done: Used https://github.com/wmde/WikidataBuildResources/pull/27 in vagrant without it blowing up, rendering an Item still works, they show up on Special:Version. Though didn't try to actually use them in any way. TASK DETAIL https://phabricator.wikimedia.org/T100991 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel, JanZerebecki Cc: gerritbot, JanZerebecki, Tobi_WMDE_SW, Wikidata-Quality, Aklapper, Lydia_Pintscher, Ricordisamoa, Reedy, hoo, greg, mmodell, Liuxinyu970226, Yair_rand, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T100991: General code-review of WikidataQuality extension
JanZerebecki added a subscriber: JanZerebecki. JanZerebecki added a comment. @JanZerebecki TODO: try a build with the quality extensions. TASK DETAIL https://phabricator.wikimedia.org/T100991 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel, JanZerebecki Cc: JanZerebecki, Tobi_WMDE_SW, Aklapper, Lydia_Pintscher, Ricordisamoa, Reedy, hoo, greg, mmodell, Liuxinyu970226, Yair_rand, Wikidata-bugs, aude, Ainali, Dimitri.schmidt, Jonas.keutel, dominic.sauer, Andreasburmeister, Tamslo, soeren.oldag ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T100991: General code-review of WikidataQuality extension
gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 215897 had a related patch set uploaded (by Daniel Kinzler): [DNM] Patch current master directly on top of blank repo. https://gerrit.wikimedia.org/r/215897 TASK DETAIL https://phabricator.wikimedia.org/T100991 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel, gerritbot Cc: gerritbot, JanZerebecki, Tobi_WMDE_SW, Aklapper, Lydia_Pintscher, Ricordisamoa, Reedy, hoo, greg, mmodell, Liuxinyu970226, Yair_rand, Wikidata-bugs, aude, Ainali, Dimitri.schmidt, Jonas.keutel, dominic.sauer, Andreasburmeister, Tamslo, soeren.oldag ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
