[Wikidata-bugs] [Maniphest] [Commented On] T101565: Page banner not compatible with $wgUseInstantCommons = true;
Jdlrobson added a comment. For some reason I cannot set $wgUseInstantCommons to true despite having a line in my LocalSettings.php .. Want to troubleshoot over at my desk? TASK DETAIL https://phabricator.wikimedia.org/T101565 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bd808, Jdlrobson Cc: Steinsplitter, Tgr, gerritbot, bd808, Sumit, Aklapper, Jdlrobson, mobrovac, Wikidata-bugs, aude, Lydia_Pintscher, jeremyb, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T101565: Page banner not compatible with $wgUseInstantCommons = true;
Tgr added a comment. @jdlrobson can you verify if this is fixed? (For normal pages you need to edit and save the page after `vagrant provision` for the fix to take effect. Not sure about the page banner.) TASK DETAIL https://phabricator.wikimedia.org/T101565 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bd808, Tgr Cc: Steinsplitter, Tgr, gerritbot, bd808, Sumit, Aklapper, Jdlrobson, mobrovac, Wikidata-bugs, aude, Lydia_Pintscher, jeremyb, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T101565: Page banner not compatible with $wgUseInstantCommons = true;
bd808 added a comment. In https://phabricator.wikimedia.org/T101565#1361273, @Tgr wrote: In https://phabricator.wikimedia.org/T101565#1353926, @bd808 wrote: There have been reports in the past that `$wgUseInstantCommons` is broken in MediaWiki-Vagrant. That's https://phabricator.wikimedia.org/T56202. It affects wikis with a 404 handler enabled (that's typically when you enable one of the multimedia roles). IIRC it has something to do with cached thumbnails ending up in the wrong directory. That could actually be related to this fix then. We were certainly not setting up `$wgUploadPath` properly for the non-default wikis. TASK DETAIL https://phabricator.wikimedia.org/T101565 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bd808 Cc: Tgr, gerritbot, bd808, Sumit, Aklapper, Jdlrobson, mobrovac, Wikidata-bugs, aude, Lydia_Pintscher, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T101565: Page banner not compatible with $wgUseInstantCommons = true;
Tgr added a comment. https://phabricator.wikimedia.org/T56202 affects the default wiki as well. TASK DETAIL https://phabricator.wikimedia.org/T101565 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bd808, Tgr Cc: Tgr, gerritbot, bd808, Sumit, Aklapper, Jdlrobson, mobrovac, Wikidata-bugs, aude, Lydia_Pintscher, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T101565: Page banner not compatible with $wgUseInstantCommons = true;
Jdlrobson added a comment. This was a new file... TASK DETAIL https://phabricator.wikimedia.org/T101565 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bd808, Jdlrobson Cc: gerritbot, bd808, Sumit, Aklapper, Jdlrobson, mobrovac, Wikidata-bugs, aude, Lydia_Pintscher, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T101565: Page banner not compatible with $wgUseInstantCommons = true;
bd808 added a comment. In https://phabricator.wikimedia.org/T101565#1360584, @Jdlrobson wrote: This patch somewhat fixes it but it seems to only work for the general case [[File:2 Bloomsbury Square.jpg]] but not [[File:2 Bloomsbury Square.jpg|thumb|300]] When I was testing locally it seemed to not fix images/thumbs that had been already used in the wiki. It looked like something had stored the value of `$wgUploadPath` at the time that the image was originally imported. TASK DETAIL https://phabricator.wikimedia.org/T101565 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bd808 Cc: gerritbot, bd808, Sumit, Aklapper, Jdlrobson, mobrovac, Wikidata-bugs, aude, Lydia_Pintscher, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T101565: Page banner not compatible with $wgUseInstantCommons = true;
Jdlrobson added a comment. This patch somewhat fixes it but it seems to only work for the general case [[File:2 Bloomsbury Square.jpg]] but not [[File:2 Bloomsbury Square.jpg|thumb|300]] TASK DETAIL https://phabricator.wikimedia.org/T101565 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bd808, Jdlrobson Cc: gerritbot, bd808, Sumit, Aklapper, Jdlrobson, mobrovac, Wikidata-bugs, aude, Lydia_Pintscher, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T101565: Page banner not compatible with $wgUseInstantCommons = true;
gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 217769 had a related patch set uploaded (by BryanDavis): Setup $wgUploadPath and apache for each wiki https://gerrit.wikimedia.org/r/217769 TASK DETAIL https://phabricator.wikimedia.org/T101565 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bd808, gerritbot Cc: gerritbot, bd808, Sumit, Aklapper, Jdlrobson, mobrovac, Wikidata-bugs, aude, Lydia_Pintscher, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T101565: Page banner not compatible with $wgUseInstantCommons = true;
bd808 added a comment. In https://phabricator.wikimedia.org/T101565#1353932, @Jdlrobson wrote: Enable the wikidata role and try it on http://en.wiki.local.wmftest.net:8080 I think that might be setup incorrectly... After enabling wikidata I can still add media to the default wiki as InstantCommons imports, but the local enwiki isn't showing such media **unless** the same image is imported into the default wiki. This sounds like a config problem for the tertiary wikis where we change $wgUploadDirectory and $wgCacheDirectory (see `settings.d/wikis/enwiki/wgConf.php`). TASK DETAIL https://phabricator.wikimedia.org/T101565 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson, bd808 Cc: bd808, Sumit, Aklapper, Jdlrobson, mobrovac, Wikidata-bugs, aude, Lydia_Pintscher, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T101565: Page banner not compatible with $wgUseInstantCommons = true;
Sumit added a comment. Looks like the generation of srcset will have to be moved to client side. Since the wiki is querying for the urls through api requests to commons, doing this task on client side seems feasible. TASK DETAIL https://phabricator.wikimedia.org/T101565 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit Cc: Sumit, Aklapper, Jdlrobson, Wikidata-bugs, aude, Lydia_Pintscher ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T101565: Page banner not compatible with $wgUseInstantCommons = true;
Jdlrobson added a comment. Enable the wikidata role and try it on http://en.wiki.local.wmftest.net:8080 I think that might be setup incorrectly... TASK DETAIL https://phabricator.wikimedia.org/T101565 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: bd808, Sumit, Aklapper, Jdlrobson, mobrovac, Wikidata-bugs, aude, Lydia_Pintscher, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T101565: Page banner not compatible with $wgUseInstantCommons = true;
bd808 added a comment. There have been reports in the past that `$wgUseInstantCommons` is broken in MediaWiki-Vagrant. I'd have to admit to not making use of it often. I did however just paste the provided file link (`[[File:Hong_Kong_Skyline_Restitch_-_Dec_2007.jpg|thumb|300px]]`) into my local mw-vagrant install and it worked as expected. My `vagrant roles list -e` output is: Enabled roles: centralauthoauth sitematrix fssparserfunctionswikidiff2 gather poolcounterwikimediamessages l10nupdate scribunto I don't see anything in there that would obviously make InstantCommons work or not work. It //should// be enabled by default and working AFAIK. TASK DETAIL https://phabricator.wikimedia.org/T101565 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson, bd808 Cc: bd808, Sumit, Aklapper, Jdlrobson, mobrovac, Wikidata-bugs, aude, Lydia_Pintscher, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
