[Wikidata-bugs] [Maniphest] [Commented On] T108929: [Task] only fallback to master in WikiPageEntityMetaDataLookup when explicitly requested

2016-09-07 Thread gerritbot 
gerritbot added a comment.
Change 279135 merged by jenkins-bot:
Don't fallback to master in WikiPageEntityMetaDataLookup etc.

https://gerrit.wikimedia.org/r/279135TASK DETAILhttps://phabricator.wikimedia.org/T108929EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, gerritbotCc: daniel, gerritbot, aaron, Aklapper, aude, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T108929: [Task] only fallback to master in WikiPageEntityMetaDataLookup when explicitly requested

2016-09-06 Thread hoo 
hoo added a comment.

In T108929#2611587, @daniel wrote:
@hoo This can be closed now, right?


No, https://gerrit.wikimedia.org/r/279135 is still needed.TASK DETAILhttps://phabricator.wikimedia.org/T108929EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: daniel, gerritbot, aaron, Aklapper, aude, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T108929: [Task] only fallback to master in WikiPageEntityMetaDataLookup when explicitly requested

2016-09-06 Thread daniel 
daniel added a comment.
@hoo This can be closed now, right?TASK DETAILhttps://phabricator.wikimedia.org/T108929EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, danielCc: daniel, gerritbot, aaron, Aklapper, aude, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T108929: [Task] only fallback to master in WikiPageEntityMetaDataLookup when explicitly requested

2016-08-02 Thread hoo 
hoo added a comment.
Todo (mostly a note to myself):


Change EntityRevisionLookup::getEntityRevision to a signature like EntityRevisionLookup::getEntityRevision( $entityId, $revisionIdOrMode, $mode )
Find all places where we might want to use fallbacks (PS1 from https://gerrit.wikimedia.org/r/279135 (draft) indicates most(?) places)
Change the default to slave only
TASK DETAILhttps://phabricator.wikimedia.org/T108929EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: gerritbot, aaron, Aklapper, aude, D3r1ck01, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T108929: [Task] only fallback to master in WikiPageEntityMetaDataLookup when explicitly requested

2016-07-31 Thread gerritbot 
gerritbot added a comment.
Change 302199 had a related patch set uploaded (by Hoo man):
Introduce EntityRevisionLookup::LATEST_FROM_SLAVE_WITH_FALLBACK

https://gerrit.wikimedia.org/r/302199TASK DETAILhttps://phabricator.wikimedia.org/T108929EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, gerritbotCc: gerritbot, aaron, Aklapper, aude, D3r1ck01, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T108929: [Task] only fallback to master in WikiPageEntityMetaDataLookup when explicitly requested

2016-07-30 Thread hoo 
hoo added a comment.
FYI: I just picked this up again and will probably provide patches during this weekend… I'll do it step by step to minimize the risk of us introducing data inconsistencies this way.TASK DETAILhttps://phabricator.wikimedia.org/T108929EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: aaron, Aklapper, aude, D3r1ck01, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T108929: [Task] only fallback to master in WikiPageEntityMetaDataLookup when explicitly requested

2016-05-12 Thread aaron 
aaron added a comment.


  Has anyone had a chance to look at this lately?
  
  The patch doesn't seem to load for me.

TASK DETAIL
  https://phabricator.wikimedia.org/T108929

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hoo, aaron
Cc: aaron, Aklapper, aude, D3r1ck01, Izno, Wikidata-bugs, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T108929: [Task] only fallback to master in WikiPageEntityMetaDataLookup when explicitly requested

2016-04-28 Thread hoo 
hoo added a comment.


  Just to give a short update here: I poked at this and there is a "draft" on 
gerrit… the "hard" part is to make sure all code paths use the right type of 
connection (master for writes, slaves otherwise) and we have the appropriate 
fallbacks in place if needed.
  
  https://gerrit.wikimedia.org/r/279135
  
  I'll have another look at this sometime soon.

TASK DETAIL
  https://phabricator.wikimedia.org/T108929

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hoo
Cc: Aklapper, aude, D3r1ck01, Izno, Wikidata-bugs, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs