[Wikidata-bugs] [Maniphest] [Commented On] T110510: [Bug] fix negative argument (ArgumentError) in browsertests

2016-03-15 Thread JanZerebecki 
JanZerebecki added a comment.


  No this is not yet fixed, there is only a work around in place.

TASK DETAIL
  https://phabricator.wikimedia.org/T110510

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: JanZerebecki
Cc: hashar, dduvall, JanZerebecki, zeljkofilipin, Aklapper, WMDE-Fisch, 
Tobi_WMDE_SW, gerritbot, Lewizho99, D3r1ck01, Izno, Wikidata-bugs, aude, 
Mbch331, Krenair, greg



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T110510: [Bug] fix negative argument (ArgumentError) in browsertests

2016-03-15 Thread Tobi_WMDE_SW 
Tobi_WMDE_SW added a comment.


  Can this be closed?

TASK DETAIL
  https://phabricator.wikimedia.org/T110510

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tobi_WMDE_SW
Cc: hashar, dduvall, JanZerebecki, zeljkofilipin, Aklapper, WMDE-Fisch, 
Tobi_WMDE_SW, gerritbot, Lewizho99, D3r1ck01, Izno, Wikidata-bugs, aude, 
Mbch331, Krenair, greg



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T110510: [Bug] fix negative argument (ArgumentError) in browsertests

2016-03-09 Thread gerritbot 
gerritbot added a comment.


  Change 275435 merged by jenkins-bot:
  Disable Raita and enable Cucumber pretty formatter for browsertests-Wikidata* 
jobs.
  
  https://gerrit.wikimedia.org/r/275435

TASK DETAIL
  https://phabricator.wikimedia.org/T110510

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: hashar, dduvall, JanZerebecki, zeljkofilipin, Aklapper, WMDE-Fisch, 
Tobi_WMDE_SW, gerritbot, Lewizho99, D3r1ck01, Izno, Wikidata-bugs, aude, 
Mbch331, Krenair, greg



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T110510: [Bug] fix negative argument (ArgumentError) in browsertests

2016-03-07 Thread gerritbot 
gerritbot added a comment.


  Change 275435 had a related patch set uploaded (by Zfilipin):
  WIP Fix various problems with browsertests-Wikidata* jobs
  
  https://gerrit.wikimedia.org/r/275435

TASK DETAIL
  https://phabricator.wikimedia.org/T110510

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: hashar, dduvall, JanZerebecki, zeljkofilipin, Aklapper, WMDE-Fisch, 
Tobi_WMDE_SW, gerritbot, Lewizho99, D3r1ck01, Izno, Wikidata-bugs, aude, 
Mbch331, Krenair, greg



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T110510: [Bug] fix negative argument (ArgumentError) in browsertests

2015-10-21 Thread gerritbot 
gerritbot added a comment.

Change 247602 merged by jenkins-bot:
Work around cucumber pretty formater bug

https://gerrit.wikimedia.org/r/247602


TASK DETAIL
  https://phabricator.wikimedia.org/T110510

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: zeljkofilipin, gerritbot
Cc: hashar, dduvall, JanZerebecki, zeljkofilipin, Aklapper, WMDE-Fisch, 
Tobi_WMDE_SW, gerritbot, Wikidata-bugs, aude, greg



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T110510: [Bug] fix negative argument (ArgumentError) in browsertests

2015-10-15 Thread dduvall 
dduvall added a comment.

After some further debugging, we've narrowed it down to the `--expand` option 
that the Raita formatter forces. This is apparently a known issue, fixed in 2.0 
with no backport to 1.3.

https://github.com/cucumber/cucumber-ruby/issues/620

The simplest way to reproduce the bug in the context of Wikidata tests is with 
`bundle exec cucumber --format pretty --expand features/aliases.feature:39`.

Upgrading our dependency to Cucumber 2.x is going to be necessary eventually 
but would involve quite a bit of refactoring to our formatters; we might want 
to backport a fix to 1.3 in the meantime.


TASK DETAIL
  https://phabricator.wikimedia.org/T110510

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: zeljkofilipin, dduvall
Cc: hashar, dduvall, JanZerebecki, zeljkofilipin, Aklapper, WMDE-Fisch, 
Tobi_WMDE_SW, gerritbot, Wikidata-bugs, aude, greg



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T110510: [Bug] fix negative argument (ArgumentError) in browsertests

2015-10-15 Thread dduvall 
dduvall added a comment.

@zeljkofilipin and I paired on this today and discovered that commenting out 
`RAITA_URL` avoids the bug, so it's likely that something in the 
`MediawikiSelenium::Raita` formatter is causing the issue.


TASK DETAIL
  https://phabricator.wikimedia.org/T110510

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: zeljkofilipin, dduvall
Cc: hashar, dduvall, JanZerebecki, zeljkofilipin, Aklapper, WMDE-Fisch, 
Tobi_WMDE_SW, gerritbot, Wikidata-bugs, aude, greg



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T110510: [Bug] fix negative argument (ArgumentError) in browsertests

2015-10-14 Thread JanZerebecki 
JanZerebecki added a comment.

The following lead us to think the problem might be fixed in cucumber 2.x:
https://github.com/cucumber/cucumber-ruby/issues/620
https://github.com/cucumber/cucumber-ruby/issues/762
WIP patches:
https://phabricator.wikimedia.org/rMSELdd7cdcbe67557b435a24f60bc516bed97f58eef0
https://github.com/wmde/WikidataBrowserTests/commit/104e77b6cdf993378413523d1e5a9010a9ed4e37


TASK DETAIL
  https://phabricator.wikimedia.org/T110510

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: zeljkofilipin, JanZerebecki
Cc: hashar, dduvall, JanZerebecki, zeljkofilipin, Aklapper, WMDE-Fisch, 
Tobi_WMDE_SW, gerritbot, Wikidata-bugs, aude, greg



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T110510: [Bug] fix negative argument (ArgumentError) in browsertests

2015-10-14 Thread Tobi_WMDE_SW 
Tobi_WMDE_SW added a comment.

I'm wondering why it broke so suddenly. The scenarios that broke were not new 
at all. Were there a recent change to the cucumber version that is used?


TASK DETAIL
  https://phabricator.wikimedia.org/T110510

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: zeljkofilipin, Tobi_WMDE_SW
Cc: hashar, dduvall, JanZerebecki, zeljkofilipin, Aklapper, WMDE-Fisch, 
Tobi_WMDE_SW, gerritbot, Wikidata-bugs, aude, greg



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T110510: [Bug] fix negative argument (ArgumentError) in browsertests

2015-10-14 Thread gerritbot 
gerritbot added a comment.

Change 246235 abandoned by Zfilipin:
WIP Use Cucumber 2.x

https://gerrit.wikimedia.org/r/246235


TASK DETAIL
  https://phabricator.wikimedia.org/T110510

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: dduvall, gerritbot
Cc: hashar, dduvall, JanZerebecki, zeljkofilipin, Aklapper, WMDE-Fisch, 
Tobi_WMDE_SW, gerritbot, Wikidata-bugs, aude, greg



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T110510: [Bug] fix negative argument (ArgumentError) in browsertests

2015-10-14 Thread Tobi_WMDE_SW 
Tobi_WMDE_SW added a comment.

@zeljofilipin thx a lot for digging into this. If Cucumber 2.x really solves 
this issue, can we just update or are there other blockers for updating to a 
higher cucumber version?


TASK DETAIL
  https://phabricator.wikimedia.org/T110510

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: zeljkofilipin, Tobi_WMDE_SW
Cc: hashar, dduvall, JanZerebecki, zeljkofilipin, Aklapper, WMDE-Fisch, 
Tobi_WMDE_SW, gerritbot, Wikidata-bugs, aude, greg



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T110510: [Bug] fix negative argument (ArgumentError) in browsertests

2015-10-14 Thread JanZerebecki 
JanZerebecki added a comment.

As a workaround I remove the pretty formatter from 
https://integration.wikimedia.org/ci/view/BrowserTests/view/Wikidata/job/browsertests-Wikidata-WikidataTests-linux-firefox-sauce/
 without commit that change to integration/config.git.


TASK DETAIL
  https://phabricator.wikimedia.org/T110510

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: zeljkofilipin, JanZerebecki
Cc: hashar, dduvall, JanZerebecki, zeljkofilipin, Aklapper, WMDE-Fisch, 
Tobi_WMDE_SW, gerritbot, Wikidata-bugs, aude, greg



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T110510: [Bug] fix negative argument (ArgumentError) in browsertests

2015-10-14 Thread zeljkofilipin 
zeljkofilipin added a comment.

Updating to Cucumber 2.x could solve the problem.


TASK DETAIL
  https://phabricator.wikimedia.org/T110510

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: dduvall, zeljkofilipin
Cc: hashar, dduvall, JanZerebecki, zeljkofilipin, Aklapper, WMDE-Fisch, 
Tobi_WMDE_SW, gerritbot, Wikidata-bugs, aude, greg



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T110510: [Bug] fix negative argument (ArgumentError) in browsertests

2015-10-14 Thread gerritbot 
gerritbot added a comment.

Change 246235 had a related patch set uploaded (by Zfilipin):
WIP Use Cucumber 2.x

https://gerrit.wikimedia.org/r/246235


TASK DETAIL
  https://phabricator.wikimedia.org/T110510

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: dduvall, gerritbot
Cc: hashar, dduvall, JanZerebecki, zeljkofilipin, Aklapper, WMDE-Fisch, 
Tobi_WMDE_SW, gerritbot, Wikidata-bugs, aude, greg



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T110510: [Bug] fix negative argument (ArgumentError) in browsertests

2015-10-14 Thread zeljkofilipin 
zeljkofilipin added a comment.

https://integration.wikimedia.org/ci/job/browsertests-Wikidata-WikidataTests-linux-firefox-sauce-T110510/lastBuild/console

  00:00:13.230 cannot load such file -- 
cucumber/formatter/gherkin_formatter_adapter


TASK DETAIL
  https://phabricator.wikimedia.org/T110510

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: dduvall, zeljkofilipin
Cc: hashar, dduvall, JanZerebecki, zeljkofilipin, Aklapper, WMDE-Fisch, 
Tobi_WMDE_SW, gerritbot, Wikidata-bugs, aude, greg



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T110510: [Bug] fix negative argument (ArgumentError) in browsertests

2015-10-12 Thread Tobi_WMDE_SW 
Tobi_WMDE_SW added a comment.

@dduvall @hashar @zeljkofilipin Do you know what's causing this issue? Is there 
anything we can do on our side?


TASK DETAIL
  https://phabricator.wikimedia.org/T110510

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: dduvall, Tobi_WMDE_SW
Cc: hashar, dduvall, JanZerebecki, zeljkofilipin, Aklapper, WMDE-Fisch, 
Tobi_WMDE_SW, gerritbot, Wikidata-bugs, aude, greg



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T110510: [Bug] fix negative argument (ArgumentError) in browsertests

2015-10-12 Thread JanZerebecki 
JanZerebecki added a comment.

In https://phabricator.wikimedia.org/T110510#1631750, @zeljkofilipin wrote:

> The job broke after this change, I think: 
> https://github.com/wikimedia/integration-config/commit/700edd9


Do you mean temporally after or caused by that change?


TASK DETAIL
  https://phabricator.wikimedia.org/T110510

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: dduvall, JanZerebecki
Cc: hashar, dduvall, JanZerebecki, zeljkofilipin, Aklapper, WMDE-Fisch, 
Tobi_WMDE_SW, gerritbot, Wikidata-bugs, aude, greg



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T110510: [Bug] fix negative argument (ArgumentError) in browsertests

2015-10-12 Thread JanZerebecki 
JanZerebecki added a comment.

In https://phabricator.wikimedia.org/T110510#1631750, @zeljkofilipin wrote:

> The job broke after this change, I think: 
> https://github.com/wikimedia/integration-config/commit/700edd9


Do you mean temporally after or caused by that change?


TASK DETAIL
  https://phabricator.wikimedia.org/T110510

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: dduvall, JanZerebecki
Cc: hashar, dduvall, JanZerebecki, zeljkofilipin, Aklapper, WMDE-Fisch, 
Tobi_WMDE_SW, gerritbot, Wikidata-bugs, aude, greg



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs