[Wikidata-bugs] [Maniphest] [Commented On] T111209: [Task] Create custom mediawiki search api module
gerritbot added a comment. Change 238771 merged by jenkins-bot: Create wbsearch api query module https://gerrit.wikimedia.org/r/238771 TASK DETAIL https://phabricator.wikimedia.org/T111209 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene, gerritbot Cc: aude, Florian, Jdlrobson, Lydia_Pintscher, Ricordisamoa, gerritbot, Aklapper, Wikidata-bugs, Deskana, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111209: [Task] Create custom mediawiki search api module
aude added a comment. Special:Nearby has some of the same issues as mobile search, in that the title text (e.g. Q64) is displayed by default. It uses geosearch as the generator instead of prefixsearch, but otherwise is mostly the same api call. What we might want to do is have displaytext as a pageprop? then it could easily be used in both places and be a generic thing. though that doesn't solve the problem that prefix search doesn't find anything meaningful from Wikibase content. TASK DETAIL https://phabricator.wikimedia.org/T111209 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: aude Cc: aude, Florian, Jdlrobson, Lydia_Pintscher, Ricordisamoa, gerritbot, Aklapper, Wikidata-bugs, Deskana ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111209: [Task] Create custom mediawiki search api module
gerritbot added a comment. Change 238771 had a related patch set uploaded (by Bene): Create wbsearch api query module https://gerrit.wikimedia.org/r/238771 TASK DETAIL https://phabricator.wikimedia.org/T111209 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene, gerritbot Cc: aude, Florian, Jdlrobson, Lydia_Pintscher, Ricordisamoa, gerritbot, Aklapper, Wikidata-bugs, Deskana ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111209: [Task] Create custom mediawiki search api module
gerritbot added a comment. Change 234560 abandoned by Bene: Create MediawikiSearchEntities api module Reason: In favour of https://gerrit.wikimedia.org/r/#/c/238771/ https://gerrit.wikimedia.org/r/234560 TASK DETAIL https://phabricator.wikimedia.org/T111209 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene, gerritbot Cc: aude, Florian, Jdlrobson, Lydia_Pintscher, Ricordisamoa, gerritbot, Aklapper, Wikidata-bugs, Deskana ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111209: [Task] Create custom mediawiki search api module
Bene added a comment. @jdlrobson I've commented there. I think this will work for our needs so far. :-) TASK DETAIL https://phabricator.wikimedia.org/T111209 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene Cc: aude, Florian, Jdlrobson, Lydia_Pintscher, Ricordisamoa, gerritbot, Aklapper, Wikidata-bugs, Deskana ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111209: [Task] Create custom mediawiki search api module
aude added a comment. in the short term, I think substituting the api call can work, but would like the core prefix search mechanism to just support content such as Wikibase items where the desired display text is different than the title text. TASK DETAIL https://phabricator.wikimedia.org/T111209 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene, aude Cc: aude, Florian, Jdlrobson, Lydia_Pintscher, Ricordisamoa, gerritbot, Aklapper, Wikidata-bugs, Deskana ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111209: [Task] Create custom mediawiki search api module
Bene added a comment. @aude yes, that's the long term solution but I guess it will need a "bit" more work to make that happen. Only getting wikidata terms into Cirrus is already non-trivial afaik. TASK DETAIL https://phabricator.wikimedia.org/T111209 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene Cc: aude, Florian, Jdlrobson, Lydia_Pintscher, Ricordisamoa, gerritbot, Aklapper, Wikidata-bugs, Deskana ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111209: [Task] Create custom mediawiki search api module
aude added a comment. In https://phabricator.wikimedia.org/T111209#1627047, @Bene wrote: > > What comes into my mind is to provide a custom > list=wikidatasearch=wikidatasearch instead of a completely new api > module. This way we can avoid to fale the whole response structure and the > module gets more reusable. Furthermore, this option is more likely to fit our > future needs for using Elastic as Wikidata's search engine > (https://phabricator.wikimedia.org/T88534). do we want this to be wikibasesearch instead of wikidatasearch? sounds like this is a non-temporary solution which could be ok. Supporting generators seems like a nice idea. > To fix the problem of displaying the correct title, the mobile search code > would need some tweaks for this solution because currently it doesn't take > the title from the list=prefixsearch result but from the prop=pageimages > information. This should however be trivial to fix. This system could also be > extended to show a redirect's title instead of the target's title when > matching a redirect (other story though). TASK DETAIL https://phabricator.wikimedia.org/T111209 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene, aude Cc: aude, Florian, Jdlrobson, Lydia_Pintscher, Ricordisamoa, gerritbot, Aklapper, Wikidata-bugs, Deskana ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111209: [Task] Create custom mediawiki search api module
aude added a subscriber: aude. aude added a comment. I think we can hook into PrefixSearch to have it produce relevant results for content such as Wikibase content. right now it (usually) returns a list of titles, but there also is a (not totally nice, but could be useful) SearchResult thing in core. Maybe that could be used in PrefixSearch and be extended to have something like getDisplayText or such. with this, then already we can get both existing api calls (the one used for mobile and the opensearch one) to return results for Wikibase, based on term search. (using EntitySearchHelper) This somewhat easily works with the default search backend (db), though need to think how to have this also work when Cirrus is enabled. TASK DETAIL https://phabricator.wikimedia.org/T111209 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene, aude Cc: aude, Florian, Jdlrobson, Lydia_Pintscher, Ricordisamoa, gerritbot, Aklapper, Wikidata-bugs, Deskana ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111209: [Task] Create custom mediawiki search api module
Jdlrobson added a comment. Does https://gerrit.wikimedia.org/r/#/c/234730/ provide what you need on the frontend? TASK DETAIL https://phabricator.wikimedia.org/T111209 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene, Jdlrobson Cc: aude, Florian, Jdlrobson, Lydia_Pintscher, Ricordisamoa, gerritbot, Aklapper, Wikidata-bugs, Deskana ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111209: [Task] Create custom mediawiki search api module
gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 234560 had a related patch set uploaded (by Bene): Create MediawikiSearchEntities api module https://gerrit.wikimedia.org/r/234560 TASK DETAIL https://phabricator.wikimedia.org/T111209 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene, gerritbot Cc: gerritbot, Aklapper, Wikidata-bugs, aude, Deskana, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
