[Wikidata-bugs] [Maniphest] [Commented On] T111641: [Bug] Warning: Attempted to serialize unserializable builtin class Closure$jsonConfigIsStorage (from Changes/ChangeHandlerTest.php (173): mergeMwGlo

2017-05-20 Thread gerritbot 
gerritbot added a comment.
Change 354592 merged by jenkins-bot:
[mediawiki/core@master] Fix Closure detection in MediaWikiTestCase

https://gerrit.wikimedia.org/r/354592TASK DETAILhttps://phabricator.wikimedia.org/T111641EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, gerritbotCc: hoo, gerritbot, Krinkle, hashar, MarkAHershberger, wikibugs-l-list, Nikerabbit, Nemo_bis, Reedy, Liuxinyu970226, aude, Aklapper, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Litanwei, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair, Joe, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T111641: [Bug] Warning: Attempted to serialize unserializable builtin class Closure$jsonConfigIsStorage (from Changes/ChangeHandlerTest.php (173): mergeMwGlo

2017-05-19 Thread gerritbot 
gerritbot added a comment.
Change 354592 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/core@master] Fix Closure detection in MediaWikiTestCase

https://gerrit.wikimedia.org/r/354592TASK DETAILhttps://phabricator.wikimedia.org/T111641EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, gerritbotCc: hoo, gerritbot, Krinkle, hashar, MarkAHershberger, wikibugs-l-list, Nikerabbit, Nemo_bis, Reedy, Liuxinyu970226, aude, Aklapper, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Litanwei, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair, Joe, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T111641: [Bug] Warning: Attempted to serialize unserializable builtin class Closure$jsonConfigIsStorage (from Changes/ChangeHandlerTest.php (173): mergeMwGlo

2017-05-19 Thread gerritbot 
gerritbot added a comment.
Change 354557 merged by jenkins-bot:
[mediawiki/core@master] Add workaround for HHVM issue 6206

https://gerrit.wikimedia.org/r/354557TASK DETAILhttps://phabricator.wikimedia.org/T111641EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Krinkle, hashar, MarkAHershberger, wikibugs-l-list, Nikerabbit, Nemo_bis, Reedy, Liuxinyu970226, aude, Aklapper, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Litanwei, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair, Joe, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T111641: [Bug] Warning: Attempted to serialize unserializable builtin class Closure$jsonConfigIsStorage (from Changes/ChangeHandlerTest.php (173): mergeMwGlo

2017-05-19 Thread gerritbot 
gerritbot added a comment.
Change 354557 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/core@master] Add workaround for HHVM issue 6206

https://gerrit.wikimedia.org/r/354557TASK DETAILhttps://phabricator.wikimedia.org/T111641EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Krinkle, hashar, MarkAHershberger, wikibugs-l-list, Nikerabbit, Nemo_bis, Reedy, Liuxinyu970226, aude, Aklapper, GoranSMilovanovic, QZanden, Litanwei, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair, Joe, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T111641: [Bug] Warning: Attempted to serialize unserializable builtin class Closure$jsonConfigIsStorage (from Changes/ChangeHandlerTest.php (173): mergeMwGlo

2015-09-09 Thread aude 
aude added a comment.

I have an ugly workaround in my settings for this, so think it's not a blocker 
for me now.

hopefully someone else fixes this, or else I might want to look at the hhvm 
code and see where the bug is (in my copious free time)


TASK DETAIL
  https://phabricator.wikimedia.org/T111641

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: aude
Cc: aude, Aklapper, Wikidata-bugs, Krenair, Joe, jeremyb



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T111641: [Bug] Warning: Attempted to serialize unserializable builtin class Closure$jsonConfigIsStorage (from Changes/ChangeHandlerTest.php (173): mergeMwGlo

2015-09-06 Thread aude 
aude added a comment.

https://github.com/facebook/hhvm/issues/6206


TASK DETAIL
  https://phabricator.wikimedia.org/T111641

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: aude
Cc: aude, Aklapper, Wikidata-bugs



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T111641: [Bug] Warning: Attempted to serialize unserializable builtin class Closure$jsonConfigIsStorage (from Changes/ChangeHandlerTest.php (173): mergeMwGlo

2015-09-06 Thread aude 
aude added a comment.

i'll check tomorrow with php 5.6 and if it's the same as 5.3.


TASK DETAIL
  https://phabricator.wikimedia.org/T111641

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: aude
Cc: aude, Aklapper, Wikidata-bugs



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T111641: [Bug] Warning: Attempted to serialize unserializable builtin class Closure$jsonConfigIsStorage (from Changes/ChangeHandlerTest.php (173): mergeMwGlo

2015-09-06 Thread aude 
aude added a comment.

on php 5.3:

  > $x = function() { echo "hi"; };
  
  > $y = serialize( $x );
  Caught exception Exception: Serialization of 'Closure' is not allowed
  #0 /srv/mediawiki/php-1.26wmf21/maintenance/eval.php(78) : eval()'d code(1): 
serialize(Object(Closure))
  #1 /srv/mediawiki/php-1.26wmf21/maintenance/eval.php(78): eval()
  #2 /srv/mediawiki/multiversion/MWScript.php(97): 
require_once('/srv/mediawiki/...')
  #3 {main}

on hhvm:

  $x = function() { echo "hi"; };
  
  > serialize( $x );
  Warning: Attempted to serialize unserializable builtin class 
Closure$;1015959387$f88ca0d4c5acd3a5845a6d32d20783ef$ in 
/srv/mediawiki/php-1.26wmf21/maintenance/eval.php(78)(8f0647e4a0360628842a5258eac04a18)
 : eval()'d code on line 1


TASK DETAIL
  https://phabricator.wikimedia.org/T111641

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: aude
Cc: aude, Aklapper, Wikidata-bugs



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T111641: [Bug] Warning: Attempted to serialize unserializable builtin class Closure$jsonConfigIsStorage (from Changes/ChangeHandlerTest.php (173): mergeMwGlo

2015-09-06 Thread aude 
aude added a comment.

trying to serialize a closure cases a warning, but MediaWikiTestCase wraps this 
around try/catch, expecting an exception and in that case it just stashes the 
variable.

I wonder if this is what php 5.x really does? and hhvm does different?


TASK DETAIL
  https://phabricator.wikimedia.org/T111641

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: aude
Cc: aude, Aklapper, Wikidata-bugs



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs