[Wikidata-bugs] [Maniphest] [Commented On] T114617: Track the number of identifier properties on an item in page_props
gerritbot added a comment. Change 345809 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Add wb-identifiers field to page_props https://gerrit.wikimedia.org/r/345809TASK DETAILhttps://phabricator.wikimedia.org/T114617EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: gerritbot, Ladsgroup, Lydia_Pintscher, daniel, aude, Esc3300, StudiesWorld, hoo, Aklapper, Multichill, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T114617: Track the number of identifier properties on an item in page_props
gerritbot added a comment. Change 345974 abandoned by Ladsgroup: [WIP] Add tests for adding wb-identifiers to page_props Reason: Done in I53c8a1162fccc2b3f5b4179d9b1d5327decc5ff4 https://gerrit.wikimedia.org/r/345974TASK DETAILhttps://phabricator.wikimedia.org/T114617EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: gerritbot, Ladsgroup, Lydia_Pintscher, daniel, aude, Esc3300, StudiesWorld, hoo, Aklapper, Multichill, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Salgo60, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T114617: Track the number of identifier properties on an item in page_props
Ladsgroup added a comment. I just got back. The CI tests look complicated and take some time to get it fixed. The main part is done though.TASK DETAILhttps://phabricator.wikimedia.org/T114617EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Ladsgroup, Lydia_Pintscher, daniel, aude, Esc3300, StudiesWorld, hoo, Aklapper, Multichill, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Salgo60, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T114617: Track the number of identifier properties on an item in page_props
Multichill added a comment. @Ladsgroup code review was done. Any update on this?TASK DETAILhttps://phabricator.wikimedia.org/T114617EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, MultichillCc: Ladsgroup, Lydia_Pintscher, daniel, aude, Esc3300, StudiesWorld, hoo, Aklapper, Multichill, QZanden, Salgo60, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T114617: Track the number of identifier properties on an item in page_props
Ladsgroup added a comment. Since gerritbot doesn't work: https://gerrit.wikimedia.org/r/#/c/345809/TASK DETAILhttps://phabricator.wikimedia.org/T114617EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Ladsgroup, Lydia_Pintscher, daniel, aude, Esc3300, StudiesWorld, hoo, Aklapper, Multichill, QZanden, Salgo60, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T114617: Track the number of identifier properties on an item in page_props
daniel added a comment. @Ladsgroup there is a PropertyDataTypeLookup service. The implementation used in production is based on a cached list of data types, IIRC. That should be even quicker than the query suggested by Multichill.TASK DETAILhttps://phabricator.wikimedia.org/T114617EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Ladsgroup, Lydia_Pintscher, daniel, aude, Esc3300, StudiesWorld, hoo, Aklapper, Multichill, QZanden, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T114617: Track the number of identifier properties on an item in page_props
Multichill added a comment.
In T114617#3115238, @Ladsgroup wrote:
I've looked into this a little and it seems it's not easily doable. Item->getStatements() returns StatementList which without doing several SQL lookups we can not distinguish statements which their property is of a certain data type.
Link? Why several lookups? Looking at MariaDB [wikidatawiki_p]> SELECT * from wb_property_info LIMIT 1000,100; I get things back like:
1392external-id{"type":"external-id","formatterURL":"http:\/\/www.comicbookdb.com\/creator.php?ID=$1"}
for https://www.wikidata.org/wiki/Property:P1392 . This could be cached so you don't have to hit the database each time and if it's getting parsed anyway, Could also populate the externallinks table if it gets parsed anyway. I wonder how the imagelinks table gets populated. Solution is probably similar.TASK DETAILhttps://phabricator.wikimedia.org/T114617EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MultichillCc: Ladsgroup, Lydia_Pintscher, daniel, aude, Esc3300, StudiesWorld, hoo, Aklapper, Multichill, QZanden, D3r1ck01, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T114617: Track the number of identifier properties on an item in page_props
Ladsgroup added a comment. I need to add that I don't know the codebase good enough to give the last call. That's definitely something Daniel or Thiemo should take a lookTASK DETAILhttps://phabricator.wikimedia.org/T114617EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Ladsgroup, Lydia_Pintscher, daniel, aude, Esc3300, StudiesWorld, hoo, Aklapper, Multichill, QZanden, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T114617: Track the number of identifier properties on an item in page_props
Ladsgroup added a comment. I've looked into this a little and it seems it's not easily doable. Item->getStatements() returns StatementList which without doing several SQL lookups we can not distinguish statements which their property is of a certain data type.TASK DETAILhttps://phabricator.wikimedia.org/T114617EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Ladsgroup, Lydia_Pintscher, daniel, aude, Esc3300, StudiesWorld, hoo, Aklapper, Multichill, QZanden, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T114617: Track the number of identifier properties on an item in page_props
Multichill added a comment. This task blocks T114617TASK DETAILhttps://phabricator.wikimedia.org/T114617EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MultichillCc: Esc3300, StudiesWorld, hoo, Aklapper, Multichill, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T114617: Track the number of identifier properties on an item in page_props
Multichill added a comment. Bump. Now that we have identifiers on Wikidata it would be really nice to have this. TASK DETAIL https://phabricator.wikimedia.org/T114617 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Multichill Cc: StudiesWorld, hoo, Aklapper, Multichill, Izno, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
