[Wikidata-bugs] [Maniphest] [Commented On] T114734: Wikidata page banner does not work properly with language converter.
gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 244433 had a related patch set uploaded (by Zhuyifei1999): Styles: Set z-index of .wpb-topbanner-toc and .wpb-name to 1 https://gerrit.wikimedia.org/r/244433 TASK DETAIL https://phabricator.wikimedia.org/T114734 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Liuxinyu970226, Hkjacksonhk, liangent, Jdlrobson, Aklapper, zhuyifei1999, Akangupt, Wikidata-bugs, aude, Lydia_Pintscher, 01tonythomas ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T114734: Wikidata page banner does not work properly with language converter.
Jdlrobson added a comment. Oh sorry I missed that. I think the latter may also be an issue with this extension. I suspect it needs to apply getContentLanguage somewhere.. TASK DETAIL https://phabricator.wikimedia.org/T114734 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: gerritbot, Liuxinyu970226, Hkjacksonhk, liangent, Jdlrobson, Aklapper, zhuyifei1999, Akangupt, Wikidata-bugs, aude, Lydia_Pintscher, 01tonythomas ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T114734: Wikidata page banner does not work properly with language converter.
Jdlrobson added a comment. That said I am not familiar with LanguageConvertor can someone in that team assist? TASK DETAIL https://phabricator.wikimedia.org/T114734 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: gerritbot, Liuxinyu970226, Hkjacksonhk, liangent, Jdlrobson, Aklapper, zhuyifei1999, Akangupt, Wikidata-bugs, aude, Lydia_Pintscher, 01tonythomas ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T114734: Wikidata page banner does not work properly with language converter.
gerritbot added a comment. Change 244584 had a related patch set uploaded (by Jdlrobson): Styles: Set z-index of .wpb-topbanner-toc and .wpb-name to 1 https://gerrit.wikimedia.org/r/244584 TASK DETAIL https://phabricator.wikimedia.org/T114734 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Liuxinyu970226, Hkjacksonhk, liangent, Jdlrobson, Aklapper, zhuyifei1999, Wikidata-bugs, aude, Lydia_Pintscher, 01tonythomas ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T114734: Wikidata page banner does not work properly with language converter.
gerritbot added a comment. Change 244433 merged by jenkins-bot: Styles: Set z-index of .wpb-topbanner-toc and .wpb-name to 1 https://gerrit.wikimedia.org/r/244433 TASK DETAIL https://phabricator.wikimedia.org/T114734 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Liuxinyu970226, Hkjacksonhk, liangent, Jdlrobson, Aklapper, zhuyifei1999, Wikidata-bugs, aude, Lydia_Pintscher, 01tonythomas ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T114734: Wikidata page banner does not work properly with language converter.
gerritbot added a comment. Change 244584 merged by Catrope: Styles: Set z-index of .wpb-topbanner-toc and .wpb-name to 1 https://gerrit.wikimedia.org/r/244584 TASK DETAIL https://phabricator.wikimedia.org/T114734 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Liuxinyu970226, Hkjacksonhk, liangent, Jdlrobson, Aklapper, zhuyifei1999, Wikidata-bugs, aude, Lydia_Pintscher, 01tonythomas ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T114734: Wikidata page banner does not work properly with language converter.
Jdlrobson added a comment. I will get this SWAT fixed this afternoon... https://wikitech.wikimedia.org/w/index.php?title=Deployments=revision=190778=190699 TASK DETAIL https://phabricator.wikimedia.org/T114734 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: gerritbot, Liuxinyu970226, Hkjacksonhk, liangent, Jdlrobson, Aklapper, zhuyifei1999, Wikidata-bugs, aude, Lydia_Pintscher, 01tonythomas ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T114734: Wikidata page banner does not work properly with language converter.
Jdlrobson added a comment. z-index of .wpb-topbanner-toc and .ext-wpb-pagebanner .wpb-topbanner .wpb-name should be 1. It's a super easy fix. Is someone able to submit a patch? I can get it merged promptly! TASK DETAIL https://phabricator.wikimedia.org/T114734 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Liuxinyu970226, Hkjacksonhk, liangent, Jdlrobson, Aklapper, zhuyifei1999, Wikidata-bugs, aude, Lydia_Pintscher, 01tonythomas ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T114734: Wikidata page banner does not work properly with language converter.
Hkjacksonhk added a comment. And also the removal of the edit link ([編輯]) next to the article name on the page banner should be proceeded. TASK DETAIL https://phabricator.wikimedia.org/T114734 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Hkjacksonhk Cc: Hkjacksonhk, liangent, Jdlrobson, Aklapper, zhuyifei1999, Wikidata-bugs, aude, Lydia_Pintscher ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T114734: Wikidata page banner does not work properly with language converter.
zhuyifei1999 added a comment. In https://phabricator.wikimedia.org/T114734#1704679, @Hkjacksonhk wrote: > And also the removal of the edit link ([編輯]) next to the article name on the > page banner should be proceeded. ? TASK DETAIL https://phabricator.wikimedia.org/T114734 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: zhuyifei1999 Cc: Hkjacksonhk, liangent, Jdlrobson, Aklapper, zhuyifei1999, Wikidata-bugs, aude, Lydia_Pintscher ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
