[Wikidata-bugs] [Maniphest] [Commented On] T137781: Adding/Editing references is confusing

2016-07-29 Thread Charlie_WMDE 
Charlie_WMDE added a comment.
So after talking about it we've decided on this design:

F4249467: Screenshot_20160707_162656.png

This does not mean, that the references don't need further redesigning. This is just a easy quick fix to improve the current design, before coming up with a better long-term solution.

If no one has any objections to this I suggest we make it happen \o/

Also we should remember that the primary sources tool also has to be adapted if we change the design, to make them match again.TASK DETAILhttps://phabricator.wikimedia.org/T137781EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_Pintscher, Charlie_WMDECc: aude, Jonas, thiemowmde, Aklapper, Charlie_WMDE, Zppix, Jan_Dittrich, codynguyen1116, D3r1ck01, Izno, Wikidata-bugs, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T137781: Adding/Editing references is confusing

2016-07-07 Thread Charlie_WMDE 
Charlie_WMDE added a comment.
I find that more confusing.  I think it's good to change the color of the things you're editing and not just the background. Also the contrast between the remove and the data is very high now. Is that smth we want?TASK DETAILhttps://phabricator.wikimedia.org/T137781EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_Pintscher, Charlie_WMDECc: aude, Jonas, thiemowmde, Aklapper, Charlie_WMDE, Zppix, Jan_Dittrich, codynguyen1116, D3r1ck01, Izno, Wikidata-bugs, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T137781: Adding/Editing references is confusing

2016-07-07 Thread Charlie_WMDE 
Charlie_WMDE added a comment.
F4249520: Screenshot_20160707_164713.pngTASK DETAILhttps://phabricator.wikimedia.org/T137781EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_Pintscher, Charlie_WMDECc: aude, Jonas, thiemowmde, Aklapper, Charlie_WMDE, Zppix, Jan_Dittrich, codynguyen1116, D3r1ck01, Izno, Wikidata-bugs, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T137781: Adding/Editing references is confusing

2016-07-07 Thread thiemowmde 
thiemowmde added a comment.
Almost, just inverted. I meant number 2 …
F4248637: Screenshot_20160707_125936.png

… but with the dark headings.TASK DETAILhttps://phabricator.wikimedia.org/T137781EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_Pintscher, thiemowmdeCc: aude, Jonas, thiemowmde, Aklapper, Charlie_WMDE, Zppix, Jan_Dittrich, codynguyen1116, D3r1ck01, Izno, Wikidata-bugs, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T137781: Adding/Editing references is confusing

2016-07-07 Thread aude 
aude added a comment.
I am not sure which of the mockups is best...TASK DETAILhttps://phabricator.wikimedia.org/T137781EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_Pintscher, audeCc: aude, Jonas, thiemowmde, Aklapper, Charlie_WMDE, Zppix, Jan_Dittrich, codynguyen1116, D3r1ck01, Izno, Wikidata-bugs, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T137781: Adding/Editing references is confusing

2016-07-07 Thread aude 
aude added a comment.
some of my errors in adding references as qualifiers or other way I think happen after i add the main snak value, then the think below it is "+add qualifier"

If I am using tab, then after tabbing out of the main snak value input box, it takes me to "+add qualifier". In some cases, maybe this is what i want, but only sometimes.

Ideally, the user always provides a reference when adding a statement.

Though I see the point that qualifiers are grouped closely with with the statement, in the statementview

F4249477: references-addstatement.pngTASK DETAILhttps://phabricator.wikimedia.org/T137781EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_Pintscher, audeCc: aude, Jonas, thiemowmde, Aklapper, Charlie_WMDE, Zppix, Jan_Dittrich, codynguyen1116, D3r1ck01, Izno, Wikidata-bugs, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T137781: Adding/Editing references is confusing

2016-07-07 Thread Jan_Dittrich 
Jan_Dittrich added a comment.
@thiemowmde: @Charlie_WMDE’s Mockups were created purely in CSS, thus the lack of the "Reference" headline .

How hard would it be to have "Reference" added in the HTML? I think it would make sense in contrast to the almost empty bar we have now.TASK DETAILhttps://phabricator.wikimedia.org/T137781EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_Pintscher, Jan_DittrichCc: aude, Jonas, thiemowmde, Aklapper, Charlie_WMDE, Zppix, Jan_Dittrich, codynguyen1116, D3r1ck01, Izno, Wikidata-bugs, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T137781: Adding/Editing references is confusing

2016-07-07 Thread Charlie_WMDE 
Charlie_WMDE added a comment.
F4249467: Screenshot_20160707_162656.png

@thiemowmde did you mean smth like this?TASK DETAILhttps://phabricator.wikimedia.org/T137781EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_Pintscher, Charlie_WMDECc: aude, Jonas, thiemowmde, Aklapper, Charlie_WMDE, Zppix, Jan_Dittrich, codynguyen1116, D3r1ck01, Izno, Wikidata-bugs, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T137781: Adding/Editing references is confusing

2016-07-07 Thread Charlie_WMDE 
Charlie_WMDE added a comment.
We made the changes in CSS so the question is whether one of them should be implemented.
@thiemowmde  @Lydia_Pintscher  @aude

F4248638: Screenshot_20160707_125424.png

F4248637: Screenshot_20160707_125936.png

F4248636: Screenshot_20160707_125245.png

F4248635: Screenshot_20160707_124713.pngTASK DETAILhttps://phabricator.wikimedia.org/T137781EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_Pintscher, Charlie_WMDECc: aude, Jonas, thiemowmde, Aklapper, Charlie_WMDE, Zppix, Jan_Dittrich, D3r1ck01, Izno, Wikidata-bugs, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T137781: Adding/Editing references is confusing

2016-06-22 Thread thiemowmde 
thiemowmde added a comment.
There is no cancel button at the reference inputs.

I still do not get this. Having multiple cancel buttons with no save button seems odd. What would these cancel buttons do, in addition or in contrast to the remove buttons that are already there? Or do you suggest to rename "remove" to "cancel"?TASK DETAILhttps://phabricator.wikimedia.org/T137781EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_Pintscher, thiemowmdeCc: Jonas, thiemowmde, Aklapper, Charlie_WMDE, Zppix, Jan_Dittrich, D3r1ck01, Izno, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T137781: Adding/Editing references is confusing

2016-06-22 Thread Jan_Dittrich 
Jan_Dittrich added a comment.
The concern was/is that users may not know that the buttons on top of the property/value pair save the references, too. I tested with two people, one had the problem, the other not. However, we can postpone this until we have more definitive data.TASK DETAILhttps://phabricator.wikimedia.org/T137781EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_Pintscher, Jan_DittrichCc: Jonas, thiemowmde, Aklapper, Charlie_WMDE, Zppix, Jan_Dittrich, D3r1ck01, Izno, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T137781: Adding/Editing references is confusing

2016-06-22 Thread aude 
aude added a comment.

In T137781#2398737, @Charlie_WMDE wrote:
Three approaches to structuring the references more clearly

F4191432: blueBoxes.png


I think mockup 2 helps make things more clear.TASK DETAILhttps://phabricator.wikimedia.org/T137781EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_Pintscher, audeCc: aude, Jonas, thiemowmde, Aklapper, Charlie_WMDE, Zppix, Jan_Dittrich, D3r1ck01, Izno, Wikidata-bugs, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T137781: Adding/Editing references is confusing

2016-06-22 Thread Jan_Dittrich 
Jan_Dittrich added a comment.
There is a cancel button. Please be more specific what you are missing and what you expect.

Tried to clarify the reference to lack of a cancel function: There is no cancel button at the reference inputs. This may cause confusion if a user wants to discard changes that he/she did on the references. The save/cancel buttons of the statement work for everything in the whole statement, but this may not be clear for the user.

Possible solution: Hide dysfunctional remove buttons instead of disabling them.

That would make sense, I assume.TASK DETAILhttps://phabricator.wikimedia.org/T137781EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_Pintscher, Jan_DittrichCc: Jonas, thiemowmde, Aklapper, Charlie_WMDE, Zppix, Jan_Dittrich, D3r1ck01, Izno, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T137781: Adding/Editing references is confusing

2016-06-22 Thread thiemowmde 
thiemowmde added a comment.
I do like the changes in the 1st mock very much:
F4191416: whiteBoxes.png

There is no cancel.

There is a cancel button. Please be more specific what you are missing and what you expect.

The first property's remove action in the list of references seems always to be inactive.

I don't think there is anything wrong with the behavior of the remove buttons. You can not remove the last snak in a reference. When there are two or more, all remove buttons are enabled. Possible solution: Hide dysfunctional remove buttons instead of disabling them.

there is only add, but not "add property"

What you add is a "snak", so "add property" would be misleading and just cause other confusion. But I agree that "add" alone is problematic.TASK DETAILhttps://phabricator.wikimedia.org/T137781EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_Pintscher, thiemowmdeCc: Jonas, thiemowmde, Aklapper, Charlie_WMDE, Zppix, Jan_Dittrich, D3r1ck01, Izno, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T137781: Adding/Editing references is confusing

2016-06-22 Thread Charlie_WMDE 
Charlie_WMDE added a comment.
Three approaches to structuring the references more clearly

F4191416: whiteBoxes.png

F4191432: blueBoxes.png

F4191414: whiteFrames.pngTASK DETAILhttps://phabricator.wikimedia.org/T137781EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_Pintscher, Charlie_WMDECc: Jonas, thiemowmde, Aklapper, Charlie_WMDE, Zppix, Jan_Dittrich, D3r1ck01, Izno, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T137781: Adding/Editing references is confusing

2016-06-17 Thread Jan_Dittrich 
Jan_Dittrich added a comment.
F4174179: Screenshot from 2016-06-17 10-56-37.png
in use on Angela Merkel| Q567TASK DETAILhttps://phabricator.wikimedia.org/T137781EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_Pintscher, Jan_DittrichCc: Aklapper, Charlie_WMDE, Zppix, Jan_Dittrich, D3r1ck01, Izno, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T137781: Adding/Editing references is confusing

2016-06-17 Thread Jan_Dittrich 
Jan_Dittrich added a comment.
I'll create a prototype/mock for that.TASK DETAILhttps://phabricator.wikimedia.org/T137781EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_Pintscher, Jan_DittrichCc: Aklapper, Charlie_WMDE, Zppix, Jan_Dittrich, D3r1ck01, Izno, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs