[Wikidata-bugs] [Maniphest] [Commented On] T146792: Remove (seemingly) unused wb-status page prop (EntityContent::getEntityStatus)
gerritbot added a comment. Change 328640 merged by jenkins-bot: Drop unused EntityContent::isStub entirely https://gerrit.wikimedia.org/r/328640TASK DETAILhttps://phabricator.wikimedia.org/T146792EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, gerritbotCc: Aleksey_WMDE, gerritbot, Lea_Lacroix_WMDE, Multichill, Lydia_Pintscher, thiemowmde, Addshore, daniel, aude, Aklapper, hoo, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T146792: Remove (seemingly) unused wb-status page prop (EntityContent::getEntityStatus)
gerritbot added a comment. Change 328657 merged by jenkins-bot: Drop adding isStub() as part of extending entities doc https://gerrit.wikimedia.org/r/328657TASK DETAILhttps://phabricator.wikimedia.org/T146792EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, gerritbotCc: Aleksey_WMDE, gerritbot, Lea_Lacroix_WMDE, Multichill, Lydia_Pintscher, thiemowmde, Addshore, daniel, aude, Aklapper, hoo, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T146792: Remove (seemingly) unused wb-status page prop (EntityContent::getEntityStatus)
gerritbot added a comment. Change 328636 merged by jenkins-bot: Remove unused MediaInfoContent::isStub https://gerrit.wikimedia.org/r/328636TASK DETAILhttps://phabricator.wikimedia.org/T146792EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, gerritbotCc: Aleksey_WMDE, gerritbot, Lea_Lacroix_WMDE, Multichill, Lydia_Pintscher, thiemowmde, Addshore, daniel, aude, Aklapper, hoo, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T146792: Remove (seemingly) unused wb-status page prop (EntityContent::getEntityStatus)
gerritbot added a comment. Change 328638 merged by jenkins-bot: Remove unused LexemeContent::isStub https://gerrit.wikimedia.org/r/328638TASK DETAILhttps://phabricator.wikimedia.org/T146792EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, gerritbotCc: Aleksey_WMDE, gerritbot, Lea_Lacroix_WMDE, Multichill, Lydia_Pintscher, thiemowmde, Addshore, daniel, aude, Aklapper, hoo, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T146792: Remove (seemingly) unused wb-status page prop (EntityContent::getEntityStatus)
gerritbot added a comment. Change 328657 had a related patch set uploaded (by Ladsgroup): Drop adding isStub() as part of extending entities doc https://gerrit.wikimedia.org/r/328657TASK DETAILhttps://phabricator.wikimedia.org/T146792EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, gerritbotCc: Aleksey_WMDE, gerritbot, Lea_Lacroix_WMDE, Multichill, Lydia_Pintscher, thiemowmde, Addshore, daniel, aude, Aklapper, hoo, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T146792: Remove (seemingly) unused wb-status page prop (EntityContent::getEntityStatus)
gerritbot added a comment. Change 328635 merged by jenkins-bot: Deprecate unused EntityContent::isStub https://gerrit.wikimedia.org/r/328635TASK DETAILhttps://phabricator.wikimedia.org/T146792EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, gerritbotCc: Aleksey_WMDE, gerritbot, Lea_Lacroix_WMDE, Multichill, Lydia_Pintscher, thiemowmde, Addshore, daniel, aude, Aklapper, hoo, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T146792: Remove (seemingly) unused wb-status page prop (EntityContent::getEntityStatus)
gerritbot added a comment. Change 328640 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Drop unused EntityContent::isStub entirely https://gerrit.wikimedia.org/r/328640TASK DETAILhttps://phabricator.wikimedia.org/T146792EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, gerritbotCc: gerritbot, Lea_Lacroix_WMDE, Multichill, Lydia_Pintscher, thiemowmde, Addshore, daniel, aude, Aklapper, hoo, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T146792: Remove (seemingly) unused wb-status page prop (EntityContent::getEntityStatus)
gerritbot added a comment. Change 328638 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Remove unused LexemeContent::isStub https://gerrit.wikimedia.org/r/328638TASK DETAILhttps://phabricator.wikimedia.org/T146792EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, gerritbotCc: gerritbot, Lea_Lacroix_WMDE, Multichill, Lydia_Pintscher, thiemowmde, Addshore, daniel, aude, Aklapper, hoo, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T146792: Remove (seemingly) unused wb-status page prop (EntityContent::getEntityStatus)
gerritbot added a comment. Change 328636 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Remove unused MediaInfoContent::isStub https://gerrit.wikimedia.org/r/328636TASK DETAILhttps://phabricator.wikimedia.org/T146792EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, gerritbotCc: gerritbot, Lea_Lacroix_WMDE, Multichill, Lydia_Pintscher, thiemowmde, Addshore, daniel, aude, Aklapper, hoo, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T146792: Remove (seemingly) unused wb-status page prop (EntityContent::getEntityStatus)
gerritbot added a comment. Change 328635 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Deprecate unused EntityContent::isStub https://gerrit.wikimedia.org/r/328635TASK DETAILhttps://phabricator.wikimedia.org/T146792EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, gerritbotCc: gerritbot, Lea_Lacroix_WMDE, Multichill, Lydia_Pintscher, thiemowmde, Addshore, daniel, aude, Aklapper, hoo, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T146792: Remove (seemingly) unused wb-status page prop (EntityContent::getEntityStatus)
gerritbot added a comment. Change 326978 merged by jenkins-bot: Remove the "wb-status" page prop https://gerrit.wikimedia.org/r/326978TASK DETAILhttps://phabricator.wikimedia.org/T146792EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, gerritbotCc: gerritbot, Lea_Lacroix_WMDE, Multichill, Lydia_Pintscher, thiemowmde, Addshore, daniel, aude, Aklapper, hoo, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T146792: Remove (seemingly) unused wb-status page prop (EntityContent::getEntityStatus)
gerritbot added a comment. Change 326978 had a related patch set uploaded (by Hoo man): Remove the "wb-status" page prop https://gerrit.wikimedia.org/r/326978TASK DETAILhttps://phabricator.wikimedia.org/T146792EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, gerritbotCc: gerritbot, Lea_Lacroix_WMDE, Multichill, Lydia_Pintscher, thiemowmde, Addshore, daniel, aude, Aklapper, hoo, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T146792: Remove (seemingly) unused wb-status page prop (EntityContent::getEntityStatus)
hoo added a comment. Announced that we in will drop this in December 2016 (or later) in all relevant places (for example https://lists.wikimedia.org/pipermail/wikidata/2016-October/009844.html).TASK DETAILhttps://phabricator.wikimedia.org/T146792EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: Lea_Lacroix_WMDE, Multichill, Lydia_Pintscher, thiemowmde, Addshore, daniel, aude, Aklapper, hoo, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T146792: Remove (seemingly) unused wb-status page prop (EntityContent::getEntityStatus)
hoo added a comment. I think we have consensus for removing this page prop. @Lydia_Pintscher we should announce this as a breaking change soon, doing the actual changes in the code base is trivial (just need to delete code).TASK DETAILhttps://phabricator.wikimedia.org/T146792EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: Multichill, Lydia_Pintscher, thiemowmde, Addshore, daniel, aude, Aklapper, hoo, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T146792: Remove (seemingly) unused wb-status page prop (EntityContent::getEntityStatus)
hoo added a comment. In T146792#2688105, @thiemowmde wrote: In my opinion the way this status is calculated does not make it very useful. It maps three dimensions (terms, statements and sitelinks) to a single flag (not a bit field). I suggest to drop it entirely and introduce a wb-terms page prop instead, if required. Yeah, that would be more useful and allow much more fine grained filtering.TASK DETAILhttps://phabricator.wikimedia.org/T146792EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: Multichill, Lydia_Pintscher, thiemowmde, Addshore, daniel, aude, Aklapper, hoo, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T146792: Remove (seemingly) unused wb-status page prop (EntityContent::getEntityStatus)
thiemowmde added a comment. Note that looking for a "use" of this status flag does not tell us much. We want others to use it, via special pages, API and SQL queries. There must not be a use in our code base. I was looking for a visualization for a long time and finally found one: 0 terms & 0 statements1+ term & 0 statements0 terms & 1+ statement1+ term & 1+ statement PropertyEMPTYSTUBNONENONE Item with 0 sitelinksEMPTYSTUBNONENONE Item with 1+ sitelinkLINKSTUBLINKSTUBNONENONE Additionally we do count statements in the wb-claims and sitelinks in the wb-sitelinks page prop, but we do not count terms. Therefor: We can find LINKSTUBs by searching for wb-claims = 0 & wb-sitelinks > 0. We can find EMPTYs and STUBs by searching for wb-claims = 0 & wb-sitelinks = 0. We can not distinguish between STUB and EMPTY. In my opinion the way this status is calculated does not make it very useful. It maps three dimensions (terms, statements and sitelinks) to a single flag (not a bit field). I suggest to drop it entirely and introduce a wb-terms page prop instead, if required.TASK DETAILhttps://phabricator.wikimedia.org/T146792EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Multichill, Lydia_Pintscher, thiemowmde, Addshore, daniel, aude, Aklapper, hoo, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T146792: Remove (seemingly) unused wb-status page prop (EntityContent::getEntityStatus)
daniel added a comment. This has been around forever. It was meant mainly for statistics, IIRC. We now track the number of statements and sitelinks (and labels?) in separate page_props, so this probably isn't needed any more. Kind of nice to have though, since it's consistent with what MW will consider an "article" in the site stats (I think - needs confirmation).TASK DETAILhttps://phabricator.wikimedia.org/T146792EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Multichill, Lydia_Pintscher, thiemowmde, Addshore, daniel, aude, Aklapper, hoo, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T146792: Remove (seemingly) unused wb-status page prop (EntityContent::getEntityStatus)
Multichill added a comment. This page_prop doesn't ring a bell. When was it introduced? Did anyone dig up a commit?TASK DETAILhttps://phabricator.wikimedia.org/T146792EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MultichillCc: Multichill, Lydia_Pintscher, thiemowmde, Addshore, daniel, aude, Aklapper, hoo, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T146792: Remove (seemingly) unused wb-status page prop (EntityContent::getEntityStatus)
Lydia_Pintscher added a comment. I think we introduced this not for our own use but for bot authors. So yes we should ask. Let's see what @Multichill says as the next step.TASK DETAILhttps://phabricator.wikimedia.org/T146792EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Multichill, Lydia_Pintscher, thiemowmde, Addshore, daniel, aude, Aklapper, hoo, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T146792: Remove (seemingly) unused wb-status page prop (EntityContent::getEntityStatus)
Lydia_Pintscher added a comment. What data is it holding?TASK DETAILhttps://phabricator.wikimedia.org/T146792EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Lydia_Pintscher, thiemowmde, Addshore, daniel, aude, Aklapper, hoo, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
