[Wikidata-bugs] [Maniphest] [Commented On] T150655: Validator for EntityId should check that foreign repo prefix is known

2016-11-29 Thread gerritbot 
gerritbot added a comment.
Change 323404 merged by jenkins-bot:
Integrate ForeignEntityValidator with ValidatorBuilders.

https://gerrit.wikimedia.org/r/323404TASK DETAILhttps://phabricator.wikimedia.org/T150655EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: gerritbot, WMDE-leszek, Aklapper, daniel, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T150655: Validator for EntityId should check that foreign repo prefix is known

2016-11-28 Thread gerritbot 
gerritbot added a comment.
Change 322093 merged by jenkins-bot:
Add ForeignEntityValidator.

https://gerrit.wikimedia.org/r/322093TASK DETAILhttps://phabricator.wikimedia.org/T150655EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: gerritbot, WMDE-leszek, Aklapper, daniel, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T150655: Validator for EntityId should check that foreign repo prefix is known

2016-11-24 Thread gerritbot 
gerritbot added a comment.
Change 323404 had a related patch set uploaded (by Jakob):
Integrate ForeignEntityValidator with ValidatorBuilders.

https://gerrit.wikimedia.org/r/323404TASK DETAILhttps://phabricator.wikimedia.org/T150655EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: gerritbot, WMDE-leszek, Aklapper, daniel, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T150655: Validator for EntityId should check that foreign repo prefix is known

2016-11-17 Thread gerritbot 
gerritbot added a comment.
Change 322093 had a related patch set uploaded (by Jakob):
Add ForeignEntityValidator.

https://gerrit.wikimedia.org/r/322093TASK DETAILhttps://phabricator.wikimedia.org/T150655EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: gerritbot, WMDE-leszek, Aklapper, daniel, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T150655: Validator for EntityId should check that foreign repo prefix is known

2016-11-17 Thread WMDE-leszek 
WMDE-leszek added a comment.
Good point. I think there should be a per-repo setting saying what entity types are enabled/relevant etc when using this particular repo.

BTW I haven't really thought much on how those settings should be configured but I believe for now the current format would still work fine. We might want to review it at some point, so we don't make a mess there.TASK DETAILhttps://phabricator.wikimedia.org/T150655EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, WMDE-leszekCc: WMDE-leszek, Aklapper, daniel, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T150655: Validator for EntityId should check that foreign repo prefix is known

2016-11-17 Thread Jakob_WMDE 
Jakob_WMDE added a comment.
@daniel ahh right, I'll use the new setting. Thanks!
Just to clarify: I was considering entityNamespaces not because I thought it had anything to do with namespaces but because it says in the docs that "Mapping must be done for each type of entity that should be supported." and we marked it as one of the settings to be done per repo.TASK DETAILhttps://phabricator.wikimedia.org/T150655EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDECc: WMDE-leszek, Aklapper, daniel, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T150655: Validator for EntityId should check that foreign repo prefix is known

2016-11-15 Thread daniel 
daniel added a comment.
@Jakob_WMDE This has nothing to do with namespaces. It's about repository prefixes.

We need to have a list of supported foreign repositories somewhere. Leszek introduced a foreignRepository setting in I618b127, I suggest to use that for the validator too.TASK DETAILhttps://phabricator.wikimedia.org/T150655EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, danielCc: Aklapper, daniel, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T150655: Validator for EntityId should check that foreign repo prefix is known

2016-11-15 Thread Jakob_WMDE 
Jakob_WMDE added a comment.
that foreign repo is enabled for the given entity type

How is this supposed to be done? By checking the repo specific entityNamespaces?TASK DETAILhttps://phabricator.wikimedia.org/T150655EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDECc: Aklapper, daniel, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs