[Wikidata-bugs] [Maniphest] [Commented On] T150848: Create a dispatching version of TermSearchInteractor

2016-11-30 Thread gerritbot 
gerritbot added a comment.
Change 322254 merged by jenkins-bot:
Expose the name of the repository on which TermSearchResult was found

https://gerrit.wikimedia.org/r/322254TASK DETAILhttps://phabricator.wikimedia.org/T150848EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszek, gerritbotCc: gerritbot, Lydia_Pintscher, Aklapper, daniel, Ramalepe, Liugev6, Acer, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Ricordisamoa, Fabrice_Florin, Mbch331, Tgr___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T150848: Create a dispatching version of TermSearchInteractor

2016-11-30 Thread gerritbot 
gerritbot added a comment.
Change 322118 merged by jenkins-bot:
Add DispatchingTermSearchInteractor

https://gerrit.wikimedia.org/r/322118TASK DETAILhttps://phabricator.wikimedia.org/T150848EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszek, gerritbotCc: gerritbot, Lydia_Pintscher, Aklapper, daniel, Ramalepe, Liugev6, Acer, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Ricordisamoa, Fabrice_Florin, Mbch331, Tgr___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T150848: Create a dispatching version of TermSearchInteractor

2016-11-30 Thread daniel 
daniel added a comment.
Most of this is done now. I'm wondering whether we want to explicitly expose the repo on which a match was found via the wbsearchentities API module. It's implicit in the entity IDs, but the client should not need to decode the IDs in order to indicate where a match was found.

Note that this will not be necessary for the baseline, where entity types are bound to repositories. But when we support using e.g. properties from different repos, we may want to indicate which property comes from where, to allow the user an informed choice of which vocabulary to use.TASK DETAILhttps://phabricator.wikimedia.org/T150848EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszek, danielCc: gerritbot, Lydia_Pintscher, Aklapper, daniel, Ramalepe, Liugev6, Acer, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Ricordisamoa, Fabrice_Florin, Mbch331, Tgr___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T150848: Create a dispatching version of TermSearchInteractor

2016-11-18 Thread gerritbot 
gerritbot added a comment.
Change 322254 had a related patch set uploaded (by WMDE-leszek):
Expose the name of the repository on which TermSearchResult was found

https://gerrit.wikimedia.org/r/322254TASK DETAILhttps://phabricator.wikimedia.org/T150848EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszek, gerritbotCc: gerritbot, Lydia_Pintscher, Aklapper, daniel, Acer, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Ricordisamoa, Fabrice_Florin, Mbch331, Tgr___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T150848: Create a dispatching version of TermSearchInteractor

2016-11-18 Thread WMDE-leszek 
WMDE-leszek added a comment.
Regarding this part:

Eventually, TermSearchResults should get a new field identifying the repository on which a match was found.

If I get it right, it could already be fetched from the matched entity id. It makes sense to expose the repository name, and would be easy to have it, e.g. simply by adding TermSearchResult::getRepositoryName. Do we still want to have a field for this in TermSearchResult, along with the public method returning the repository name?TASK DETAILhttps://phabricator.wikimedia.org/T150848EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: gerritbot, Lydia_Pintscher, Aklapper, daniel, Acer, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Ricordisamoa, Fabrice_Florin, Mbch331, Tgr___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T150848: Create a dispatching version of TermSearchInteractor

2016-11-17 Thread gerritbot 
gerritbot added a comment.
Change 322118 had a related patch set uploaded (by WMDE-leszek):
Add DispatchingTermSearchInteractor

https://gerrit.wikimedia.org/r/322118TASK DETAILhttps://phabricator.wikimedia.org/T150848EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Lydia_Pintscher, Aklapper, daniel, Acer, D3r1ck01, Izno, Wikidata-bugs, aude, Ricordisamoa, Fabrice_Florin, Mbch331, Tgr___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs