[Wikidata-bugs] [Maniphest] [Commented On] T161789: [Task] Introduce HTML templates infrastructure for Wikibase Lexeme

2017-04-25 Thread gerritbot 
gerritbot added a comment.
Change 347337 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Remove subclassing and unused code from LexemeTemplateFactory

https://gerrit.wikimedia.org/r/347337TASK DETAILhttps://phabricator.wikimedia.org/T161789EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, gerritbotCc: gerritbot, thiemowmde, daniel, Aklapper, Ladsgroup, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T161789: [Task] Introduce HTML templates infrastructure for Wikibase Lexeme

2017-04-10 Thread gerritbot 
gerritbot added a comment.
Change 347337 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Remove subclassing and unused code from LexemeTemplateFactory

https://gerrit.wikimedia.org/r/347337TASK DETAILhttps://phabricator.wikimedia.org/T161789EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: gerritbot, thiemowmde, daniel, Aklapper, Ladsgroup, QZanden, Salgo60, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T161789: [Task] Introduce HTML templates infrastructure for Wikibase Lexeme

2017-04-05 Thread gerritbot 
gerritbot added a comment.
Change 345515 merged by Jonas Kress (WMDE):
[mediawiki/extensions/WikibaseLexeme@master] Introduce LexemeTemplateFactory and templates.php file

https://gerrit.wikimedia.org/r/345515TASK DETAILhttps://phabricator.wikimedia.org/T161789EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: gerritbot, thiemowmde, daniel, Aklapper, Ladsgroup, QZanden, Salgo60, D3r1ck01, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T161789: [Task] Introduce HTML templates infrastructure for Wikibase Lexeme

2017-04-03 Thread daniel 
daniel added a comment.
@thiemowmde you seem to be misunderstanding my suggestion. It boils down to literally just new TemplateFactory( '.lexeme-templates.php' );. That instances needs to be accessible somehow, so you need a "singleton" (really, a default instance). Can be a static member, but of which class? My suggestion is a class called LexemeServices, since we'll need that anyway. It comes down to a 10 line class called LexemeServices. I don't see the incredible overhead.TASK DETAILhttps://phabricator.wikimedia.org/T161789EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, danielCc: gerritbot, thiemowmde, daniel, Aklapper, Ladsgroup, QZanden, Salgo60, D3r1ck01, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T161789: [Task] Introduce HTML templates infrastructure for Wikibase Lexeme

2017-03-30 Thread gerritbot 
gerritbot added a comment.
Change 345514 abandoned by Ladsgroup:
Change $instance attribute visiblity in Template factory to protected

https://gerrit.wikimedia.org/r/345514TASK DETAILhttps://phabricator.wikimedia.org/T161789EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: gerritbot, thiemowmde, daniel, Aklapper, Ladsgroup, QZanden, Salgo60, D3r1ck01, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T161789: [Task] Introduce HTML templates infrastructure for Wikibase Lexeme

2017-03-30 Thread thiemowmde 
thiemowmde added a comment.
This sound like an incredible amount of overhead for a thing that can't be much more trivial: templates are basically nothing but an array of strings. We only need something like this (preferably not as complicated as outlined above) if LexemeView needs access to Wikibase templates, which is not the case right now. I strongly suggest to stick to the most trivial solution right now: a LexemeTemplateFactory with no singleton.TASK DETAILhttps://phabricator.wikimedia.org/T161789EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, thiemowmdeCc: thiemowmde, daniel, Aklapper, Ladsgroup, QZanden, Salgo60, D3r1ck01, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T161789: [Task] Introduce HTML templates infrastructure for Wikibase Lexeme

2017-03-30 Thread daniel 
daniel added a comment.
@Ladsgroup I have an alternative proposal. Here's how I understand the need:


we want a file defining templates for WikibaseRepo, and a factory service for getting these templates in PHP
we want a file defining templates for WikibaseLexeme, and a factory service for getting these templates in PHP


So:


remove the static singleton field from TemplateFactory
For WikibaseRepo, create a TemplateFactory instance that loads the template definitions for repo.
For WikibaseLexeme, create a TemplateFactory instance that loads the template definitions for lexeme.


The question is now where to get the right TemplateFactory instance from. TemplateFactory will have to be injected into services, so it has has to be available to wiring code. So the natural place for the repo instance is the WikibaseRepo top level factory. Managing a singleton in a static field, as we do now, will also work, but it annoying for testing etc.

Similarly, we could manage the TemplateFactory instance for lexeme in a static field of some class (which probably doesn't do anything else, and doesn't need to subclass TemplateFactory). However, we'll have to introduce a top level factory for WikibaseLexeme anyway, or at least some static front for accessing services, like MediaInfoServices.

So, my proposal is:


create a WikibaseLexemeServices class.
WikibaseLexemeServices manages a TemplateFactory instance  in a static field for now.
WikibaseLexemeServices can eventually become a proper top level factory
Optionally, remove the singleton from TemplateFactory, and move it to the WikibaseRepo top level factory
TASK DETAILhttps://phabricator.wikimedia.org/T161789EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, danielCc: daniel, Aklapper, Ladsgroup, QZanden, Salgo60, D3r1ck01, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs