[Wikidata-bugs] [Maniphest] [Commented On] T166227: [Bug] Special pages allow creating Properties with an empty datatype

2017-05-24 Thread gerritbot 
gerritbot added a comment.
Change 355443 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/Wikibase@master] Prevent creation of Properties without data type [WIP].

https://gerrit.wikimedia.org/r/355443TASK DETAILhttps://phabricator.wikimedia.org/T166227EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Rzuwig, aude, daniel, Aleksey_WMDE, Lydia_Pintscher, thiemowmde, Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T166227: [Bug] Special pages allow creating Properties with an empty datatype

2017-05-24 Thread daniel 
daniel added a comment.
Note that we introduced the ability to create entities from all the edit modules on purpose, to support automatic materialization of "virtual" MediaInfo entities. If we remove that ability, the UI for MediaInfo will need quite a bit of work.TASK DETAILhttps://phabricator.wikimedia.org/T166227EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Rzuwig, aude, daniel, Aleksey_WMDE, Lydia_Pintscher, thiemowmde, Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T166227: [Bug] Special pages allow creating Properties with an empty datatype

2017-05-24 Thread daniel 
daniel added a comment.
As to solving this issue: PropertyContent::isValid should at least check that the datatype is not empty. PropertyHandler::createEmptyEntity should probably fail.

But we should really make sure that properties can only be created with valid property types. EditEntity calls setDataTypeId in two places. The one that uses the value of $data['datatype'] directly should validate the data type first.TASK DETAILhttps://phabricator.wikimedia.org/T166227EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Rzuwig, aude, daniel, Aleksey_WMDE, Lydia_Pintscher, thiemowmde, Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T166227: [Bug] Special pages allow creating Properties with an empty datatype

2017-05-24 Thread daniel 
daniel added a comment.
According to wb_property_info, no such broken properties with an empty property type exist on wikidata:

MariaDB [wikidatawiki_p]> select * from wb_property_info where pi_type = "";
Empty set (0.00 sec)

TASK DETAILhttps://phabricator.wikimedia.org/T166227EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Rzuwig, aude, daniel, Aleksey_WMDE, Lydia_Pintscher, thiemowmde, Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T166227: [Bug] Special pages allow creating Properties with an empty datatype

2017-05-24 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.
As far as I can tell, there are no properties with invalid datatype in the query service (http://tinyurl.com/kvabzcp), but I don’t know what the exporter or the updater would do with such properties. Perhaps Quarry would be better suited for this?TASK DETAILhttps://phabricator.wikimedia.org/T166227EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Rzuwig, aude, daniel, Aleksey_WMDE, Lydia_Pintscher, thiemowmde, Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs