[Wikidata-bugs] [Maniphest] [Commented On] T166429: Getting a unclean output with {{#property:P856}} on site which enables Language Converter

2017-06-27 Thread cscott 
cscott added a comment.
@thiemowmde Nevermind, I got a little mixed up.  I was concerned that -{zh:Foo;zh-tw:Bar}- would add an entry to the global translation table, in addition to specifying a one-time conversion.  But that's not the case.  You need to add the A or H (or -) flag to have global effects.TASK DETAILhttps://phabricator.wikimedia.org/T166429EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, cscottCc: YFdyh000, cscott, ssastry, Elitre, gerritbot, fireattack, Shizhao, liangent, Aleksey_WMDE, Jonas, Jakob_WMDE, WMDE-leszek, hoo, aude, thiemowmde, Lydia_Pintscher, Aklapper, Cwek, GoranSMilovanovic, QZanden, JJMC89, Izno, LNDDYL, Fuzheado, Wikidata-bugs, zhuyifei1999, Arlolra, Jackmcbarn, Mbch331, Liuxinyu970226___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T166429: Getting a unclean output with {{#property:P856}} on site which enables Language Converter

2017-06-16 Thread thiemowmde 
thiemowmde added a comment.
@cscott, I'm afraid I don't understand. Is your comment a response to something specific that was said before? Do you think there is something we can improve, in addition to what https://gerrit.wikimedia.org/r/356801 already did? What "nonlocal" effects do you mean?TASK DETAILhttps://phabricator.wikimedia.org/T166429EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: YFdyh000, cscott, ssastry, Elitre, gerritbot, fireattack, Shizhao, liangent, Aleksey_WMDE, Jonas, Jakob_WMDE, WMDE-leszek, hoo, aude, thiemowmde, Lydia_Pintscher, Aklapper, Cwek, GoranSMilovanovic, QZanden, JJMC89, Izno, LNDDYL, Fuzheado, Wikidata-bugs, zhuyifei1999, Arlolra, Jackmcbarn, Mbch331, Liuxinyu970226___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T166429: Getting a unclean output with {{#property:P856}} on site which enables Language Converter

2017-06-15 Thread cscott 
cscott added a comment.
Hm, doesn't think -{...}- markup have side effects (ie, adding a rule to the conversion table) if the codes involved are languages, not scripts?  Seems like you ought to be a little careful, since the "escape" function being used can have nonlocal effects.TASK DETAILhttps://phabricator.wikimedia.org/T166429EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, cscottCc: YFdyh000, cscott, ssastry, Elitre, gerritbot, fireattack, Shizhao, liangent, Aleksey_WMDE, Jonas, Jakob_WMDE, WMDE-leszek, hoo, aude, thiemowmde, Lydia_Pintscher, Aklapper, Cwek, GoranSMilovanovic, QZanden, JJMC89, Izno, LNDDYL, Fuzheado, Wikidata-bugs, zhuyifei1999, Arlolra, Jackmcbarn, Mbch331, Liuxinyu970226___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T166429: Getting a unclean output with {{#property:P856}} on site which enables Language Converter

2017-06-06 Thread gerritbot 
gerritbot added a comment.
Change 356801 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Optimize VariantsAwareRenderer to not output broken weblink syntax

https://gerrit.wikimedia.org/r/356801TASK DETAILhttps://phabricator.wikimedia.org/T166429EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, gerritbotCc: Pigsonthewing, cscott, ssastry, Elitre, gerritbot, fireattack, Shizhao, liangent, Aleksey_WMDE, Jonas, Jakob_WMDE, WMDE-leszek, hoo, aude, thiemowmde, Lydia_Pintscher, Liuxinyu970226, Aklapper, Cwek, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, JJMC89, Maathavan, Izno, LNDDYL, Fuzheado, Wikidata-bugs, zhuyifei1999, Arlolra, Jackmcbarn, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T166429: Getting a unclean output with {{#property:P856}} on site which enables Language Converter

2017-06-03 Thread ssastry 
ssastry added a comment.



In T166429#3309853, @Cwek wrote:
@thiemowmde
 I think the second solution is maybe better. And I think that we can check the data type of property to confirm whether it is URL or not. If the date type of property is URL and the site have enabled Language Converter, the output does not format with variant code block.





In T166429#3312739, @cscott wrote:
This is not related to the preprocessor change, it is long-standing bug in php LanguageConverter (to wit, conversion is applied at an awkward point in the parser pipeline, so it doesn't properly respect other syntactic structures).  Sadly, LanguageConverter is riddled with these, although I've been making slow progress fixing them.

I personally prefer solution three above: there is no reason to make the URL vary by selected variant, only the link caption should change.  Effectively solution three would wrap the language variant inside the  tag, while the autolink behavior would emit multiple  tags inside the variant markup.


A combination of 2 and 3 is ideal. Where there is no reason to emit a language variant (as in this example), it makes sense to adopt 2. But, when necessary, I think we should generate wikitext that parses to a reasonable looking DOM structure. So, [URL -{text1;text2}-] is preferable to -{link1;link2}- ... the principle being to restrict variant code to the smallest well-formed DOM construct.TASK DETAILhttps://phabricator.wikimedia.org/T166429EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, ssastryCc: cscott, ssastry, Elitre, gerritbot, fireattack, Shizhao, liangent, Aleksey_WMDE, Jonas, Jakob_WMDE, WMDE-leszek, hoo, aude, thiemowmde, Lydia_Pintscher, Liuxinyu970226, Aklapper, Cwek, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, JJMC89, Maathavan, Izno, LNDDYL, Fuzheado, Wikidata-bugs, zhuyifei1999, Arlolra, Jackmcbarn, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T166429: Getting a unclean output with {{#property:P856}} on site which enables Language Converter

2017-06-03 Thread cscott 
cscott added a comment.
This is not related to the preprocessor change, it is long-standing bug in php LanguageConverter (to wit, conversion is applied at an awkward point in the parser pipeline, so it doesn't properly respect other syntactic structures).  Sadly, LanguageConverter is riddled with these, although I've been making slow progress fixing them.

I personally prefer solution three above: there is no reason to make the URL vary by selected variant, only the link caption should change.  Effectively solution three would wrap the language variant inside the  tag, while the autolink behavior would emit multiple  tags inside the variant markup.TASK DETAILhttps://phabricator.wikimedia.org/T166429EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, cscottCc: cscott, ssastry, Elitre, gerritbot, fireattack, Shizhao, liangent, Aleksey_WMDE, Jonas, Jakob_WMDE, WMDE-leszek, hoo, aude, thiemowmde, Lydia_Pintscher, Liuxinyu970226, Aklapper, Cwek, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, JJMC89, Maathavan, Izno, LNDDYL, Fuzheado, Wikidata-bugs, zhuyifei1999, Arlolra, Jackmcbarn, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T166429: Getting a unclean output with {{#property:P856}} on site which enables Language Converter

2017-06-03 Thread ssastry 
ssastry added a comment.

In T166429#3312548, @Elitre wrote:
@ssastry was this tied to the recent preprocessor change? Thanks.


The preprocessor change was deployed to these group2 wikis on June 1 and the bug report and other discussion is from before that. So, that indicates this is unrelated to the preprocessor change.TASK DETAILhttps://phabricator.wikimedia.org/T166429EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, ssastryCc: cscott, ssastry, Elitre, gerritbot, fireattack, Shizhao, liangent, Aleksey_WMDE, Jonas, Jakob_WMDE, WMDE-leszek, hoo, aude, thiemowmde, Lydia_Pintscher, Liuxinyu970226, Aklapper, Cwek, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, JJMC89, Maathavan, Izno, LNDDYL, Fuzheado, Wikidata-bugs, zhuyifei1999, Arlolra, Jackmcbarn, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T166429: Getting a unclean output with {{#property:P856}} on site which enables Language Converter

2017-06-02 Thread gerritbot 
gerritbot added a comment.
Change 356801 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase@master] Optimize VariantsAwareRenderer to not output broken weblink syntax

https://gerrit.wikimedia.org/r/356801TASK DETAILhttps://phabricator.wikimedia.org/T166429EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, fireattack, Shizhao, liangent, Aleksey_WMDE, Jonas, Jakob_WMDE, WMDE-leszek, hoo, aude, thiemowmde, Lydia_Pintscher, Liuxinyu970226, Aklapper, Cwek, GoranSMilovanovic, QZanden, Izno, LNDDYL, Fuzheado, Wikidata-bugs, zhuyifei1999, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T166429: Getting a unclean output with {{#property:P856}} on site which enables Language Converter

2017-06-01 Thread Cwek 
Cwek added a comment.
@thiemowmde
I think the second solution is maybe better. And I think that we can check the data type of property to confirm whether it is URL or not. If the date type of property is URL and the site have enabled Language Converter, the output does not format with variant code block.TASK DETAILhttps://phabricator.wikimedia.org/T166429EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CwekCc: fireattack, Shizhao, liangent, Aleksey_WMDE, Jonas, Jakob_WMDE, WMDE-leszek, hoo, aude, thiemowmde, Lydia_Pintscher, Liuxinyu970226, Aklapper, Cwek, GoranSMilovanovic, QZanden, Izno, LNDDYL, Fuzheado, Wikidata-bugs, zhuyifei1999, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs