[Wikidata-bugs] [Maniphest] [Commented On] T167589: Understand how skins and templates work

2017-06-19 Thread Kiailandi
Kiailandi added a comment.
Upon further investigation we discovered that skins are limited to menus / categories and so on and don't have effect on body content.

Based on this we will explore other options.TASK DETAILhttps://phabricator.wikimedia.org/T167589EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KiailandiCc: Afnecors, Hjfocs, Aklapper, Kiailandi, dachary, Wikidata-bugs, Ricordisamoa, Sjoerddebruin, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T167589: Understand how skins and templates work

2017-06-16 Thread Kiailandi
Kiailandi added a comment.

In T167589#3344712, @Hjfocs wrote:

In T167589#334, @Kiailandi wrote:

Mediawiki uses the Vector skin as default. Code can be found on the Github mirror.
Developing a skin from zero could be a huge work/overkill. I would suggest to simply fork Vector and extend it to achieve with php the same result we are achieving  right now with _javascript_.



@Kiailandi : can you confirmIs this is the skin that Wikidata uses?


Yes.

F8466637: image.pngTASK DETAILhttps://phabricator.wikimedia.org/T167589EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KiailandiCc: Afnecors, Hjfocs, Aklapper, Kiailandi, dachary, Wikidata-bugs, Ricordisamoa, Sjoerddebruin, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T167589: Understand how skins and templates work

2017-06-13 Thread Hjfocs
Hjfocs added a comment.

In T167589#334, @Kiailandi wrote:

Mediawiki uses the Vector skin as default. Code can be found on the Github mirror.
Developing a skin from zero could be a huge work/overkill. I would suggest to simply fork Vector and extend it to achieve with php the same result we are achieving  right now with _javascript_.



@Kiailandi : can you confirmIs this is the skin that Wikidata uses?TASK DETAILhttps://phabricator.wikimedia.org/T167589EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Kiailandi, HjfocsCc: Afnecors, Hjfocs, Aklapper, Kiailandi, dachary, Wikidata-bugs, Ricordisamoa, Sjoerddebruin, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T167589: Understand how skins and templates work

2017-06-12 Thread Kiailandi
Kiailandi added a comment.
Templates seem more "plain text" oriented and could be leveraged to simplify the source file (already used / done in current frontend JS file)TASK DETAILhttps://phabricator.wikimedia.org/T167589EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KiailandiCc: Afnecors, Hjfocs, Aklapper, Kiailandi, dachary, Wikidata-bugs, Ricordisamoa, Sjoerddebruin, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T167589: Understand how skins and templates work

2017-06-12 Thread Kiailandi
Kiailandi added a comment.
From Customization:Explaining skins

A 'Skin' in MediaWiki is a PHP class containing functions (or methods) designed to gather the information needed to generate the HTML that your browser displays for each page in the Wiki.

This could be the way to rework our current fronted to make it maintainable, modular and less of an UI hack.


Mediawiki uses the Vector skin as default. Code can be found on the Github mirror.
The manual on Skinning is pretty long and made of 3 parts:
Part 1
Part 2
Part 3

Developing a skin from zero could be a huge work/overkill. I would suggest to simply fork Vector and extend it to achieve with php the same result we are achieving  right now with _javascript_


As a starting point we will need to split our "monolithic" JS into a "template part", to translate it to php, and into the actual "user interaction" part that will remain as _javascript_.TASK DETAILhttps://phabricator.wikimedia.org/T167589EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KiailandiCc: Afnecors, Hjfocs, Aklapper, Kiailandi, dachary, Wikidata-bugs, Ricordisamoa, Sjoerddebruin, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs