[Wikidata-bugs] [Maniphest] [Commented On] T168245: Refactor HTML templates
Kiailandi added a comment.
While refactoring the template I've noticed that the valueview div used as a wrapper for our objects is not used in other "vanilla" wikidata pages.
'' +
'{{qualifier-object}}' +
'' +
Source: Primary Sources tool on Github
As far as I was able to understand the valueview class comes from the ValueView extension but I've not been able to understand how is it supposed to work for our objects or its purpose in the current template.
Because of this I will remove it in the new version of the template and eventually add it when replacing the {{qualifier-object}} placeholder via _javascript_ using the jQuery function instead of injecting plain text in the generated html template.TASK DETAILhttps://phabricator.wikimedia.org/T168245EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KiailandiCc: TerraCodes, Jay8g, Liuxinyu970226, PokestarFan, Aklapper, Hjfocs, Kiailandi, dachary, Wikidata-bugs, Ricordisamoa, Sjoerddebruin, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T168245: Refactor HTML templates
Kiailandi added a comment. In T168245#3404334, @Hjfocs wrote: duplicate of T168247 Considering what we discovered about the template system and the path we chose to follow I have re-opened the task as the refactoring process is not trivial.TASK DETAILhttps://phabricator.wikimedia.org/T168245EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KiailandiCc: TerraCodes, Jay8g, Liuxinyu970226, PokestarFan, Aklapper, Hjfocs, Kiailandi, dachary, Wikidata-bugs, Ricordisamoa, Sjoerddebruin, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
