[Wikidata-bugs] [Maniphest] [Commented On] T170668: "Unknown dependency: wikibase.mobile" on Wikidata element pages

2017-07-25 Thread Krinkle 
Krinkle added a comment.

In T170668#3457783, @Zache wrote:
I raised the priority to high because this prevents the editing of the wikidata if bug hits before property edit buttons are added.


The console warning Unknown dependency: wikibase.mobile may've looked like a fatal error (including stack trace), but I'm fairly sure it will not have caused edit buttons to not appear or any other sort of cascading failure. This error is an internal exception that is caught and logged to the console without affecting the loading of any other modules. The warning was recently introduced (previously it would be silently caught without logging). Given it looked new, that may've been why you associated the edit-button bug with this warning (but more likely being a "red herring").

This was a non-fatal error with no on-page impact. The commit that fixes the warning did so by not loading the module (meaning, same effective behaviour as before, but without the warning). As such, it seems unnecessary to have invalidated the entire parser cache on wikidata.org just to avoid a no-op warning from showing up in browser consoles to logged-in users for a few more days (whilst naturally rolling over the cache).TASK DETAILhttps://phabricator.wikimedia.org/T170668EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, KrinkleCc: Krinkle, Lucas_Werkmeister_WMDE, aude, Jay8g, TerraCodes, Magnus, Ptolusque, Lea_Lacroix_WMDE, hoo, Ladsgroup, Lydia_Pintscher, Multichill, Sannita, Jdlrobson, Pigsonthewing, Liuxinyu970226, gerritbot, PokestarFan, Nikki, Zache, Fomafix, Aklapper, Danmichaelo, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T170668: "Unknown dependency: wikibase.mobile" on Wikidata element pages

2017-07-24 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.
After that old parser caches will need to be invalidated, as the mobile only module is still in them.

What about this part? Was this also done?TASK DETAILhttps://phabricator.wikimedia.org/T170668EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, aude, Jay8g, TerraCodes, Magnus, Ptolusque, Lea_Lacroix_WMDE, hoo, Ladsgroup, Lydia_Pintscher, Multichill, Sannita, Jdlrobson, Pigsonthewing, Liuxinyu970226, gerritbot, PokestarFan, Nikki, Zache, Fomafix, Aklapper, Danmichaelo, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T170668: "Unknown dependency: wikibase.mobile" on Wikidata element pages

2017-07-24 Thread aude 
aude added a comment.
Fix for this is deployed nowTASK DETAILhttps://phabricator.wikimedia.org/T170668EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, audeCc: aude, Jay8g, TerraCodes, Magnus, Ptolusque, Lea_Lacroix_WMDE, hoo, Ladsgroup, Lydia_Pintscher, Multichill, Sannita, Jdlrobson, Pigsonthewing, Liuxinyu970226, gerritbot, PokestarFan, Nikki, Zache, Fomafix, Aklapper, Danmichaelo, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T170668: "Unknown dependency: wikibase.mobile" on Wikidata element pages

2017-07-23 Thread gerritbot 
gerritbot added a comment.
Change 367343 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.30.0-wmf.10] Only add the "wikibase.mobile" module when appropriate

https://gerrit.wikimedia.org/r/367343TASK DETAILhttps://phabricator.wikimedia.org/T170668EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, gerritbotCc: Ptolusque, Lea_Lacroix_WMDE, hoo, Ladsgroup, Lydia_Pintscher, Multichill, Sannita, Jdlrobson, Pigsonthewing, Liuxinyu970226, gerritbot, PokestarFan, Nikki, Zache, Fomafix, Aklapper, Danmichaelo, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T170668: "Unknown dependency: wikibase.mobile" on Wikidata element pages

2017-07-23 Thread gerritbot 
gerritbot added a comment.
Change 367343 had a related patch set uploaded (by Aude; owner: Hoo man):
[mediawiki/extensions/Wikibase@wmf/1.30.0-wmf.10] Only add the "wikibase.mobile" module when appropriate

https://gerrit.wikimedia.org/r/367343TASK DETAILhttps://phabricator.wikimedia.org/T170668EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, gerritbotCc: Ptolusque, Lea_Lacroix_WMDE, hoo, Ladsgroup, Lydia_Pintscher, Multichill, Sannita, Jdlrobson, Pigsonthewing, Liuxinyu970226, gerritbot, PokestarFan, Nikki, Zache, Fomafix, Aklapper, Danmichaelo, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T170668: "Unknown dependency: wikibase.mobile" on Wikidata element pages

2017-07-22 Thread gerritbot 
gerritbot added a comment.
Change 366853 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Only add the "wikibase.mobile" module when appropriate

https://gerrit.wikimedia.org/r/366853TASK DETAILhttps://phabricator.wikimedia.org/T170668EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, gerritbotCc: Lea_Lacroix_WMDE, hoo, Ladsgroup, Lydia_Pintscher, Multichill, Sannita, Jdlrobson, Pigsonthewing, Liuxinyu970226, gerritbot, PokestarFan, Nikki, Zache, Fomafix, Aklapper, Danmichaelo, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T170668: "Unknown dependency: wikibase.mobile" on Wikidata element pages

2017-07-22 Thread hoo 
hoo added a comment.
My fix should probably backported next week. After that old parser caches will need to be invalidated, as the mobile only module is still in them.TASK DETAILhttps://phabricator.wikimedia.org/T170668EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: hoo, Ladsgroup, Lydia_Pintscher, Multichill, Sannita, Jdlrobson, Pigsonthewing, Liuxinyu970226, gerritbot, PokestarFan, Nikki, Zache, Fomafix, Aklapper, Danmichaelo, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T170668: "Unknown dependency: wikibase.mobile" on Wikidata element pages

2017-07-22 Thread Multichill 
Multichill added a comment.
I run into the same problem, No edit buttons on https://www.wikidata.org/wiki/Q24074537

Error: Unknown dependency: wikibase.mobile Error: Unknown dependency: wikibase.mobile
Stack trace:
sortDependencies@https://www.wikidata.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&_only_=scripts&skin=vector&version=18ol06u:159:205
resolveStubbornly@https://www.wikidata.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&_only_=scripts&skin=vector&version=18ol06u:160:360
load@https://www.wikidata.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&_only_=scripts&skin=vector&version=18ol06u:171:122
@https://www.wikidata.org/wiki/Q24074537:10:4
startUp@https://www.wikidata.org/w/load.php?debug=false&lang=en&modules=startup&_only_=scripts&skin=vector:75:372
script.onreadystatechange@https://www.wikidata.org/w/load.php?debug=false&lang=en&modules=startup&_only_=scripts&skin=vector:75:882

logError https://www.wikidata.org/w/load.php:177:330
	handler https://www.wikidata.org/w/load.php:155:832
	fire https://www.wikidata.org/w/load.php:45:104
	fireWith https://www.wikidata.org/w/load.php:46:431
	fire https://www.wikidata.org/w/load.php:46:474
	track https://www.wikidata.org/w/load.php:155:614
	resolveStubbornly https://www.wikidata.org/w/load.php:160:425
	load https://www.wikidata.org/w/load.php:171:122
	 https://www.wikidata.org/wiki/Q24074537:10:4
	startUp https://www.wikidata.org/w/load.php:75:372
	script.onreadystatechange https://www.wikidata.org/w/load.php:75:882

And I get some extra warnings I'm not sure are related:

This page is using the deprecated ResourceLoader module "jquery.ui.position".  load.php:77:291
This page is using the deprecated ResourceLoader module "jquery.ui.widget".  load.php:108:942
This page is using the deprecated ResourceLoader module "jquery.ui.core".
Please use "mediawiki.ui.button" or "oojs-ui" instead.  load.php:20:84
This page is using the deprecated ResourceLoader module "jquery.jStorage".
Please use "mediawiki.storage" instead.  load.php:535:947
This page is using the deprecated ResourceLoader module "jquery.tipsy".  load.php:584:171
Your skin is incompatible with VisualEditor. See https://www.mediawiki.org/wiki/VisualEditor/Skin_requirements for the requirements.  load.php:478:604TASK DETAILhttps://phabricator.wikimedia.org/T170668EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MultichillCc: Multichill, Sannita, Jdlrobson, Pigsonthewing, Liuxinyu970226, gerritbot, PokestarFan, Nikki, Zache, Fomafix, Aklapper, Danmichaelo, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T170668: "Unknown dependency: wikibase.mobile" on Wikidata element pages

2017-07-21 Thread Sannita 
Sannita added a comment.
Same here, here's a screenshot of the problem: while I get an "edit" button for labels and sitelinks, I cannot edit the properties. F8808254: WDbug.pngTASK DETAILhttps://phabricator.wikimedia.org/T170668EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SannitaCc: Sannita, Jdlrobson, Pigsonthewing, Liuxinyu970226, gerritbot, PokestarFan, Nikki, Zache, Fomafix, Aklapper, Danmichaelo, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T170668: "Unknown dependency: wikibase.mobile" on Wikidata element pages

2017-07-21 Thread Jdlrobson 
Jdlrobson added a comment.
Not sure I understand what's happening here.
https://github.com/wikimedia/mediawiki-extensions-Wikidata/blob/6577cec77a28c088e269671b6b69c095463c30fa/extensions/Wikibase/view/resources/wikibase/resources.php#L42
sets a target of 'mobile'

Thus if you load it on a desktop target it will throw this exception.

if it's supposed to be loaded on mobile change the targets field to desktop, mobile
If it's not you should be adding it via an appropriate hook e.g. https://www.mediawiki.org/wiki/Extension:MobileFrontend/MobileSiteOutputPageBeforeExecTASK DETAILhttps://phabricator.wikimedia.org/T170668EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: Jdlrobson, Pigsonthewing, Liuxinyu970226, gerritbot, PokestarFan, Nikki, Zache, Fomafix, Aklapper, Danmichaelo, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T170668: "Unknown dependency: wikibase.mobile" on Wikidata element pages

2017-07-21 Thread gerritbot 
gerritbot added a comment.Herald added a subscriber: PokestarFan.
Change 366853 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Use addModuleStyles for adding mobile styles

https://gerrit.wikimedia.org/r/366853TASK DETAILhttps://phabricator.wikimedia.org/T170668EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, PokestarFan, Nikki, Zache, Fomafix, Aklapper, Danmichaelo, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T170668: "Unknown dependency: wikibase.mobile" on Wikidata element pages

2017-07-21 Thread Zache 
Zache added a comment.
Purge seems to change the load order so that one can edit the page. "Unknown dependency: wikibase.mobile Error" is still there after purge and if debug-mode is used then add/edit links are missing again.TASK DETAILhttps://phabricator.wikimedia.org/T170668EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ZacheCc: Nikki, Zache, Fomafix, Aklapper, Danmichaelo, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T170668: "Unknown dependency: wikibase.mobile" on Wikidata element pages

2017-07-20 Thread Nikki 
Nikki added a comment.
I'm also having the same problem with not being able to edit on quite a few pages. I tried refreshing, but that doesn't help. Purging the page makes it editable again, but having to do that for every affected page before I can edit is rather inconvenient.TASK DETAILhttps://phabricator.wikimedia.org/T170668EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: NikkiCc: Nikki, Zache, Fomafix, Aklapper, Danmichaelo, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T170668: "Unknown dependency: wikibase.mobile" on Wikidata element pages

2017-07-15 Thread Fomafix 
Fomafix added a comment.
I also get this error message in the _javascript_ console on Wikidata.TASK DETAILhttps://phabricator.wikimedia.org/T170668EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: FomafixCc: Fomafix, Aklapper, Danmichaelo, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs