[Wikidata-bugs] [Maniphest] [Commented On] T173026: Coordinate parser interprets lowercase S/W as N/E
Lucas_Werkmeister_WMDE added a comment. This should be fixed with Ieea56a7686 , probably deployed on Wednesday.TASK DETAILhttps://phabricator.wikimedia.org/T173026EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Lucas_Werkmeister_WMDE, Izno, Aklapper, Nikki, PokestarFan, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T173026: Coordinate parser interprets lowercase S/W as N/E
gerritbot added a comment. Change 449737 abandoned by Lucas Werkmeister (WMDE): Update data-values/geo to 2.1.2 Reason: Obsoleted by Ieea56a7686. https://gerrit.wikimedia.org/r/449737TASK DETAILhttps://phabricator.wikimedia.org/T173026EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Izno, Aklapper, Nikki, PokestarFan, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T173026: Coordinate parser interprets lowercase S/W as N/E
gerritbot added a comment. Change 449737 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/vendor@master] Update data-values/geo to 2.1.2 https://gerrit.wikimedia.org/r/449737TASK DETAILhttps://phabricator.wikimedia.org/T173026EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Izno, Aklapper, Nikki, PokestarFan, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T173026: Coordinate parser interprets lowercase S/W as N/E
Lucas_Werkmeister_WMDE added a comment.
Hm, I don’t think the in_array is the issue – that only checks the $direction, after all, not anything from the $matches, so that should always have the right case. I think the issue is a few lines further up:
if ( $matches[1] === $direction || $matches[3] === $direction ) {
This will be false for all four $directions if the match differs in case, so the method will fall back to the final return $coordinateSegment; outside the loop, without ever adding a minus sign.TASK DETAILhttps://phabricator.wikimedia.org/T173026EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Izno, Aklapper, Nikki, PokestarFan, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T173026: Coordinate parser interprets lowercase S/W as N/E
Nikki added a comment.
I just ran into this problem again and was about to report it, only to find I already did a year ago...
I went hunting for the source of the problem and I think it might be in https://github.com/DataValues/Geo/blob/master/src/Parsers/LatLongParserBase.php#L219. The regex on line 222 (and elsewhere) is case insensitive, so things like "s" are considered valid, but then line 230 only checks for the canonical case when deciding whether to make the value negative. Maybe changing that line to something like if ( in_array( strtolower( $direction ), [ strtolower( $s ), strtolower( $w ) ] ) ) { will fix it?TASK DETAILhttps://phabricator.wikimedia.org/T173026EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: NikkiCc: Izno, Aklapper, Nikki, PokestarFan, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T173026: Coordinate parser interprets lowercase S/W as N/E
Izno added a comment. The other alternative would be to treat 1 S 1 W as -1 N -1 E.TASK DETAILhttps://phabricator.wikimedia.org/T173026EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: IznoCc: Izno, Aklapper, Nikki, PokestarFan, GoranSMilovanovic, QZanden, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
