[Wikidata-bugs] [Maniphest] [Commented On] T173842: [BUG] Wikidata description for the specific Chinese language variant should be shown

[fantasticfears]

fantasticfears added a comment.


  Those variants are better off with fallback chains as Mediawiki (that’s a 
nice system)

TASK DETAIL
  https://phabricator.wikimedia.org/T173842

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: cooltey, fantasticfears
Cc: shinjiman, Yuriy_kosygin, Addshore, CXuesong, fantasticfears, cscott, 
gerritbot, Liuxinyu970226, cooltey, Dbrant, Mholloway, bearND, Tbayer, 
Aklapper, RHo, alaa_wmde, Nandana, Charlotte, Lahi, Gq86, Sharvaniharan, 
BJ6123C7BTD, schoenbaechler, Maggouri, Jcasariego, GoranSMilovanovic, lisong, 
RazeSoldier, Allthingsgo, QZanden, cmadeo, LawExplorer, _jensen, rosalieper, 
Taiwania_Justo, LNDDYL, Fuzheado, Cwek, Wikidata-bugs, aude, zhuyifei1999, 
Shizhao, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T173842: [BUG] Wikidata description for the specific Chinese language variant should be shown

[shinjiman]

shinjiman added a comment.


  Isn't this task to merge the entries into the single "Chinese" entry??
  
  Seems the merging is not quite suitable because there's some matters such as 
different names in different region such as the title of a movie, or a drama 
series.
  
  At least please leave those variants alone as before, such as "zh-CN", 
"zh-HK", "zh-MO", "zh-TW", "zh-SG", "zh-MY" etc.F28757190: 
Wikidata_edit_labels_Chinese_only.PNG 


TASK DETAIL
  https://phabricator.wikimedia.org/T173842

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: cooltey, shinjiman
Cc: shinjiman, Yuriy_kosygin, Addshore, CXuesong, fantasticfears, cscott, 
gerritbot, Liuxinyu970226, cooltey, Dbrant, Mholloway, bearND, Tbayer, 
Aklapper, RHo, alaa_wmde, Nandana, Charlotte, Lahi, Gq86, Sharvaniharan, 
BJ6123C7BTD, schoenbaechler, Maggouri, Jcasariego, GoranSMilovanovic, lisong, 
RazeSoldier, Allthingsgo, QZanden, cmadeo, LawExplorer, _jensen, rosalieper, 
Taiwania_Justo, LNDDYL, Fuzheado, Cwek, Wikidata-bugs, aude, zhuyifei1999, 
Shizhao, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T173842: [BUG] Wikidata description for the specific Chinese language variant should be shown

[Yuriy_kosygin]

Yuriy_kosygin added a comment.


  @Liuxinyu970226 Sorry...  I mean the result is the no conversion.

TASK DETAIL
  https://phabricator.wikimedia.org/T173842

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: cooltey, Yuriy_kosygin
Cc: Yuriy_kosygin, Addshore, CXuesong, fantasticfears, cscott, gerritbot, 
Liuxinyu970226, cooltey, Dbrant, Mholloway, bearND, Tbayer, Aklapper, RHo, 
alaa_wmde, Nandana, Charlotte, Lahi, Gq86, Sharvaniharan, BJ6123C7BTD, 
schoenbaechler, Maggouri, Jcasariego, GoranSMilovanovic, lisong, RazeSoldier, 
Allthingsgo, QZanden, cmadeo, LawExplorer, _jensen, rosalieper, Taiwania_Justo, 
LNDDYL, Fuzheado, Cwek, Wikidata-bugs, aude, zhuyifei1999, Shizhao, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T173842: [BUG] Wikidata description for the specific Chinese language variant should be shown

[Yuriy_kosygin]

Yuriy_kosygin added a comment.


  @Liuxinyu970226 Mm... I didn't use the IOS system, but I used Android. I 
think the result is the same.
  
  F28322236: IMG_20190304_082557.jpg 


TASK DETAIL
  https://phabricator.wikimedia.org/T173842

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: cooltey, Yuriy_kosygin
Cc: Yuriy_kosygin, Addshore, CXuesong, fantasticfears, cscott, gerritbot, 
Liuxinyu970226, cooltey, Dbrant, Mholloway, bearND, Tbayer, Aklapper, RHo, 
Nandana, Charlotte, Lahi, Gq86, Sharvaniharan, BJ6123C7BTD, schoenbaechler, 
Maggouri, Jcasariego, GoranSMilovanovic, lisong, RazeSoldier, Allthingsgo, 
QZanden, cmadeo, LawExplorer, _jensen, rosalieper, Taiwania_Justo, LNDDYL, 
Fuzheado, Cwek, Wikidata-bugs, aude, zhuyifei1999, Shizhao, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T173842: [BUG] Wikidata description for the specific Chinese language variant should be shown

[Liuxinyu970226]

Liuxinyu970226 added a comment.


  Should I also add #ios-app-bugs 
 and 
#wikipedia-android-app-backlog 
 ? Or, is 
this very bug also happened on iOS?

TASK DETAIL
  https://phabricator.wikimedia.org/T173842

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: cooltey, Liuxinyu970226
Cc: Yuriy_kosygin, Addshore, CXuesong, fantasticfears, cscott, gerritbot, 
Liuxinyu970226, cooltey, Dbrant, Mholloway, bearND, Tbayer, Aklapper, RHo, 
Nandana, Charlotte, Lahi, Gq86, Sharvaniharan, BJ6123C7BTD, schoenbaechler, 
Maggouri, Jcasariego, GoranSMilovanovic, lisong, RazeSoldier, Allthingsgo, 
QZanden, cmadeo, LawExplorer, _jensen, rosalieper, Taiwania_Justo, LNDDYL, 
Fuzheado, Cwek, Wikidata-bugs, aude, zhuyifei1999, Shizhao, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T173842: [BUG] Wikidata description for the specific Chinese language variant should be shown

[fantasticfears]

fantasticfears added a comment.
@Addshore I was actually proposing storage/data model. If I have some information about how the data gets rendered from DB, I might be able to submit patches.TASK DETAILhttps://phabricator.wikimedia.org/T173842EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: cooltey, fantasticfearsCc: Addshore, CXuesong, fantasticfears, cscott, gerritbot, Liuxinyu970226, cooltey, Dbrant, Mholloway, bearND, Tbayer, Aklapper, RHo, Nandana, Charlotte, Lahi, Gq86, Sharvaniharan, BJ6123C7BTD, schoenbaechler, Maggouri, Jcasariego, GoranSMilovanovic, lisong, RazeSoldier, Allthingsgo, QZanden, cmadeo, LawExplorer, _jensen, D3r1ck01, Taiwania_Justo, LNDDYL, Fuzheado, Cwek, Wikidata-bugs, aude, zhuyifei1999, Shizhao, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T173842: [BUG] Wikidata description for the specific Chinese language variant should be shown

[Addshore]

Addshore added a comment.

In T173842#3658746, @Mholloway wrote:
For the mobileview API, this is the method I think we'd need to update for variant support: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/27599dfbdaecf1ca0a12164e648a14facefd00d2/includes/MobileFrontend.body.php#L189-L209


Yup, it looks like this needs to be updated to also account for the user language variant, currently it just uses the site content language.
This description is used in onOutputPageParserOutput (not sure if the stuff there is cached), might require a cache split based on user content language variant (not sure if it is already split on that)?

Should be a pretty smallish patch to #mobilefrontendTASK DETAILhttps://phabricator.wikimedia.org/T173842EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: cooltey, AddshoreCc: Addshore, CXuesong, fantasticfears, cscott, gerritbot, Liuxinyu970226, cooltey, Dbrant, Mholloway, bearND, Tbayer, Aklapper, RHo, Charlotte, Lahi, Gq86, Hello903hello, Sharvaniharan, BJ6123C7BTD, Maggouri, Jcasariego, GoranSMilovanovic, lisong, RazeSoldier, QZanden, LawExplorer, Taiwania_Justo, LNDDYL, Fuzheado, Cwek, Wikidata-bugs, aude, zhuyifei1999, Shizhao, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs