[Wikidata-bugs] [Maniphest] [Commented On] T179535: Not possible to change tabs in code popup on Safari

2017-11-06 Thread gerritbot 
gerritbot added a comment.
Change 388524 merged by jenkins-bot:
[wikidata/query/gui@master] Only initialize code example dialog when shown

https://gerrit.wikimedia.org/r/388524TASK DETAILhttps://phabricator.wikimedia.org/T179535EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Sjoerddebruin, Aklapper, Lahi, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, Lewizho99, Maathavan, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T179535: Not possible to change tabs in code popup on Safari

2017-11-03 Thread gerritbot 
gerritbot added a comment.
Change 388524 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[wikidata/query/gui@master] Only initialize code example dialog once

https://gerrit.wikimedia.org/r/388524TASK DETAILhttps://phabricator.wikimedia.org/T179535EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Sjoerddebruin, Aklapper, EBjune, merbst, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T179535: Not possible to change tabs in code popup on Safari

2017-11-03 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.
Hah, we were actually rebuilding the whole dialog with each click, but the browser is fast enough that it mostly looked like nothing was happening :D fix coming up.TASK DETAILhttps://phabricator.wikimedia.org/T179535EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Sjoerddebruin, Aklapper, EBjune, merbst, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T179535: Not possible to change tabs in code popup on Safari

2017-11-03 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.
Furthermore, when I spam-click a tab very quickly, occasionally the right tab flashes up quickly. So I suspect that the tab switching works, and then something, for some reason, switches you back to the URL tab.TASK DETAILhttps://phabricator.wikimedia.org/T179535EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Sjoerddebruin, Aklapper, EBjune, merbst, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T179535: Not possible to change tabs in code popup on Safari

2017-11-03 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.
It looks like you can actually select any tab with $('[href=""> (substituting the right name in place of HTML), but clicking any tab always gets you back to the URL tab.TASK DETAILhttps://phabricator.wikimedia.org/T179535EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Sjoerddebruin, Aklapper, EBjune, merbst, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T179535: Not possible to change tabs in code popup on Safari

2017-11-03 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.
Ah, it seems I can also reproduce this in Gnome’s “Web” browser (aka “Epiphany”). That should help, at least :)TASK DETAILhttps://phabricator.wikimedia.org/T179535EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Sjoerddebruin, Aklapper, EBjune, merbst, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T179535: Not possible to change tabs in code popup on Safari

2017-11-03 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.
If there are no errors in the console, I’m not sure how to debug this… as a random guess – does $('[href=""> work to show the HTML tab?TASK DETAILhttps://phabricator.wikimedia.org/T179535EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Sjoerddebruin, Aklapper, EBjune, merbst, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T179535: Not possible to change tabs in code popup on Safari

2017-11-02 Thread Sjoerddebruin 
Sjoerddebruin added a comment.

In T179535#3728976, @Lucas_Werkmeister_WMDE wrote:
Hm, AFAICT we’re just using Bootstrap components for this… do the tabs on this page work in Safari?


These (of course) work. Clicking the tab does reselect the text area (the cursor flickers), but the content doesn't change.TASK DETAILhttps://phabricator.wikimedia.org/T179535EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SjoerddebruinCc: Lucas_Werkmeister_WMDE, Sjoerddebruin, Aklapper, EBjune, merbst, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T179535: Not possible to change tabs in code popup on Safari

2017-11-02 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.
Hm, AFAICT we’re just using Bootstrap components for this… do the tabs on this page work in Safari?TASK DETAILhttps://phabricator.wikimedia.org/T179535EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Sjoerddebruin, Aklapper, EBjune, merbst, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs