[Wikidata-bugs] [Maniphest] [Commented On] T183831: wikidata/query/gui CI job lacks PhantomJS / proper browsers
Addshore added a comment. Poke @hashar ?TASK DETAILhttps://phabricator.wikimedia.org/T183831EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Lucas_Werkmeister_WMDE, gerritbot, Aklapper, hashar, Jonas, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Salgo60, Lewizho99, Maathavan, _jensen, D3r1ck01, Xmlizer, thcipriani, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183831: wikidata/query/gui CI job lacks PhantomJS / proper browsers
Addshore added a comment. @hashar does this still happen now? We recently bumped some versions of some stuff!TASK DETAILhttps://phabricator.wikimedia.org/T183831EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Lucas_Werkmeister_WMDE, gerritbot, Aklapper, hashar, Jonas, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Salgo60, Lewizho99, Maathavan, D3r1ck01, Xmlizer, thcipriani, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183831: wikidata/query/gui CI job lacks PhantomJS / proper browsers
hashar added a comment. It still happens. The CI job uses the container docker-registry.wikimedia.org/releng/npm-browser-test:0.1.2 and have PhantomJS. The npm package phantomjs-prebuilt apparently find it: > phantomjs-prebuilt@2.1.16 install /src/node_modules/phantomjs-prebuilt > node install.js Considering PhantomJS found at /usr/bin/phantomjs Found PhantomJS at /usr/bin/phantomjs ...verifying Writing location.js file PhantomJS is already installed on PATH at /usr/bin/phantomjs There is still an error showing up, but maybe that is just noise on the console while the test handle the actual error: Running "qunit:all" (qunit) task Testing wikibase/tests/index.html ..Error: Problem parsing d="M51.5,220.5ZL51.5,220.5ZLM" Error: Problem parsing d="M51.5,18.352951ZL51.5,220.5ZLM" ..OK Testing wikibase/tests/QueryHelper.html .OK >> 113 tests completed with 0 failed, 0 skipped, and 0 todo. >> 294 assertions (in 1623ms), passed: 294, failed: 0 DoneTASK DETAILhttps://phabricator.wikimedia.org/T183831EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: Addshore, Lucas_Werkmeister_WMDE, gerritbot, Aklapper, hashar, Jonas, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Salgo60, Lewizho99, Maathavan, Xmlizer, thcipriani, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331, Jay8g, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183831: wikidata/query/gui CI job lacks PhantomJS / proper browsers
Addshore added a comment. @hashar @Jonas is this all resolved?TASK DETAILhttps://phabricator.wikimedia.org/T183831EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Lucas_Werkmeister_WMDE, gerritbot, Aklapper, hashar, Jonas, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Salgo60, Lewizho99, Maathavan, Xmlizer, thcipriani, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331, Jay8g, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183831: wikidata/query/gui CI job lacks PhantomJS / proper browsers
Lucas_Werkmeister_WMDE added a comment. Is there anything left to do on this task or can we close it? I’m not sure if we want to spend too much time to figure out why the PhantomJS error didn’t cause a CI failure.TASK DETAILhttps://phabricator.wikimedia.org/T183831EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, gerritbot, Aklapper, hashar, Jonas, Adrian1985, Cpaulf30, Gq86, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, EBjune, merbst, Lewizho99, Maathavan, Xmlizer, thcipriani, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Jay8g, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183831: wikidata/query/gui CI job lacks PhantomJS / proper browsers
Lucas_Werkmeister_WMDE added a comment. Okay, regular test failures are picked up at least…TASK DETAILhttps://phabricator.wikimedia.org/T183831EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, gerritbot, Aklapper, hashar, Jonas, Cpaulf30, Gq86, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, EBjune, merbst, Lewizho99, Maathavan, Xmlizer, thcipriani, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Jay8g, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183831: wikidata/query/gui CI job lacks PhantomJS / proper browsers
gerritbot added a comment. Change 401534 abandoned by Lucas Werkmeister (WMDE): DNM: break tests Reason: CI failed, as expected https://gerrit.wikimedia.org/r/401534TASK DETAILhttps://phabricator.wikimedia.org/T183831EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Lucas_Werkmeister_WMDE, gerritbot, Aklapper, hashar, Jonas, Cpaulf30, Gq86, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, EBjune, merbst, Lewizho99, Maathavan, Xmlizer, thcipriani, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Jay8g, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183831: wikidata/query/gui CI job lacks PhantomJS / proper browsers
gerritbot added a comment. Change 401534 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [wikidata/query/gui@master] DNM: break tests https://gerrit.wikimedia.org/r/401534TASK DETAILhttps://phabricator.wikimedia.org/T183831EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Lucas_Werkmeister_WMDE, gerritbot, Aklapper, hashar, Jonas, Cpaulf30, Gq86, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, EBjune, merbst, Lewizho99, Maathavan, Xmlizer, thcipriani, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Jay8g, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183831: wikidata/query/gui CI job lacks PhantomJS / proper browsers
hashar added a comment. I would guess that grunt-contrib-qunit does not handle the error? I haven't looked at the modules code.TASK DETAILhttps://phabricator.wikimedia.org/T183831EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: Lucas_Werkmeister_WMDE, gerritbot, Aklapper, hashar, Jonas, Cpaulf30, Gq86, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, EBjune, merbst, Lewizho99, Maathavan, Xmlizer, thcipriani, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Jay8g, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183831: wikidata/query/gui CI job lacks PhantomJS / proper browsers
Lucas_Werkmeister_WMDE added a comment. (I’ve had the “problem parsing d=…” error locally for months, probably unrelated.) But even if the tests now work again – why did Jenkins vote +2 when they failed? Did npm still return exit code 0 in that case, or did Jenkins ignore the exit code?TASK DETAILhttps://phabricator.wikimedia.org/T183831EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, gerritbot, Aklapper, hashar, Jonas, Cpaulf30, Gq86, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, EBjune, merbst, Lewizho99, Maathavan, Xmlizer, thcipriani, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Jay8g, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183831: wikidata/query/gui CI job lacks PhantomJS / proper browsers
hashar added a comment. Gave it a try on a dummy change https://gerrit.wikimedia.org/r/#/c/401476/ the Jenkins console yields: Running "qunit:all" (qunit) task Testing wikibase/tests/index.html ..Error: Problem parsing d="M51.5,220.5ZL51.5,220.5ZLM" Error: Problem parsing d="M51.5,18.352951ZL51.5,220.5ZLM" .OK Testing wikibase/tests/QueryHelper.html OK >> 111 tests completed with 0 failed, 0 skipped, and 0 todo. >> 282 assertions (in 1594ms), passed: 282, failed: 0 Done. I guess the error comes from the PhantomJS console and is expected. Bonus point: replace grunt-contrib-qunit (which uses PhantomJS) by karma-qunit and the karma launchers. analytics/wikistats2 and unicodejs repositories have examples.TASK DETAILhttps://phabricator.wikimedia.org/T183831EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: gerritbot, Aklapper, hashar, Jonas, Cpaulf30, Gq86, Baloch007, Darkminds3113, Lordiis, Lucas_Werkmeister_WMDE, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, EBjune, merbst, Lewizho99, Maathavan, Xmlizer, thcipriani, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Jay8g, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183831: wikidata/query/gui CI job lacks PhantomJS / proper browsers
gerritbot added a comment. Change 401476 abandoned by Hashar: Jenkins job validation (DO NOT SUBMIT) https://gerrit.wikimedia.org/r/401476TASK DETAILhttps://phabricator.wikimedia.org/T183831EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, hashar, Jonas, Cpaulf30, Gq86, Baloch007, Darkminds3113, Lordiis, Lucas_Werkmeister_WMDE, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, EBjune, merbst, Lewizho99, Maathavan, Xmlizer, thcipriani, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Jay8g, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183831: wikidata/query/gui CI job lacks PhantomJS / proper browsers
gerritbot added a comment. Change 401476 had a related patch set uploaded (by Hashar; owner: Hashar): [wikidata/query/gui@master] Jenkins job validation (DO NOT SUBMIT) https://gerrit.wikimedia.org/r/401476TASK DETAILhttps://phabricator.wikimedia.org/T183831EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, hashar, Jonas, Cpaulf30, Gq86, Baloch007, Darkminds3113, Lordiis, Lucas_Werkmeister_WMDE, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, EBjune, merbst, Lewizho99, Maathavan, Xmlizer, thcipriani, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Jay8g, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183831: wikidata/query/gui CI job lacks PhantomJS / proper browsers
gerritbot added a comment. Change 401475 merged by jenkins-bot: [integration/config@master] Point wikidata/query/gui to a npm browser job https://gerrit.wikimedia.org/r/401475TASK DETAILhttps://phabricator.wikimedia.org/T183831EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, hashar, Jonas, Cpaulf30, Gq86, Baloch007, Darkminds3113, Lordiis, Lucas_Werkmeister_WMDE, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, EBjune, merbst, Lewizho99, Maathavan, Xmlizer, thcipriani, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Jay8g, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183831: wikidata/query/gui CI job lacks PhantomJS / proper browsers
gerritbot added a comment. Change 401475 had a related patch set uploaded (by Hashar; owner: Hashar): [integration/config@master] Point wikidata/query/gui to a npm browser job https://gerrit.wikimedia.org/r/401475TASK DETAILhttps://phabricator.wikimedia.org/T183831EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, hashar, Jonas, Gq86, Lucas_Werkmeister_WMDE, EBjune, merbst, Xmlizer, thcipriani, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Jay8g, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
