[Wikidata-bugs] [Maniphest] [Commented On] T188381: Avoid joining three tables just to get the latest revision ID
gerritbot added a comment. Change 416997 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Handle redirects correctly in loadLatestRevisionIds https://gerrit.wikimedia.org/r/416997TASK DETAILhttps://phabricator.wikimedia.org/T188381EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, daniel, Lucas_Werkmeister_WMDE, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, ArielGlenn, He7d3r, Mbch331, Jay8g, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T188381: Avoid joining three tables just to get the latest revision ID
gerritbot added a comment. Change 416410 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Rearrange PrefetchingWPEMDA::loadLatestRevisionIds https://gerrit.wikimedia.org/r/416410TASK DETAILhttps://phabricator.wikimedia.org/T188381EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, daniel, Lucas_Werkmeister_WMDE, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, ArielGlenn, He7d3r, Mbch331, Jay8g, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T188381: Avoid joining three tables just to get the latest revision ID
gerritbot added a comment. Change 415901 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Optimize PrefetchingWPEMDA::loadLatestRevisionIds https://gerrit.wikimedia.org/r/415901TASK DETAILhttps://phabricator.wikimedia.org/T188381EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, daniel, Lucas_Werkmeister_WMDE, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, ArielGlenn, He7d3r, Mbch331, Jay8g, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T188381: Avoid joining three tables just to get the latest revision ID
gerritbot added a comment. Change 416997 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Handle redirects correctly in loadLatestRevisionIds https://gerrit.wikimedia.org/r/416997TASK DETAILhttps://phabricator.wikimedia.org/T188381EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, daniel, Lucas_Werkmeister_WMDE, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, ArielGlenn, He7d3r, Mbch331, Jay8g, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T188381: Avoid joining three tables just to get the latest revision ID
gerritbot added a comment. Change 415865 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Use WikiPageEntityMetaDataAcessor::loadLatestRevisionIds https://gerrit.wikimedia.org/r/415865TASK DETAILhttps://phabricator.wikimedia.org/T188381EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, daniel, Lucas_Werkmeister_WMDE, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, ArielGlenn, He7d3r, Mbch331, Jay8g, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T188381: Avoid joining three tables just to get the latest revision ID
gerritbot added a comment. Change 415278 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Optimize WikiPageEntityMetaDataLookup::loadLatestRevisionIds https://gerrit.wikimedia.org/r/415278TASK DETAILhttps://phabricator.wikimedia.org/T188381EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, daniel, Lucas_Werkmeister_WMDE, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, ArielGlenn, He7d3r, Mbch331, Jay8g, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T188381: Avoid joining three tables just to get the latest revision ID
gerritbot added a comment. Change 416410 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)): [mediawiki/extensions/Wikibase@master] Rearrange PrefetchingWPEMDA::loadLatestRevisionIds https://gerrit.wikimedia.org/r/416410TASK DETAILhttps://phabricator.wikimedia.org/T188381EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, daniel, Lucas_Werkmeister_WMDE, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, ArielGlenn, He7d3r, Mbch331, Jay8g, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T188381: Avoid joining three tables just to get the latest revision ID
Lucas_Werkmeister_WMDE added a comment.
I just saw this in WikiPageEntityRevisionLookup:
public function getLatestRevisionId( EntityId $entityId, $mode = self::LATEST_FROM_REPLICA ) {
$rows = $this->entityMetaDataAccessor->loadRevisionInformation( [ $entityId ], $mode );
$row = $rows[$entityId->getSerialization()];
if ( $row && $row->page_latest && !$row->page_is_redirect ) {
return (int)$row->page_latest;
}
return false;
}
Note that it’s only using page_latest if the page is not a redirect. We’re not currently doing that in loadLatestRevisionIds… is that a problem?TASK DETAILhttps://phabricator.wikimedia.org/T188381EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, daniel, Lucas_Werkmeister_WMDE, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, ArielGlenn, He7d3r, Mbch331, Jay8g, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T188381: Avoid joining three tables just to get the latest revision ID
gerritbot added a comment. Change 415901 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] WIP: Optimize PrefetchingWPEMDA::loadLatestRevisionIds https://gerrit.wikimedia.org/r/415901TASK DETAILhttps://phabricator.wikimedia.org/T188381EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, daniel, Lucas_Werkmeister_WMDE, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, ArielGlenn, He7d3r, Mbch331, Jay8g, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T188381: Avoid joining three tables just to get the latest revision ID
gerritbot added a comment. Change 415865 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Use WikiPageEntityMetaDataAcessor::loadLatestRevisionIds https://gerrit.wikimedia.org/r/415865TASK DETAILhttps://phabricator.wikimedia.org/T188381EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, daniel, Lucas_Werkmeister_WMDE, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, ArielGlenn, He7d3r, Mbch331, Jay8g, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T188381: Avoid joining three tables just to get the latest revision ID
gerritbot added a comment. Change 415277 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Extract two utility functions https://gerrit.wikimedia.org/r/415277TASK DETAILhttps://phabricator.wikimedia.org/T188381EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, daniel, Lucas_Werkmeister_WMDE, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, ArielGlenn, He7d3r, Mbch331, Jay8g, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T188381: Avoid joining three tables just to get the latest revision ID
gerritbot added a comment. Change 415258 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Add WikiPageEntityMetaDataAccessor::loadLatestRevisionIds https://gerrit.wikimedia.org/r/415258TASK DETAILhttps://phabricator.wikimedia.org/T188381EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, daniel, Lucas_Werkmeister_WMDE, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, ArielGlenn, He7d3r, Mbch331, Jay8g, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T188381: Avoid joining three tables just to get the latest revision ID
gerritbot added a comment. Change 415278 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Optimize WikiPageEntityMetaDataLookup::loadPageLatest https://gerrit.wikimedia.org/r/415278TASK DETAILhttps://phabricator.wikimedia.org/T188381EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, daniel, Lucas_Werkmeister_WMDE, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, ArielGlenn, He7d3r, Mbch331, Jay8g, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T188381: Avoid joining three tables just to get the latest revision ID
gerritbot added a comment. Change 415277 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Extract two utility functions https://gerrit.wikimedia.org/r/415277TASK DETAILhttps://phabricator.wikimedia.org/T188381EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, daniel, Lucas_Werkmeister_WMDE, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, ArielGlenn, He7d3r, Mbch331, Jay8g, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T188381: Avoid joining three tables just to get the latest revision ID
gerritbot added a comment. Change 415258 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Add WikiPageEntityMetaDataAccessor::loadPageLatest https://gerrit.wikimedia.org/r/415258TASK DETAILhttps://phabricator.wikimedia.org/T188381EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, daniel, Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, ArielGlenn, He7d3r, Mbch331, Jay8g, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
