[Wikidata-bugs] [Maniphest] [Commented On] T196290: See summary of edit including Senses
gerritbot added a comment. Change 449507 abandoned by Lucas Werkmeister (WMDE): Ignore auto-summary key if equal to language code https://gerrit.wikimedia.org/r/449507 TASK DETAIL https://phabricator.wikimedia.org/T196290 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo, gerritbot Cc: Lucas_Werkmeister_WMDE, hoo, gerritbot, Lydia_Pintscher, WMDE-leszek, RazShuty, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T196290: See summary of edit including Senses
gerritbot added a comment. Change 451651 abandoned by Hoo man: Change edit summary for Gloss changes Reason: duplicate https://gerrit.wikimedia.org/r/451651TASK DETAILhttps://phabricator.wikimedia.org/T196290EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, gerritbotCc: Lucas_Werkmeister_WMDE, hoo, gerritbot, Lydia_Pintscher, WMDE-leszek, RazShuty, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T196290: See summary of edit including Senses
gerritbot added a comment. Change 451270 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Update i18n message for changing glosses https://gerrit.wikimedia.org/r/451270TASK DETAILhttps://phabricator.wikimedia.org/T196290EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, gerritbotCc: Lucas_Werkmeister_WMDE, hoo, gerritbot, Lydia_Pintscher, WMDE-leszek, RazShuty, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T196290: See summary of edit including Senses
gerritbot added a comment. Change 451270 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseLexeme@master] Update i18n message for changing glosses https://gerrit.wikimedia.org/r/451270TASK DETAILhttps://phabricator.wikimedia.org/T196290EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, gerritbotCc: Lucas_Werkmeister_WMDE, hoo, gerritbot, Lydia_Pintscher, WMDE-leszek, RazShuty, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T196290: See summary of edit including Senses
hoo added a comment. Ok, so I just looked into this again and removing the redundant languages after the summary is not easily possible. These are needed as it's possible to add/remove/change several glosses at once and still be able to denote their respective languages. If we want a nicer solution for that, this should probably be a separate tasks. The same limitations apply to form representation edit summaries, btw.TASK DETAILhttps://phabricator.wikimedia.org/T196290EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: Lucas_Werkmeister_WMDE, hoo, gerritbot, Lydia_Pintscher, WMDE-leszek, RazShuty, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T196290: See summary of edit including Senses
gerritbot added a comment. Change 451651 had a related patch set uploaded (by Hoo man; owner: Hoo man): [mediawiki/extensions/WikibaseLexeme@master] Change edit summary for Gloss changes https://gerrit.wikimedia.org/r/451651TASK DETAILhttps://phabricator.wikimedia.org/T196290EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: hoo, gerritbot, Lydia_Pintscher, WMDE-leszek, RazShuty, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T196290: See summary of edit including Senses
hoo added a comment. Hm, the message key for this is wikibase-lexeme-summary-set-sense-glosses (which is in line with wikibase-lexeme-summary-set-form-representations for form representations). Form representation change edit summaries currently render as: Changed representation of Form L1-F1: de-at: foo. We can easily change the message content… but I'm wondering whether we should also change the message key (which is still possible given that this is not in production yet… but this would make this inconsistent with form representations).TASK DETAILhttps://phabricator.wikimedia.org/T196290EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, hooCc: hoo, gerritbot, Lydia_Pintscher, WMDE-leszek, RazShuty, Chief_Mike, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T196290: See summary of edit including Senses
Lydia_Pintscher added a comment. The edit summary for changing a Gloss is still wrong. It says "Set [de] gloss of Sense L1-S1: de: foo" instead of "Changed [de] gloss of Sense L1-S1: de: foo". Rest looks good.TASK DETAILhttps://phabricator.wikimedia.org/T196290EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, Lydia_PintscherCc: gerritbot, Lydia_Pintscher, WMDE-leszek, RazShuty, Chief_Mike, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T196290: See summary of edit including Senses
gerritbot added a comment. Change 449507 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Ignore auto-summary key if equal to language code https://gerrit.wikimedia.org/r/449507TASK DETAILhttps://phabricator.wikimedia.org/T196290EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, Lydia_Pintscher, WMDE-leszek, RazShuty, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T196290: See summary of edit including Senses
Lucas_Werkmeister_WMDE added a comment. Note that the language code is also included in the “auto summary” part of the message, for forms as well. For example: Added representation of Form L123-F3: en: sandbox I suppose when the language code is included in the “auto comment” part, we should get rid of that?TASK DETAILhttps://phabricator.wikimedia.org/T196290EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lydia_Pintscher, WMDE-leszek, RazShuty, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T196290: See summary of edit including Senses
Lydia_Pintscher added a comment. Ok then go with [en] etc and we'll do a proper cleanup for all these messages in a different ticket.TASK DETAILhttps://phabricator.wikimedia.org/T196290EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, Lydia_PintscherCc: Lydia_Pintscher, WMDE-leszek, RazShuty, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T196290: See summary of edit including Senses
Lucas_Werkmeister_WMDE added a comment. I think it’s just inconsistently applied, yes. wikibase-entity-summary-wbsetlabel-set is overridden, -add and -remove aren’t.TASK DETAILhttps://phabricator.wikimedia.org/T196290EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lydia_Pintscher, WMDE-leszek, RazShuty, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T196290: See summary of edit including Senses
Lydia_Pintscher added a comment. Here are three edits with inconsistent language handling in the edit summary: https://www.wikidata.org/w/index.php?title=Q4115189&diff=718855785&oldid=718625723 https://www.wikidata.org/w/index.php?title=Q18609189&curid=20141134&diff=718854115&oldid=435807537 https://www.wikidata.org/w/index.php?title=Q55847926&diff=718853878&oldid=718853685 Is this just because the local hack is inconsistently applied? Or is there more to it? Either way this local hack sounds bad. We should do this properly on our side if there is nothing keeping us from doing it.TASK DETAILhttps://phabricator.wikimedia.org/T196290EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, Lydia_PintscherCc: Lydia_Pintscher, WMDE-leszek, RazShuty, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T196290: See summary of edit including Senses
Lucas_Werkmeister_WMDE added a comment.
Okay, so the way that “added French label” works on Wikidata is that the message wikibase-entity-summary-wbsetlabel-set is locally overridden there, with the following content:
Changed {{#language:$2|{{int:Lang label
{{#language:}} is a parser function which will render the language code $2 (the part that the original message has in brackets) as a language name in the language {{int:Lang}}. {{int:}} is a parser function that renders the message Lang in the current user language. And finally, Lang is a synthetic interface message in the MediaWiki namespace that has been overridden to return the current language code in each language (e. g. fr, de, be-x-old). Therefore, the message is transformed {{#language:fr|{{int:Lang → {{#language:fr|en}} → “French”.
The {{#language:}} parser function requires the CLDR extension for the list of language names in other languages, otherwise it falls back to displaying the language’s autonym (e. g. «français»), which MediaWiki knows out of the box.
Presumably, the same hack could be made to work on Wikidata for Sense summaries as well, as long as we provide language codes where possible (when only one gloss is affected). But if I’m not mistaken, to make this work out-of-the-box without on-wiki hacks would require a) that we declare a dependency on CLDR (unless we judge that autonyms are no less user friendly than plain language codes?), and b) a parser function to get the current user language (and I assume there are very good reasons why this doesn’t already exist, probably related to cache headaches).
@Lydia_Pintscher: what do you make of this? Is it okay if we produce [en] instead of “English” in the summaries for now, leaving it to the Wikidata community to implement the same hack for Sense messages as well, with the option that perhaps in the future, we’ll clean this up properly, not just for Senses but also for ordinary Wikibase messages?TASK DETAILhttps://phabricator.wikimedia.org/T196290EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lydia_Pintscher, WMDE-leszek, RazShuty, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
