[Wikidata-bugs] [Maniphest] [Commented On] T197089: Inject shared lexeme store into the vue components that need to access it
Lydia_Pintscher added a comment. Thanks! That is the page preview feature and isn't live on Wikidata. We have another ticket to fix that.TASK DETAILhttps://phabricator.wikimedia.org/T197089EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Greta_Doci_WMDE, Lydia_Pintscher, RazShuty, gerritbot, Pablo-WMDE, Jakob_WMDE, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T197089: Inject shared lexeme store into the vue components that need to access it
Greta_Doci_WMDE added a comment. The only problem that I could notice till now is when you mouseover anywhere in the page but properties, this pop up is shown. If you click "go to this page" it will only reload the page. F23352210: mouse_hover.jpgTASK DETAILhttps://phabricator.wikimedia.org/T197089EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Greta_Doci_WMDECc: Greta_Doci_WMDE, Lydia_Pintscher, RazShuty, gerritbot, Pablo-WMDE, Jakob_WMDE, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T197089: Inject shared lexeme store into the vue components that need to access it
Greta_Doci_WMDE added a comment. Sure, i'll do the edits here https://wikidata.beta.wmflabs.org and let you knowTASK DETAILhttps://phabricator.wikimedia.org/T197089EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Greta_Doci_WMDECc: Greta_Doci_WMDE, Lydia_Pintscher, RazShuty, gerritbot, Pablo-WMDE, Jakob_WMDE, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T197089: Inject shared lexeme store into the vue components that need to access it
gerritbot added a comment. Change 443637 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] lexemeformview: enforce properly injected value https://gerrit.wikimedia.org/r/443637TASK DETAILhttps://phabricator.wikimedia.org/T197089EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Pablo-WMDE, Jakob_WMDE, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T197089: Inject shared lexeme store into the vue components that need to access it
gerritbot added a comment. Change 443637 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)): [mediawiki/extensions/WikibaseLexeme@master] lexemeformview: enforce properly injected value https://gerrit.wikimedia.org/r/443637TASK DETAILhttps://phabricator.wikimedia.org/T197089EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Pablo-WMDE, Jakob_WMDE, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T197089: Inject shared lexeme store into the vue components that need to access it
gerritbot added a comment. Change 441878 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] RepresentationWidget: vuex as data store https://gerrit.wikimedia.org/r/441878TASK DETAILhttps://phabricator.wikimedia.org/T197089EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Pablo-WMDE, Jakob_WMDE, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T197089: Inject shared lexeme store into the vue components that need to access it
Pablo-WMDE added a comment. Further reading https://vuex.vuejs.org/guide/forms.html https://stackoverflow.com/a/46044953 # v-model vs vuex store https://itnext.io/anyway-this-is-how-to-use-v-model-with-vuex-computed-setter-in-action-320eb682c976 https://ypereirareis.github.io/blog/2017/04/25/vuejs-two-way-data-binding-state-management-vuex-strict-mode/ https://markus.oberlehner.net/blog/form-fields-two-way-data-binding-and-vuex/ https://markus.oberlehner.net/blog/how-to-handle-multi-row-forms-with-vue-vuex-and-vuex-map-fields/ https://vuex.vuejs.org/guide/mutations.html#committing-mutations-in-components https://vuejs.org/v2/guide/list.html#Caveats https://vuex.vuejs.org/guide/testing.html TASK DETAILhttps://phabricator.wikimedia.org/T197089EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: gerritbot, Pablo-WMDE, Jakob_WMDE, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T197089: Inject shared lexeme store into the vue components that need to access it
gerritbot added a comment. Change 441878 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)): [mediawiki/extensions/WikibaseLexeme@master] WIP RepresentationWidget: vuex as data store https://gerrit.wikimedia.org/r/441878TASK DETAILhttps://phabricator.wikimedia.org/T197089EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDE, gerritbotCc: gerritbot, Pablo-WMDE, Jakob_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T197089: Inject shared lexeme store into the vue components that need to access it
Pablo-WMDE added a comment. Finding: https://vuex.vuejs.org/guide/state.html#getting-vuex-state-into-vue-componentsTASK DETAILhttps://phabricator.wikimedia.org/T197089EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: Pablo-WMDE, Jakob_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
