[Wikidata-bugs] [Maniphest] [Commented On] T198203: Check gloss language codes in UI
gerritbot added a comment. Change 459796 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Add InvalidLanguageIndicator and use it in glosses https://gerrit.wikimedia.org/r/459796TASK DETAILhttps://phabricator.wikimedia.org/T198203EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: Addshore, gerritbot, Lucas_Werkmeister_WMDE, Ladsgroup, WMDE-leszek, Lydia_Pintscher, RazShuty, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T198203: Check gloss language codes in UI
gerritbot added a comment. Change 459796 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani): [mediawiki/extensions/WikibaseLexeme@master] [WIP] Start InvalidLanguageIndicator and use it in glosses https://gerrit.wikimedia.org/r/459796TASK DETAILhttps://phabricator.wikimedia.org/T198203EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Ladsgroup, WMDE-leszek, Lydia_Pintscher, RazShuty, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T198203: Check gloss language codes in UI
Ladsgroup added a comment. This is a basic POC: F25770172: image.pngTASK DETAILhttps://phabricator.wikimedia.org/T198203EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Lucas_Werkmeister_WMDE, Ladsgroup, WMDE-leszek, Lydia_Pintscher, RazShuty, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T198203: Check gloss language codes in UI
Lucas_Werkmeister_WMDE added a comment. Well, we don’t really need there to be a form, that just means we’ll have to do manual work to disable the “save” button.TASK DETAILhttps://phabricator.wikimedia.org/T198203EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Ladsgroup, WMDE-leszek, Lydia_Pintscher, RazShuty, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T198203: Check gloss language codes in UI
Lucas_Werkmeister_WMDE added a comment. Of course, that assumes that we use a proper form for editing glosses… do we? Of course we don’t, what was I thinking.TASK DETAILhttps://phabricator.wikimedia.org/T198203EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Ladsgroup, WMDE-leszek, Lydia_Pintscher, RazShuty, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T198203: Check gloss language codes in UI
Lucas_Werkmeister_WMDE added a comment. I think we can use the HTML5 constraint validation API for this – the only MediaWiki Grade A browsers that don’t support it according to caniuse.com are Chrome 13-14 (supported since Chrome 15) and Safari 5 (supported since Safari 5.1). (Some features are missing in a few more browser versions, but we should only need a baseline: setCustomValidity( 'unknown language code' ) and the :valid/:invalid selectors.) Of course, that assumes that we use a proper form for editing glosses… do we?TASK DETAILhttps://phabricator.wikimedia.org/T198203EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Ladsgroup, WMDE-leszek, Lydia_Pintscher, RazShuty, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T198203: Check gloss language codes in UI
WMDE-leszek added a comment. @Lydia_Pintscher please define what error message should say, and how it should look likeTASK DETAILhttps://phabricator.wikimedia.org/T198203EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: WMDE-leszek, Lydia_Pintscher, RazShuty, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs