[Wikidata-bugs] [Maniphest] [Commented On] T198701: Create RevisionStoreFactory [MCR]

2018-08-02 Thread gerritbot
gerritbot added a comment.
Change 443985 merged by jenkins-bot:
[mediawiki/core@master] Introduce RevisionStoreFactory & Tests

https://gerrit.wikimedia.org/r/443985TASK DETAILhttps://phabricator.wikimedia.org/T198701EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, gerritbotCc: Jdforrester-WMF, Anomie, gerritbot, Aklapper, daniel, Addshore, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T198701: Create RevisionStoreFactory [MCR]

2018-07-05 Thread Anomie
Anomie added a comment.

In T198701#4399880, @daniel wrote:
Perhaps we could use SiteConfiguration to gain access to the various migration stages on the different wikis: If a SiteConfiguration is injected, the local values of the migrations tage for MCR, CommentStore and Actor are overwritten by the value for the target wiki retrieved from SiteConfiguration.


The method you'd use to do that is SiteConfiguration::getConfig(). Note its documentation: "For foreign wikis, this is expensive, and only works if maintenance scripts are setup to handle the --wiki parameter such as in wiki farms."

While you could in theory get most of the way there by passing the correct $wiki, $suffix, $params, and $wikiTags to SiteConfiguration::get(), determining the correct values for those variables for an arbitrary other wiki is non-trivial. On WMF sites, you'd basically need to duplicate lines 176 and 199-227 of CommonSettings.php and you'd still be out of luck if that wiki uses the value from DefaultSettings.php.TASK DETAILhttps://phabricator.wikimedia.org/T198701EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, AnomieCc: Anomie, gerritbot, Aklapper, daniel, Addshore, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T198701: Create RevisionStoreFactory [MCR]

2018-07-05 Thread gerritbot
gerritbot added a comment.
Change 443985 had a related patch set uploaded (by Daniel Kinzler; owner: Addshore):
[mediawiki/core@master] Introduce RevisionStoreFactory & Tests

https://gerrit.wikimedia.org/r/443985TASK DETAILhttps://phabricator.wikimedia.org/T198701EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, daniel, Addshore, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, JJMC89, Agabi10, Wikidata-bugs, aude, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs