[Wikidata-bugs] [Maniphest] [Commented On] T200340: Wikibase\DataModel\Entity\EntityIdParsingException $serialization must not be an empty string
gerritbot added a comment. Change 448022 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Make wikibase-entityid catch EntityIdParsingExceptions https://gerrit.wikimedia.org/r/448022TASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: Pablo-WMDE, Addshore, Ladsgroup, gerritbot, Krinkle, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T200340: Wikibase\DataModel\Entity\EntityIdParsingException $serialization must not be an empty string
gerritbot added a comment. Change 448022 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/Wikibase@master] Make wikibase-entityid catch EntityIdParsingExceptions https://gerrit.wikimedia.org/r/448022TASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: Pablo-WMDE, Addshore, Ladsgroup, gerritbot, Krinkle, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T200340: Wikibase\DataModel\Entity\EntityIdParsingException $serialization must not be an empty string
gerritbot added a comment. Change 447840 abandoned by Addshore: Catch EntityIdParsingException in SetClaim https://gerrit.wikimedia.org/r/447840TASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: Pablo-WMDE, Addshore, Ladsgroup, gerritbot, Krinkle, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T200340: Wikibase\DataModel\Entity\EntityIdParsingException $serialization must not be an empty string
Addshore added a comment. DataValueDeserializer::__construct docs should be updated to say what types of exceptions the builders can throw. A better fix (than the current gerrit patch) might actually be to catch the EntityIdParsingException in the closure in WikibaseRepo and return another InvalidArgumentException from there, this would be consistent with the other builders. This would then be re caught in DataValueDeserializer::getDeserialization and rethrown as a DeserializationException which would be handled by SetClaim..TASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Pablo-WMDE, Addshore, Ladsgroup, gerritbot, Krinkle, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T200340: Wikibase\DataModel\Entity\EntityIdParsingException $serialization must not be an empty string
Addshore added a comment. Reproduction on test wikidata wiki: https://test.wikidata.org/wiki/Special:ApiSandbox#action="">TASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Pablo-WMDE, Addshore, Ladsgroup, gerritbot, Krinkle, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T200340: Wikibase\DataModel\Entity\EntityIdParsingException $serialization must not be an empty string
gerritbot added a comment. Change 447840 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/Wikibase@master] Catch EntityIdParsingException in SetClaim https://gerrit.wikimedia.org/r/447840TASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: Pablo-WMDE, Addshore, Ladsgroup, gerritbot, Krinkle, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T200340: Wikibase\DataModel\Entity\EntityIdParsingException $serialization must not be an empty string
Addshore added a comment. The issue is caused when the closure for 'wikibase-entityid' is called as provided by WikibasRepo::getDataValueDeserializer This is called by DataValueDeserializer::getDeserialization which catches InvalidArgumentException but not EntityIdParsingExceptions which is actually what needs to be caught. The InvalidArgumentException is caught and the EntityIdParsingException is then thrown from DispatchingEntityIdParser::parseTASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Pablo-WMDE, Addshore, Ladsgroup, gerritbot, Krinkle, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T200340: Wikibase\DataModel\Entity\EntityIdParsingException $serialization must not be an empty string
Pablo-WMDE added a comment. @Addshore Given that the API end point did not change and the parser threw the exceptions all along it's probably valid to assume it's just the requests that changed - does that warrant this ticket to be downgraded?TASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: Pablo-WMDE, Addshore, Ladsgroup, gerritbot, Krinkle, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T200340: Wikibase\DataModel\Entity\EntityIdParsingException $serialization must not be an empty string
Addshore added a comment. The SetClaim API module should catch the exception and report a nice error message instead of spamming the exception logs and sending the exception to the client..TASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Ladsgroup, gerritbot, Krinkle, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T200340: Wikibase\DataModel\Entity\EntityIdParsingException $serialization must not be an empty string
Addshore added a comment.
I looked at one of the stacktraces and it looks like this is coming from the API, so it could just be a client providing bad data:
#0 /srv/mediawiki/php-1.32.0-wmf.13/extensions/Wikibase/repo/includes/WikibaseRepo.php(1459): Wikibase\DataModel\Entity\DispatchingEntityIdParser->parse(string)
#1 /srv/mediawiki/php-1.32.0-wmf.13/vendor/data-values/serialization/src/Deserializers/DataValueDeserializer.php(122): Closure$Wikibase\Repo\WikibaseRepo::getDataValueDeserializer(array)
#2 /srv/mediawiki/php-1.32.0-wmf.13/vendor/data-values/serialization/src/Deserializers/DataValueDeserializer.php(91): DataValues\Deserializers\DataValueDeserializer->getDeserialization(array)
#3 /srv/mediawiki/php-1.32.0-wmf.13/vendor/wikibase/data-model-serialization/src/Deserializers/SnakDeserializer.php(118): DataValues\Deserializers\DataValueDeserializer->deserialize(array)
#4 /srv/mediawiki/php-1.32.0-wmf.13/vendor/wikibase/data-model-serialization/src/Deserializers/SnakDeserializer.php(108): Wikibase\DataModel\Deserializers\SnakDeserializer->deserializeDataValue(array)
#5 /srv/mediawiki/php-1.32.0-wmf.13/vendor/wikibase/data-model-serialization/src/Deserializers/SnakDeserializer.php(90): Wikibase\DataModel\Deserializers\SnakDeserializer->newValueSnak(array)
#6 /srv/mediawiki/php-1.32.0-wmf.13/vendor/wikibase/data-model-serialization/src/Deserializers/SnakDeserializer.php(72): Wikibase\DataModel\Deserializers\SnakDeserializer->getDeserialized(array)
#7 /srv/mediawiki/php-1.32.0-wmf.13/vendor/wikibase/data-model-serialization/src/Deserializers/StatementDeserializer.php(110): Wikibase\DataModel\Deserializers\SnakDeserializer->deserialize(array)
#8 /srv/mediawiki/php-1.32.0-wmf.13/vendor/wikibase/data-model-serialization/src/Deserializers/StatementDeserializer.php(100): Wikibase\DataModel\Deserializers\StatementDeserializer->getDeserialized(array)
#9 /srv/mediawiki/php-1.32.0-wmf.13/extensions/Wikibase/repo/includes/Api/SetClaim.php(191): Wikibase\DataModel\Deserializers\StatementDeserializer->deserialize(array)
#10 /srv/mediawiki/php-1.32.0-wmf.13/extensions/Wikibase/repo/includes/Api/SetClaim.php(109): Wikibase\Repo\Api\SetClaim->getStatementFromParams(array)
#11 /srv/mediawiki/php-1.32.0-wmf.13/includes/api/ApiMain.php(1582): Wikibase\Repo\Api\SetClaim->execute()
#12 /srv/mediawiki/php-1.32.0-wmf.13/includes/api/ApiMain.php(535): ApiMain->executeAction()
#13 /srv/mediawiki/php-1.32.0-wmf.13/includes/api/ApiMain.php(506): ApiMain->executeActionWithErrorHandling()
#14 /srv/mediawiki/php-1.32.0-wmf.13/api.php(83): ApiMain->execute()
#15 /srv/mediawiki/w/api.php(3): include(string)
#16 {main}TASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Ladsgroup, gerritbot, Krinkle, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T200340: Wikibase\DataModel\Entity\EntityIdParsingException $serialization must not be an empty string
zeljkofilipin added a comment. In T200340#4450574, @Ladsgroup wrote: It's probably a new version that got released but not updated in the vendor I think. Is there a way to quickly fix this? Or is there a workaround? I need an estimate on when this could be resolved, since it's blocking the train, and we are already behind because of problems with .13. TASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: Ladsgroup, gerritbot, Krinkle, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T200340: Wikibase\DataModel\Entity\EntityIdParsingException $serialization must not be an empty string
zeljkofilipin added a comment.
I have rolled back group 1 from .14 to .13, but now I see the same error for .13
[{exception_id}] {exception_url} Wikibase\DataModel\Entity\EntityIdParsingException from line 49 of /srv/mediawiki/php-1.32.0-wmf.13/vendor/wikibase/data-model/src/Entity/DispatchingEntityIdParser.php: $serialization must not be an empty stringTASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: Ladsgroup, gerritbot, Krinkle, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T200340: Wikibase\DataModel\Entity\EntityIdParsingException $serialization must not be an empty string
Ladsgroup added a comment. It's probably a new version that got released but not updated in the vendor I think.TASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Ladsgroup, gerritbot, Krinkle, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T200340: Wikibase\DataModel\Entity\EntityIdParsingException $serialization must not be an empty string
gerritbot added a comment. Change 447815 merged by jenkins-bot: [operations/mediawiki-config@master] Revert "group1 wikis to 1.32.0-wmf.14" https://gerrit.wikimedia.org/r/447815TASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Ladsgroup, gerritbot, Krinkle, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T200340: Wikibase\DataModel\Entity\EntityIdParsingException $serialization must not be an empty string
gerritbot added a comment. Change 447815 had a related patch set uploaded (by Zfilipin; owner: Zfilipin): [operations/mediawiki-config@master] Revert "group1 wikis to 1.32.0-wmf.14" https://gerrit.wikimedia.org/r/447815TASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Krinkle, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
