[Wikidata-bugs] [Maniphest] [Commented On] T215287: Return nice error messages from Score extension when Lilypond formatting fails

2019-02-22 Thread gerritbot 
gerritbot added a comment.


  Change 491261 **merged** by jenkins-bot:
  [mediawiki/extensions/Score@master] beautify lilypond error message output
  
  https://gerrit.wikimedia.org/r/491261

TASK DETAIL
  https://phabricator.wikimedia.org/T215287

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde, gerritbot
Cc: gerritbot, Greta_Doci_WMDE, Tacsipacsi, Aklapper, Addshore, 
Lydia_Pintscher, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, Mahir256, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, mb, Jonas, Wikidata-bugs, aude, Ebe123, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T215287: Return nice error messages from Score extension when Lilypond formatting fails

2019-02-18 Thread gerritbot 
gerritbot added a comment.
Change 491261 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan):
[mediawiki/extensions/Score@master] beautify lilypond error message output

https://gerrit.wikimedia.org/r/491261TASK DETAILhttps://phabricator.wikimedia.org/T215287EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: alaa_wmde, gerritbotCc: gerritbot, Greta_Doci_WMDE, Tacsipacsi, Aklapper, Addshore, Lydia_Pintscher, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, mb, Jonas, Wikidata-bugs, aude, Ebe123, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T215287: Return nice error messages from Score extension when Lilypond formatting fails

2019-02-18 Thread alaa_wmde 
alaa_wmde added a comment.
I came up with this so far.. it looks nicer and more concise (the code is the opposite  but will try to improve some stuff)
F28240197: image.pngTASK DETAILhttps://phabricator.wikimedia.org/T215287EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: alaa_wmdeCc: Greta_Doci_WMDE, Tacsipacsi, Aklapper, Addshore, Lydia_Pintscher, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, mb, Jonas, Wikidata-bugs, aude, Ebe123, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T215287: Return nice error messages from Score extension when Lilypond formatting fails

2019-02-06 Thread Tacsipacsi 
Tacsipacsi added a comment.
The current error message is not user-friendly indeed, but dropping the line

.../file.ly:12:9: error: unrecognized string, not in text script or \lyricmode
	
safkjsanfkjsfjsafsaf

would make finding the error a lot harder, so this should be preserved somehow (the best would be to convert the line/column numbers so that they correspond to the position of the error in the wikitext).TASK DETAILhttps://phabricator.wikimedia.org/T215287EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TacsipacsiCc: Tacsipacsi, Aklapper, Addshore, Lydia_Pintscher, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, mb, Jonas, Wikidata-bugs, aude, Ebe123, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs