[Wikidata-bugs] [Maniphest] [Commented On] T216241: Make "make primary" work in read mode

2019-02-21 Thread gerritbot 
gerritbot added a comment.


  Change 491298 **merged** by jenkins-bot:
  [mediawiki/extensions/WikibaseMediaInfo@master] Toggle edit mode on primary, 
and make state changes impossible during submit
  
  https://gerrit.wikimedia.org/r/491298

TASK DETAIL
  https://phabricator.wikimedia.org/T216241

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie, gerritbot
Cc: MarkTraceur, PDrouin-WMF, Cparle, Aklapper, Ramsey-WMF, Jdforrester-WMF, 
gerritbot, Abit, matthiasmullie, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, V4switch, LawExplorer, Lewizho99, 
Maathavan, _jensen, Wong128hk, Wikidata-bugs, aude, Fabrice_Florin, Matanya, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T216241: Make "make primary" work in read mode

2019-02-19 Thread MarkTraceur 
MarkTraceur added a comment.
@matthiasmullie this task is in the to-do column, but has a patch-for-review tag. Should we move it to "doing"?TASK DETAILhttps://phabricator.wikimedia.org/T216241EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matthiasmullie, MarkTraceurCc: MarkTraceur, PDrouin-WMF, Cparle, Aklapper, Ramsey-WMF, Jdforrester-WMF, gerritbot, Abit, matthiasmullie, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, V4switch, LawExplorer, Lewizho99, Maathavan, _jensen, Wong128hk, Wikidata-bugs, aude, Fabrice_Florin, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T216241: Make "make primary" work in read mode

2019-02-18 Thread gerritbot 
gerritbot added a comment.
Change 491298 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Toggle edit mode on primary, and make state changes impossible during submit

https://gerrit.wikimedia.org/r/491298TASK DETAILhttps://phabricator.wikimedia.org/T216241EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matthiasmullie, gerritbotCc: PDrouin-WMF, Cparle, Aklapper, Ramsey-WMF, Jdforrester-WMF, gerritbot, Abit, matthiasmullie, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, V4switch, LawExplorer, _jensen, Wong128hk, Wikidata-bugs, aude, Fabrice_Florin, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T216241: Make "make primary" work in read mode

2019-02-18 Thread PDrouin-WMF 
PDrouin-WMF added a comment.
Yeah, the original concepts allowed for that, but I think your solution
works, Cormac (going into edit mode once the user changes the primary state
and clicking publish or cancel).TASK DETAILhttps://phabricator.wikimedia.org/T216241EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: PDrouin-WMFCc: PDrouin-WMF, Cparle, Aklapper, Ramsey-WMF, Jdforrester-WMF, gerritbot, Abit, matthiasmullie, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, V4switch, LawExplorer, _jensen, Wong128hk, Wikidata-bugs, aude, Fabrice_Florin, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T216241: Make "make primary" work in read mode

2019-02-18 Thread Cparle 
Cparle added a comment.
Hmm ... you sure? Everything else requires the user to press 'publish'. Don't you think it'd be a bit odd for 'make primary' to be different?

To me it'd make most sense for the form to go into 'edit' mode once the user changes the state of one of primary - and then they can click 'publish' or 'cancel'TASK DETAILhttps://phabricator.wikimedia.org/T216241EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CparleCc: PDrouin-WMF, Cparle, Aklapper, Ramsey-WMF, Jdforrester-WMF, gerritbot, Abit, matthiasmullie, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, V4switch, LawExplorer, _jensen, Wong128hk, Wikidata-bugs, aude, Fabrice_Florin, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T216241: Make "make primary" work in read mode

2019-02-15 Thread PDrouin-WMF 
PDrouin-WMF added a comment.
It's less a link and more a button. Users should be able to mark a statement primary in read mode: https://wikimedia.invisionapp.com/d/main/#/console/15638944/324827163/previewTASK DETAILhttps://phabricator.wikimedia.org/T216241EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: PDrouin-WMFCc: PDrouin-WMF, Cparle, Aklapper, Ramsey-WMF, Jdforrester-WMF, gerritbot, Abit, matthiasmullie, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, V4switch, LawExplorer, _jensen, Wong128hk, Wikidata-bugs, aude, Fabrice_Florin, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs