[Wikidata-bugs] [Maniphest] [Commented On] T220696: Create better edit summaries for wbeditentity API endpoint

2019-07-19 Thread gerritbot 
gerritbot added a comment.


  Change 524200 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] ChangeOp::apply() should return 
ChangeOpResult
  
  https://gerrit.wikimedia.org/r/524200

TASK DETAIL
  https://phabricator.wikimedia.org/T220696

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Rosalie_WMDE, alaa_wmde, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Aklapper, 
Lea_WMDE, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Sario528, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T220696: Create better edit summaries for wbeditentity API endpoint

2019-07-18 Thread gerritbot 
gerritbot added a comment.


  Change 524200 had a related patch set uploaded (by Rosalie Perside (WMDE); 
owner: Rosalie Perside (WMDE)):
  [mediawiki/extensions/Wikibase@master] ChangeOp::apply() should return 
ChangeOpResult
  
  https://gerrit.wikimedia.org/r/524200

TASK DETAIL
  https://phabricator.wikimedia.org/T220696

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Rosalie_WMDE, alaa_wmde, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Aklapper, 
Lea_WMDE, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T220696: Create better edit summaries for wbeditentity API endpoint

2019-07-18 Thread gerritbot 
gerritbot added a comment.


  Change 522430 **merged** by jenkins-bot:
  [mediawiki/extensions/WikibaseLexeme@master] ChangeOp::apply() should return 
ChangeOpResult
  
  https://gerrit.wikimedia.org/r/522430

TASK DETAIL
  https://phabricator.wikimedia.org/T220696

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Rosalie_WMDE, alaa_wmde, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Aklapper, 
Lea_WMDE, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T220696: Create better edit summaries for wbeditentity API endpoint

2019-07-17 Thread gerritbot 
gerritbot added a comment.


  Change 522154 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Add ChangeOpResult interface
  
  https://gerrit.wikimedia.org/r/522154

TASK DETAIL
  https://phabricator.wikimedia.org/T220696

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Rosalie_WMDE, alaa_wmde, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Aklapper, 
Lea_WMDE, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T220696: Create better edit summaries for wbeditentity API endpoint

2019-07-12 Thread gerritbot 
gerritbot added a comment.


  Change 522430 had a related patch set uploaded (by Rosalie Perside (WMDE); 
owner: Rosalie Perside (WMDE)):
  [mediawiki/extensions/WikibaseLexeme@master] ChangeOp::apply() should return 
ChangeOpResult
  
  https://gerrit.wikimedia.org/r/522430

TASK DETAIL
  https://phabricator.wikimedia.org/T220696

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Rosalie_WMDE, alaa_wmde, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Aklapper, 
Lea_WMDE, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T220696: Create better edit summaries for wbeditentity API endpoint

2019-07-11 Thread gerritbot 
gerritbot added a comment.


  Change 522154 had a related patch set uploaded (by Rosalie Perside (WMDE); 
owner: Rosalie Perside (WMDE)):
  [mediawiki/extensions/Wikibase@master] [WIP]Add ChangeOpResult interface
  
  https://gerrit.wikimedia.org/r/522154

TASK DETAIL
  https://phabricator.wikimedia.org/T220696

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Rosalie_WMDE, alaa_wmde, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Aklapper, 
Lea_WMDE, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T220696: Create better edit summaries for wbeditentity API endpoint

2019-07-09 Thread gerritbot 
gerritbot added a comment.


  Change 518721 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Add ADR explaning the change to 
ChangeOp design.
  
  https://gerrit.wikimedia.org/r/518721

TASK DETAIL
  https://phabricator.wikimedia.org/T220696

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Rosalie_WMDE, alaa_wmde, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Aklapper, 
Lea_WMDE, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T220696: Create better edit summaries for wbeditentity API endpoint

2019-07-04 Thread Rosalie_WMDE 
Rosalie_WMDE added a comment.


  @alaa_wmde  and I made some changes to the ADR for this task here 
.
  
  A short summary of the change.
  --
  
  - We decided to proceed with the visitor design parttern (Stateless).
  - Extended the discussion dateline (Now, **2019-07-09**).
  - Added Some implementation description to the choice made.

TASK DETAIL
  https://phabricator.wikimedia.org/T220696

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Rosalie_WMDE
Cc: Rosalie_WMDE, alaa_wmde, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Aklapper, 
Lea_WMDE, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T220696: Create better edit summaries for wbeditentity API endpoint

2019-06-26 Thread alaa_wmde 
alaa_wmde added a comment.


  In T220696#5200988 , 
@Lea_WMDE wrote:
  
  > In T220696#5200413 , 
@alaa_wmde wrote:
  >
  > > The actual limits after which we move from one version to another ( 
Expanded -> Shortend -> fallback) is to be checked and detailed during 
implementation.
  >
  >
  > Why is that? Do you think it likely the backend will not be able to handle 
the requests of the acceptance criteria? 
  >  I would not want us to increase the limits. The 5 was chosen, because most 
activities are below that line, and 5 is still a "small enough" number to 
overlook. The 50 might actually be way too  big. 
  >  So please don't increase either of the two numbers, and please stay with 
using number of terms/ languages as deciding factors
  
  
  That was because we weren't sure about the limit as well during estimating 
and taking in this task. We can certainly stay with those numbers if that's 
important. Why is it important to stick to those numbers? I reckon one reason 
might be to keep it consistent between different edits, but can't see it as an 
important factor in here. I can be missing something else of course. Are there 
other reasons?

TASK DETAIL
  https://phabricator.wikimedia.org/T220696

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde
Cc: alaa_wmde, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Aklapper, Lea_WMDE, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, 
Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T220696: Create better edit summaries for wbeditentity API endpoint

2019-06-24 Thread gerritbot 
gerritbot added a comment.


  Change 518721 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa 
Sarhan):
  [mediawiki/extensions/Wikibase@master] Add ADR explaning the change to 
ChangeOp design.
  
  https://gerrit.wikimedia.org/r/518721

TASK DETAIL
  https://phabricator.wikimedia.org/T220696

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: alaa_wmde, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Aklapper, Lea_WMDE, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T220696: Create better edit summaries for wbeditentity API endpoint

2019-05-21 Thread Lea_WMDE 
Lea_WMDE added a comment.


  In T220696#5200413 , 
@alaa_wmde wrote:
  
  > The actual limits after which we move from one version to another ( 
Expanded -> Shortend -> fallback) is to be checked and detailed during 
implementation.
  
  
  Why is that? Do you think it likely the backend will not be able to handle 
the requests of the acceptance criteria? 
  I would not want us to increase the limits. The 5 was chosen, because most 
activities are below that line, and 5 is still a "small enough" number to 
overlook. The 50 might actually be way too  big. 
  So please don't increase either of the two numbers, and please stay with 
using number of terms/ languages as deciding factors

TASK DETAIL
  https://phabricator.wikimedia.org/T220696

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lea_WMDE
Cc: alaa_wmde, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Aklapper, Lea_WMDE, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T220696: Create better edit summaries for wbeditentity API endpoint

2019-05-21 Thread alaa_wmde 
alaa_wmde added a comment.


  The actual limits after which we move from one version to another ( Expanded 
-> Shortend -> fallback) is to be checked and detailed during implementation.
  
  For example: it could be that one might try to generate one version and 
fallback to the next only if the generated test exceeded storage limits.

TASK DETAIL
  https://phabricator.wikimedia.org/T220696

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde
Cc: alaa_wmde, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Aklapper, Lea_WMDE, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs