[Wikidata-bugs] [Maniphest] [Commented On] T221835: Add CC0 License overlay popup on termbox editing

2019-10-28 Thread Addshore 
Addshore added a comment.


  This is marked as done in #Wikidata-Termbox-Iteration-18 

  Should this be resolved?

TASK DETAIL
  https://phabricator.wikimedia.org/T221835

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Meekrab2012, 
joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221835: Add CC0 License overlay popup on termbox editing

2019-07-01 Thread Jakob_WMDE 
Jakob_WMDE added a comment.


  @Lea_WMDE The message is the same as on Desktop. There's no risk of getting 
red links :)
  
  Beta Desktop red link: F29673223: Screenshot from 2019-07-01 12-55-43.png 


TASK DETAIL
  https://phabricator.wikimedia.org/T221835

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jakob_WMDE
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221835: Add CC0 License overlay popup on termbox editing

2019-07-01 Thread Lea_WMDE 
Lea_WMDE added a comment.


  In T221835#5295189 , 
@Jakob_WMDE wrote:
  
  > This can now be product tested! 
https://wikidata.beta.wmflabs.org/wiki/Q11?useformat=mobile
  
  
  Yay! For me, `terms of use` is a red link, and looking at the task 
description this is even what is pasted there. If I removed "beta.wmflabs", I 
do get the page: https://www.wikidata.org/wiki/Wikidata:Copyright, however I am 
wondering if this is the right one, since it again mentions Terms of Use, which 
is the title of the link you orginally followed. I'm currently failing to 
reproduce the state on actual Wikidata, so could you please check, if these 
really are the pages we target? And could you just confirm that we will not be 
seeing red links once we are on production?
  
  What is working:
  
  - nice display of external link icon
  - the links open in new tabs
  - white overlay
  - cancel button
  - repeated showing of this message if checkbox is not checked

TASK DETAIL
  https://phabricator.wikimedia.org/T221835

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lea_WMDE
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221835: Add CC0 License overlay popup on termbox editing

2019-06-28 Thread gerritbot 
gerritbot added a comment.


  Change 519637 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Update termbox
  
  https://gerrit.wikimedia.org/r/519637

TASK DETAIL
  https://phabricator.wikimedia.org/T221835

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221835: Add CC0 License overlay popup on termbox editing

2019-06-28 Thread gerritbot 
gerritbot added a comment.


  Change 519637 had a related patch set uploaded (by Jakob; owner: Jakob):
  [mediawiki/extensions/Wikibase@master] Update termbox
  
  https://gerrit.wikimedia.org/r/519637

TASK DETAIL
  https://phabricator.wikimedia.org/T221835

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221835: Add CC0 License overlay popup on termbox editing

2019-06-28 Thread gerritbot 
gerritbot added a comment.


  Change 518676 **merged** by jenkins-bot:
  [wikibase/termbox@master] License overlay: ensure links open in new tab
  
  https://gerrit.wikimedia.org/r/518676

TASK DETAIL
  https://phabricator.wikimedia.org/T221835

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221835: Add CC0 License overlay popup on termbox editing

2019-06-24 Thread gerritbot 
gerritbot added a comment.


  Change 518676 had a related patch set uploaded (by Jakob; owner: Jakob):
  [wikibase/termbox@master] License overlay: ensure links open in new tab
  
  https://gerrit.wikimedia.org/r/518676

TASK DETAIL
  https://phabricator.wikimedia.org/T221835

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221835: Add CC0 License overlay popup on termbox editing

2019-06-22 Thread gerritbot 
gerritbot added a comment.


  Change 517406 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Update Termbox
  
  https://gerrit.wikimedia.org/r/517406

TASK DETAIL
  https://phabricator.wikimedia.org/T221835

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221835: Add CC0 License overlay popup on termbox editing

2019-06-21 Thread gerritbot 
gerritbot added a comment.


  Change 518041 abandoned by Pablo Grass (WMDE):
  reset css: ability to replace some selectors
  
  Reason:
  This does work somewhat but is costly (as in "not clear") and still does not 
resolve the task at hand completely as the use of the :not pseudo-selector 
causes too low specificity on some of our existing rules (e.g. 
EventEmittingButton)
  
  https://bitsofco.de/on-not-and-specificity/#whataboutnot
  
  https://gerrit.wikimedia.org/r/518041

TASK DETAIL
  https://phabricator.wikimedia.org/T221835

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221835: Add CC0 License overlay popup on termbox editing

2019-06-21 Thread gerritbot 
gerritbot added a comment.


  Change 518248 **merged** by jenkins-bot:
  [wikibase/termbox@master] Re-add padding to externally styled `.external` link
  
  https://gerrit.wikimedia.org/r/518248

TASK DETAIL
  https://phabricator.wikimedia.org/T221835

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221835: Add CC0 License overlay popup on termbox editing

2019-06-21 Thread gerritbot 
gerritbot added a comment.


  Change 518248 had a related patch set uploaded (by Jakob; owner: Jakob):
  [wikibase/termbox@master] Re-add padding to externally styled `.external` link
  
  https://gerrit.wikimedia.org/r/518248

TASK DETAIL
  https://phabricator.wikimedia.org/T221835

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221835: Add CC0 License overlay popup on termbox editing

2019-06-21 Thread gerritbot 
gerritbot added a comment.


  Change 518048 abandoned by Jakob:
  reset css: ability to replace some selectors
  
  https://gerrit.wikimedia.org/r/518048

TASK DETAIL
  https://phabricator.wikimedia.org/T221835

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221835: Add CC0 License overlay popup on termbox editing

2019-06-20 Thread gerritbot 
gerritbot added a comment.


  Change 518048 had a related patch set uploaded (by Jakob; owner: Jakob):
  [wikibase/termbox@master] reset css: ability to replace some selectors
  
  https://gerrit.wikimedia.org/r/518048

TASK DETAIL
  https://phabricator.wikimedia.org/T221835

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221835: Add CC0 License overlay popup on termbox editing

2019-06-20 Thread gerritbot 
gerritbot added a comment.


  Change 518041 had a related patch set uploaded (by Pablo Grass (WMDE); owner: 
Pablo Grass (WMDE)):
  [wikibase/termbox@master] reset css: ability to replace some selectors
  
  https://gerrit.wikimedia.org/r/518041

TASK DETAIL
  https://phabricator.wikimedia.org/T221835

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221835: Add CC0 License overlay popup on termbox editing

2019-06-19 Thread Pablo-WMDE 
Pablo-WMDE added a comment.


  Decisive moment: this is the first time (I am aware of) we want to inherit a 
style. The reset CSS 

 does what it can, removing the padding in the process - only the background 
image (which is not a "usual" style for `a` tags) remains. We have to decide if 
we want to (a spectrum which probably more shades of gray in between)
  
  - avoid resetting for this class altogether
  - compensate for what was reset (= "just adding a pad right to make it fit")
  - provide a custom implementation for the generic class

TASK DETAIL
  https://phabricator.wikimedia.org/T221835

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221835: Add CC0 License overlay popup on termbox editing

2019-06-19 Thread Tarrow 
Tarrow added a comment.


  As per email from Lea to Jakob we should keep the external link sign present. 
He says this is *probably* just adding a pad right to make it fit.

TASK DETAIL
  https://phabricator.wikimedia.org/T221835

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tarrow
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221835: Add CC0 License overlay popup on termbox editing

2019-06-17 Thread Jakob_WMDE 
Jakob_WMDE added a comment.


  @Hanna_Petruschat_WMDE This story is almost complete from the dev side. While 
testing it in integration locally I noticed that the license link looks funny, 
because Minverva tries to mark external links with a special icon 
.
  Screenshot:
  F29592960: Screenshot from 2019-06-17 13-08-54.png 

  
  Do we want to have the icon too, or should it be removed? Either way is fine, 
but it obviously cannot stay the way it is.

TASK DETAIL
  https://phabricator.wikimedia.org/T221835

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jakob_WMDE
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221835: Add CC0 License overlay popup on termbox editing

2019-06-17 Thread gerritbot 
gerritbot added a comment.


  Change 517406 had a related patch set uploaded (by Jakob; owner: Jakob):
  [mediawiki/extensions/Wikibase@master] Update Termbox
  
  https://gerrit.wikimedia.org/r/517406

TASK DETAIL
  https://phabricator.wikimedia.org/T221835

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221835: Add CC0 License overlay popup on termbox editing

2019-06-13 Thread Hanna_Petruschat_WMDE 
Hanna_Petruschat_WMDE added a comment.


  I agree @Pablo-WMDE

TASK DETAIL
  https://phabricator.wikimedia.org/T221835

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Hanna_Petruschat_WMDE
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221835: Add CC0 License overlay popup on termbox editing

2019-06-12 Thread Lea_WMDE 
Lea_WMDE added a comment.


  Sounds sensible to me! @Hanna_Petruschat_WMDE ?

TASK DETAIL
  https://phabricator.wikimedia.org/T221835

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lea_WMDE
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221835: Add CC0 License overlay popup on termbox editing

2019-05-28 Thread Lea_WMDE 
Lea_WMDE added a comment.


  @Tarrow yes, sorry, there was even still a TODO to rephrase for publish. 
Updating the task description now.

TASK DETAIL
  https://phabricator.wikimedia.org/T221835

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lea_WMDE
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, 
darthmon_wmde, Premeditated, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221835: Add CC0 License overlay popup on termbox editing

2019-05-28 Thread Tarrow 
Tarrow added a comment.


  @Lea_WMDE Just a heads up that in general this message is configurable on 
mediawiki.
  
  See for example: https://www.mediawiki.org/wiki/Manual:$wgRightsUrl. We 
assume that we should take this into account. The most consistent way for us to 
do this is to use the same message that is constructed in Wikibase however this 
contains a slight textual difference: It reads
  
By clicking "publish", you agree to the terms of use, 
and you irrevocably agree to release your contribution under the https://creativecommons.org/publicdomain/zero/1.0/;>Creative Commons CC0 
License.
  
  This is very similar but not the same. note: `publish` vs `save`. Is making 
this change an acceptable change to the copy? In task breakdown this seemed the 
best way forwards to us devs.

TASK DETAIL
  https://phabricator.wikimedia.org/T221835

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tarrow
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, 
darthmon_wmde, Premeditated, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221835: Add CC0 License overlay popup on termbox editing

2019-04-25 Thread Hanna_Petruschat_WMDE 
Hanna_Petruschat_WMDE added a comment.


  Note to myself and you: What happens, if users do not check the accept line? 
Will the pop up be shown over and over again?
  I believe that's what is currently happening on desktop, right?

TASK DETAIL
  https://phabricator.wikimedia.org/T221835

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Hanna_Petruschat_WMDE
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, alaa_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs