[Wikidata-bugs] [Maniphest] [Commented On] T222621: Not possible to edit items via wbeditentity if they have same label and description

2019-06-03 Thread gerritbot 
gerritbot added a comment.


  Change 509135 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Add tests in 
LabelDescriptionNotEqualValidator for cases that it's only checking one language
  
  https://gerrit.wikimedia.org/r/509135

TASK DETAIL
  https://phabricator.wikimedia.org/T222621

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: alaa_wmde, thcipriani, Jdforrester-WMF, Jakob_WMDE, Aklapper, 
Liuxinyu970226, Tarrow, E.S.A-Sheild, darthmon_wmde, Premeditated, joker88john, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T222621: Not possible to edit items via wbeditentity if they have same label and description

2019-05-13 Thread gerritbot 
gerritbot added a comment.


  Change 509374 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Revert "Revert "Use 
LabelDescriptionNotEqualValidator in TermValidatorFactory""
  
  https://gerrit.wikimedia.org/r/509374

TASK DETAIL
  https://phabricator.wikimedia.org/T222621

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: alaa_wmde, thcipriani, Jdforrester-WMF, Jakob_WMDE, Aklapper, 
Liuxinyu970226, Tarrow, darthmon_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T222621: Not possible to edit items via wbeditentity if they have same label and description

2019-05-13 Thread gerritbot 
gerritbot added a comment.


  Change 509373 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Do not validate against same label and 
description when change is noop
  
  https://gerrit.wikimedia.org/r/509373

TASK DETAIL
  https://phabricator.wikimedia.org/T222621

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: alaa_wmde, thcipriani, Jdforrester-WMF, Jakob_WMDE, Aklapper, 
Liuxinyu970226, Tarrow, darthmon_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T222621: Not possible to edit items via wbeditentity if they have same label and description

2019-05-10 Thread gerritbot 
gerritbot added a comment.


  Change 509374 had a related patch set uploaded (by Ladsgroup; owner: 
Ladsgroup):
  [mediawiki/extensions/Wikibase@master] Revert "Revert "Use 
LabelDescriptionNotEqualValidator in TermValidatorFactory""
  
  https://gerrit.wikimedia.org/r/509374

TASK DETAIL
  https://phabricator.wikimedia.org/T222621

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: alaa_wmde, thcipriani, Jdforrester-WMF, Jakob_WMDE, Aklapper, 
Liuxinyu970226, Tarrow, darthmon_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T222621: Not possible to edit items via wbeditentity if they have same label and description

2019-05-10 Thread gerritbot 
gerritbot added a comment.


  Change 509373 had a related patch set uploaded (by Ladsgroup; owner: 
Ladsgroup):
  [mediawiki/extensions/Wikibase@master] Do not validate against same label and 
description when change is noop
  
  https://gerrit.wikimedia.org/r/509373

TASK DETAIL
  https://phabricator.wikimedia.org/T222621

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: alaa_wmde, thcipriani, Jdforrester-WMF, Jakob_WMDE, Aklapper, 
Liuxinyu970226, Tarrow, darthmon_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T222621: Not possible to edit items via wbeditentity if they have same label and description

2019-05-10 Thread Ladsgroup 
Ladsgroup added a comment.


  I dug deep into the issue and it's really interesting, first, if you try to 
edit another language, it doesn't fail using wbeditentity. This is an example I 
got:
  
{
"entity": {
"aliases": {},
"claims": {},
"descriptions": {
"de": {
"language": "de",
"value": "foo"
},
"en": {
"language": "en",
"value": "foo0"
}
},
"id": "Q29",
"labels": {
"de": {
"language": "de",
"value": "nfoo"
},
"en": {
"language": "en",
"value": "foo0"
}
},
"lastrevid": 111,
"sitelinks": {},
"type": "item"
},
"success": 1
}
  
  (I added de using httpie and wbeditentity later)
  
  It also doesn't fail if instead of `{ "labels": { "en":{"language": "en", 
"value": "foo"} }, "descriptions": { "en":{"language": "en", "value": "NOTfoo"} 
} }`, you set `'{ "labels": { "en":{"language": "en", "value": "NOTfoo"} }, 
"descriptions": { "en":{"language": "en", "value": "foo"} } }` which gives away 
why it's happening, the changeOps are atomic, the system tries to apply the 
changeOp that doesn't change anything (in our case label, and it fails. If you 
apply the description first, the entity is untangled and then you can simply 
apply the empty changeop. I can add a basic sanity check to shorten out and 
don't try to apply an empty change op and that would fix our very funny edge 
case.

TASK DETAIL
  https://phabricator.wikimedia.org/T222621

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: alaa_wmde, thcipriani, Jdforrester-WMF, Jakob_WMDE, Aklapper, 
Liuxinyu970226, Tarrow, darthmon_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T222621: Not possible to edit items via wbeditentity if they have same label and description

2019-05-10 Thread Tarrow 
Tarrow added a comment.


  Thanks for digging into it so much. Seems perhaps somehow I wandered into a 
very edge case set-up by mistake :(. As I mentioned I only found it by testing 
our new termbox on a random item on beta; seems impossibly bad/good luck that I 
ran into it with the first request I made.

TASK DETAIL
  https://phabricator.wikimedia.org/T222621

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Tarrow
Cc: alaa_wmde, thcipriani, Jdforrester-WMF, Jakob_WMDE, Aklapper, 
Liuxinyu970226, Tarrow, darthmon_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T222621: Not possible to edit items via wbeditentity if they have same label and description

2019-05-10 Thread Ladsgroup 
Ladsgroup added a comment.


  I was able to reproduce the issue, I needed to remove clear= bit. I double 
check where this is coming from

TASK DETAIL
  https://phabricator.wikimedia.org/T222621

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: alaa_wmde, thcipriani, Jdforrester-WMF, Jakob_WMDE, Aklapper, 
Liuxinyu970226, Tarrow, darthmon_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T222621: Not possible to edit items via wbeditentity if they have same label and description

2019-05-10 Thread Ladsgroup 
Ladsgroup added a comment.


  @alaa_wmde and I tested it with wmf.4 and master and with all the given 
acceptance criteria, also followed your steps to reproduce (did the API call 
using API sandbox though but it shouldn't make any difference) and still we 
can't reproduce it :'(

TASK DETAIL
  https://phabricator.wikimedia.org/T222621

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: alaa_wmde, thcipriani, Jdforrester-WMF, Jakob_WMDE, Aklapper, 
Liuxinyu970226, Tarrow, darthmon_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T222621: Not possible to edit items via wbeditentity if they have same label and description

2019-05-10 Thread Tarrow 
Tarrow added a comment.


  Sorry for the lack of explicit reproduction :/. The steps below use `httpie` 
and the mediawiki-docker-dev setup.
  
  > I didn't test anything in API, I tested everything in desktop GUI
  
  I think in desktop GUI different endpoints are used (wbsetlabel, 
wbsetdescription) not wbeditentity. Here is are steps to reproduce; sorry that 
they weren't clearly there before.
  
  1. in Wikibase `git checkout 336207887deea6ad3644c222124233a132db7f58` At the 
time of writing this is: origin/wmf/1.34.0-wmf.4
  2. make a new item e.g. `http -f POST 
default.web.mw.localhost:8080/mediawiki/api.php action==wbeditentity new==item 
data=='{ "labels": { "en":{"language": "en", "value": "foo"} }, "descriptions": 
{ "en":{"language": "en", "value": "foo"} } }' token='+\'`
  3. Apply the reverted patch `git cherry-pick  
b71b5b2af611e593816bbe6b949e216b88e1dcf8`
  4. try and change the duplicated terms: `http -f POST 
default.web.mw.localhost:8080/mediawiki/api.php action==wbeditentity id=Q314 
data=='{ "labels": { "en":{"language": "en", "value": "foo"} }, "descriptions": 
{ "en":{"language": "en", "value": "NOTfoo"} } }' token='+\'`
  5. Get returned error with info `Label and description for language code en 
can not have the same value.`

TASK DETAIL
  https://phabricator.wikimedia.org/T222621

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Tarrow
Cc: alaa_wmde, thcipriani, Jdforrester-WMF, Jakob_WMDE, Aklapper, 
Liuxinyu970226, Tarrow, darthmon_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T222621: Not possible to edit items via wbeditentity if they have same label and description

2019-05-09 Thread gerritbot 
gerritbot added a comment.


  Change 509135 had a related patch set uploaded (by Ladsgroup; owner: 
Ladsgroup):
  [mediawiki/extensions/Wikibase@master] Add tests in 
LabelDescriptionNotEqualValidator for cases that it's only checking one language
  
  https://gerrit.wikimedia.org/r/509135

TASK DETAIL
  https://phabricator.wikimedia.org/T222621

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: alaa_wmde, thcipriani, Jdforrester-WMF, Jakob_WMDE, Aklapper, 
Liuxinyu970226, Tarrow, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T222621: Not possible to edit items via wbeditentity if they have same label and description

2019-05-09 Thread Ladsgroup 
Ladsgroup added a comment.


  I went through the code and couldn't find anything that does a full check on 
the entity. I even wrote some tests to make sure it's not happening (Failed TDD 
I guess), then cherry-picked the given change 
 that 
got reverted and couldn't reproduce it locally (tried, changing another 
language, tried changing it to different label in the same language that has 
the issue, tried introducing new issue), all work as expected (I didn't test 
anything in API, I tested everything in desktop GUI). Can I get more info on 
how to reproduce the issue?

TASK DETAIL
  https://phabricator.wikimedia.org/T222621

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: alaa_wmde, thcipriani, Jdforrester-WMF, Jakob_WMDE, Aklapper, 
Liuxinyu970226, Tarrow, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T222621: Not possible to edit items via wbeditentity if they have same label and description

2019-05-07 Thread thcipriani 
thcipriani added a comment.


  In T222621#5164600 , 
@alaa_wmde wrote:
  
  > @thcipriani yes it has been reverted already
  
  
  ah, hadn't realized, thank you!

TASK DETAIL
  https://phabricator.wikimedia.org/T222621

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thcipriani
Cc: alaa_wmde, thcipriani, Mholloway, Jdforrester-WMF, Jakob_WMDE, Aklapper, 
Liuxinyu970226, Tarrow, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T222621: Not possible to edit items via wbeditentity if they have same label and description

2019-05-07 Thread alaa_wmde 
alaa_wmde added a comment.


  @thcipriani yes it has been reverted already

TASK DETAIL
  https://phabricator.wikimedia.org/T222621

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde
Cc: alaa_wmde, thcipriani, Mholloway, Jdforrester-WMF, Jakob_WMDE, Aklapper, 
Liuxinyu970226, Tarrow, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T222621: Not possible to edit items via wbeditentity if they have same label and description

2019-05-07 Thread thcipriani 
thcipriani added a comment.


  I notice that this is still blocking the train, but no one has addressed this 
yet.
  
  From the task description:
  
  > I checked this is the case by reverting just this commit.
  
  Is that a reasonable course of action we could take to remove this as a train 
blocker? i.e. reverting  https://gerrit.wikimedia.org/r/506182 ?

TASK DETAIL
  https://phabricator.wikimedia.org/T222621

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thcipriani
Cc: thcipriani, Mholloway, Jdforrester-WMF, Jakob_WMDE, Aklapper, 
Liuxinyu970226, Tarrow, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T222621: Not possible to edit items via wbeditentity if they have same label and description

2019-05-06 Thread Tarrow 
Tarrow added a comment.


  @Jakob_WMDE I think if you wanted you could maybe make this a train blocker.
  
  It's not the most crucial thing in the world because hopefully we don't have 
that many entities that have a matching label and description. Also, using 
wbsetdescription does work as a workaround. On the other hand if we can be sure 
to catch it before the train that would probably be for the best.

TASK DETAIL
  https://phabricator.wikimedia.org/T222621

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tarrow
Cc: Jakob_WMDE, Aklapper, Liuxinyu970226, Tarrow, alaa_wmde, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs