[Wikidata-bugs] [Maniphest] [Commented On] T224189: Use thumbnail preferences for thumbnail of Commons media file

[Lydia_Pintscher]

Lydia_Pintscher added a comment.


  \o/

TASK DETAIL
  https://phabricator.wikimedia.org/T224189

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Lydia_Pintscher
Cc: alaa_wmde, WMDE-leszek, Ladsgroup, hoo, Lydia_Pintscher, Aklapper, 
Multichill, darthmon_wmde, DannyS712, Nandana, Jony, Prisshahlla, Lahi, Gq86, 
GoranSMilovanovic, QZanden, V4switch, LawExplorer, _jensen, rosalieper, Jonas, 
LNDDYL, Wong128hk, Wikidata-bugs, matthiasmullie, aude, Fabrice_Florin, 
Jdforrester-WMF, Matanya, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224189: Use thumbnail preferences for thumbnail of Commons media file

[gerritbot]

gerritbot added a comment.


  Change 528497 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Use thumbnail preferences for 
thumbnail of Commons media file
  
  https://gerrit.wikimedia.org/r/528497

TASK DETAIL
  https://phabricator.wikimedia.org/T224189

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: alaa_wmde, WMDE-leszek, Ladsgroup, hoo, Lydia_Pintscher, Aklapper, 
Multichill, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Jony, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Prisshahlla, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, V4switch, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, LNDDYL, 
Wong128hk, Wikidata-bugs, matthiasmullie, aude, Fabrice_Florin, 
Jdforrester-WMF, Matanya, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224189: Use thumbnail preferences for thumbnail of Commons media file

[Ladsgroup]

Ladsgroup added a comment.


  In T224189#5398714 , 
@alaa_wmde wrote:
  
  >> One quite expensive way to do this is to define CommonsMedia value type, 
inject the thumbsize in the value type (by defining CommonsMediaValueParser 
that takes ParserOptions) and then use it in the CommonsInlineImageFormatter, 
that would be two days of work at least. Unless I'm missing something obvious.
  >
  > Is it only expensive in terms of development time? if so, two days are not 
all that expensive given that this solution will probably avoid other less 
ideal workarounds + it is a bit of good refactoring.
  
  It can be more than two days, I would say at least, not to mention the review 
and other bits. Plus I'm not sure it's conceptually correct. For monolignual 
text, the language code is part of that value. It makes sense but for commons 
media value type, I don't think its thumb size would be a good fit for the 
value.

TASK DETAIL
  https://phabricator.wikimedia.org/T224189

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: alaa_wmde, WMDE-leszek, Ladsgroup, hoo, Lydia_Pintscher, Aklapper, 
Multichill, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Jony, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Prisshahlla, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, V4switch, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, LNDDYL, 
Wong128hk, Wikidata-bugs, matthiasmullie, aude, Fabrice_Florin, 
Jdforrester-WMF, Matanya, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224189: Use thumbnail preferences for thumbnail of Commons media file

[alaa_wmde]

alaa_wmde added a comment.


  > One quite expensive way to do this is to define CommonsMedia value type, 
inject the thumbsize in the value type (by defining CommonsMediaValueParser 
that takes ParserOptions) and then use it in the CommonsInlineImageFormatter, 
that would be two days of work at least. Unless I'm missing something obvious.
  
  Is it only expensive in terms of development time? if so, two days are not 
all that expensive given that this solution will probably avoid other less 
ideal workarounds + it is a bit of good refactoring.

TASK DETAIL
  https://phabricator.wikimedia.org/T224189

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, alaa_wmde
Cc: alaa_wmde, WMDE-leszek, Ladsgroup, hoo, Lydia_Pintscher, Aklapper, 
Multichill, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Jony, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Prisshahlla, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, V4switch, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, LNDDYL, 
Wong128hk, Wikidata-bugs, matthiasmullie, aude, Fabrice_Florin, 
Jdforrester-WMF, Matanya, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224189: Use thumbnail preferences for thumbnail of Commons media file

[gerritbot]

gerritbot added a comment.


  Change 528497 had a related patch set uploaded (by Ladsgroup; owner: 
Ladsgroup):
  [mediawiki/extensions/Wikibase@master] Use thumbnail preferences for 
thumbnail of Commons media file
  
  https://gerrit.wikimedia.org/r/528497

TASK DETAIL
  https://phabricator.wikimedia.org/T224189

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: WMDE-leszek, Ladsgroup, hoo, Lydia_Pintscher, Aklapper, Multichill, 
darthmon_wmde, alaa_wmde, DannyS712, Nandana, Jony, Prisshahlla, Lahi, Gq86, 
GoranSMilovanovic, QZanden, V4switch, LawExplorer, _jensen, rosalieper, Jonas, 
LNDDYL, Wong128hk, Wikidata-bugs, matthiasmullie, aude, Fabrice_Florin, 
Jdforrester-WMF, Matanya, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224189: Use thumbnail preferences for thumbnail of Commons media file

[Ladsgroup]

Ladsgroup added a comment.


  I got it to work but I could do only by injecting global variables into 
CommonsInlineImageFormatter, I quite dislike this solution but I couldn't find 
any way around it that doesn't involve refactoring half of mediawiki core and 
wikibase. One quite expensive way to do this is to define CommonsMedia value 
type, inject the thumbsize in the value type (by defining 
CommonsMediaValueParser that takes ParserOptions) and then use it in the 
CommonsInlineImageFormatter, that would be two days of work at least. Unless 
I'm missing something obvious

TASK DETAIL
  https://phabricator.wikimedia.org/T224189

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: WMDE-leszek, Ladsgroup, hoo, Lydia_Pintscher, Aklapper, Multichill, 
darthmon_wmde, alaa_wmde, DannyS712, Nandana, Jony, Prisshahlla, Lahi, Gq86, 
GoranSMilovanovic, QZanden, V4switch, LawExplorer, _jensen, rosalieper, Jonas, 
LNDDYL, Wong128hk, Wikidata-bugs, matthiasmullie, aude, Fabrice_Florin, 
Jdforrester-WMF, Matanya, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224189: Use thumbnail preferences for thumbnail of Commons media file

[Ladsgroup]

Ladsgroup added a comment.


  In T224189#5392838 , 
@WMDE-leszek wrote:
  
  > @Ladsgroup: Have you had a chance to investigate the bypassing the parser 
cache? Any findings to share?
  
  Yes, I'm on it. The main issue is that ParserOptions are passed to data type 
parsers but we need this in the formatter.

TASK DETAIL
  https://phabricator.wikimedia.org/T224189

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: WMDE-leszek, Ladsgroup, hoo, Lydia_Pintscher, Aklapper, Multichill, 
darthmon_wmde, alaa_wmde, DannyS712, Nandana, Jony, Prisshahlla, Lahi, Gq86, 
GoranSMilovanovic, QZanden, V4switch, LawExplorer, _jensen, rosalieper, Jonas, 
LNDDYL, Wong128hk, Wikidata-bugs, matthiasmullie, aude, Fabrice_Florin, 
Jdforrester-WMF, Matanya, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224189: Use thumbnail preferences for thumbnail of Commons media file

[WMDE-leszek]

WMDE-leszek added a comment.


  @Ladsgroup: Have you had a chance to investigate the bypassing the parser 
cache? Any findings to share?

TASK DETAIL
  https://phabricator.wikimedia.org/T224189

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, WMDE-leszek
Cc: WMDE-leszek, Ladsgroup, hoo, Lydia_Pintscher, Aklapper, Multichill, 
darthmon_wmde, alaa_wmde, DannyS712, Nandana, Jony, Prisshahlla, Lahi, Gq86, 
GoranSMilovanovic, QZanden, V4switch, LawExplorer, _jensen, rosalieper, Jonas, 
LNDDYL, Wong128hk, Wikidata-bugs, matthiasmullie, aude, Fabrice_Florin, 
Jdforrester-WMF, Matanya, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224189: Use thumbnail preferences for thumbnail of Commons media file

[Ladsgroup]

Ladsgroup added a comment.


  I took a look at this, it's not hard to implement and it doesn't pollute the 
ParserCache if we get the thumbnail size from ParserOptions. That should be 
easy.

TASK DETAIL
  https://phabricator.wikimedia.org/T224189

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Ladsgroup, hoo, Lydia_Pintscher, Aklapper, Multichill, darthmon_wmde, 
Nandana, Jony, Sario528, Prisshahlla, Lahi, Gq86, GoranSMilovanovic, QZanden, 
V4switch, LawExplorer, _jensen, rosalieper, Jonas, LNDDYL, Wong128hk, 
Wikidata-bugs, matthiasmullie, aude, Fabrice_Florin, Jdforrester-WMF, Matanya, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs