[Wikidata-bugs] [Maniphest] [Commented On] T225814: m.wikidata: login status not detected

[Jdlrobson]

Jdlrobson added a comment.


  Sorry Centralauth my bad. Always mixing up those 2.

TASK DETAIL
  https://phabricator.wikimedia.org/T225814

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: ovasileva, darthmon_wmde, Jdlrobson, aude, WDoranWMF, Anomie, Stryn, 
Addshore, Reedy, Jonas, Jakob_WMDE, Legoktm, hoo, csteipp, vvv, Framawiki, 
Lydia_Pintscher, WMDE-leszek, Aklapper, Pablo-WMDE, CptViraj, DannyS712, 
wildly_boy, Nandana, Lahi, Gq86, mojoaxel, GoranSMilovanovic, QZanden, 
LawExplorer, Winter, JJMC89, _jensen, rosalieper, Agabi10, Scott_WUaS, 
Wong128hk, Wikidata-bugs, Snowolf, Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T225814: m.wikidata: login status not detected

[WMDE-leszek]

WMDE-leszek added a comment.


  Thanks @Jdlrobson for your elaboration.
  
  > The issue should be resolved in CentralNotice (I'm not sure who maintains 
that) however I'm not quite sure how this will work.
  
  Did you mean CentralAuth, or actually CentralNotice? (First time Central 
Notice is mentioned in this context, hence I felt like I'd double check)

TASK DETAIL
  https://phabricator.wikimedia.org/T225814

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: WMDE-leszek
Cc: ovasileva, darthmon_wmde, Jdlrobson, aude, WDoranWMF, Anomie, Stryn, 
Addshore, Reedy, Jonas, Jakob_WMDE, Legoktm, hoo, csteipp, vvv, Framawiki, 
Lydia_Pintscher, WMDE-leszek, Aklapper, Pablo-WMDE, CptViraj, DannyS712, 
wildly_boy, Nandana, Lahi, Gq86, mojoaxel, GoranSMilovanovic, QZanden, 
LawExplorer, Winter, JJMC89, _jensen, rosalieper, Agabi10, Scott_WUaS, 
Wong128hk, Wikidata-bugs, Snowolf, Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T225814: m.wikidata: login status not detected

[WDoranWMF]

WDoranWMF added a comment.


  Thanks @Anomie !

TASK DETAIL
  https://phabricator.wikimedia.org/T225814

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: WDoranWMF
Cc: Jdlrobson, aude, Krinkle, WDoranWMF, Anomie, Stryn, Addshore, Reedy, Jonas, 
Jakob_WMDE, Legoktm, hoo, csteipp, vvv, Framawiki, Lydia_Pintscher, 
WMDE-leszek, Aklapper, Pablo-WMDE, darthmon_wmde, DannyS712, Nandana, Lahi, 
Gq86, mojoaxel, GoranSMilovanovic, QZanden, LawExplorer, Winter, JJMC89, 
_jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, Mbch331, Rxy
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T225814: m.wikidata: login status not detected

[Anomie]

Anomie added a comment.


  In T225814#5992589 , 
@Anomie wrote:
  
  > Digging a little deeper, it seems to assume that every URL being mangled 
can use the local value for `$wgMobileUrlTemplate` rather than determining the 
mangling based on the //target// domain.
  
  On that note, it may be causing problems in links out of wikidata.org and 
similar domains too:
  
anomie@mwmaint1002:~$ mwscript shell.php --wiki=wikidatawiki
Psy Shell v0.9.12 (PHP 7.2.26-1+0~20191218.33+debian9~1.gbpb5a340+wmf1 — 
cli) by Justin Hileman
>>> $wiki = WikiMap::getWiki( 'enwiki' );
=> WikiReference {#2944}
>>> $url = $wiki->getFullUrl( 'Special:CentralAutoLogin/start' );
=> "//en.wikipedia.org/wiki/Special:CentralAutoLogin/start"
>>> MobileContext::singleton()->getMobileUrl( $url )
=> "//m.wikipedia.org/wiki/Special:CentralAutoLogin/start"

TASK DETAIL
  https://phabricator.wikimedia.org/T225814

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Anomie
Cc: Jdlrobson, aude, Krinkle, WDoranWMF, Anomie, Stryn, Addshore, Reedy, Jonas, 
Jakob_WMDE, Legoktm, hoo, csteipp, vvv, Framawiki, Lydia_Pintscher, 
WMDE-leszek, Aklapper, Pablo-WMDE, darthmon_wmde, DannyS712, Nandana, Lahi, 
Gq86, mojoaxel, GoranSMilovanovic, QZanden, LawExplorer, Winter, JJMC89, 
_jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, Mbch331, Rxy
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T225814: m.wikidata: login status not detected

[Addshore]

Addshore added a comment.


  My hunch would be that this has to do with the CA cookie domain for things 
like wikipedia being set to ".wikipedia.org" but the domain for wikidata gets 
set to "www.wikidata.org".
  
  Which would mean this related to wgCentralAuthLoginWiki which is documented 
on https://www.mediawiki.org/wiki/Extension:CentralAuth and also our default 
settings for that var which can be found in InitialiseSettings.php
  
'.wikipedia.org' => 'enwiki',
'meta.wikimedia.org' => 'metawiki',
'.wiktionary.org' => 'enwiktionary',
'.wikibooks.org' => 'enwikibooks',
'.wikiquote.org' => 'enwikiquote',
'.wikisource.org' => 'enwikisource',
'commons.wikimedia.org' => 'commonswiki',
'.wikinews.org' => 'enwikinews',
'.wikiversity.org' => 'enwikiversity',
'.mediawiki.org' => 'mediawikiwiki',
'www.wikidata.org' => 'wikidatawiki',
'species.wikimedia.org' => 'specieswiki',
'incubator.wikimedia.org' => 'incubatorwiki',
'.wikivoyage.org' => 'enwikivoyage',
  
  Needs a bit more investigation thoguh

TASK DETAIL
  https://phabricator.wikimedia.org/T225814

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, Reedy, Jonas, Jakob_WMDE, Legoktm, hoo, csteipp, vvv, Framawiki, 
Lydia_Pintscher, WMDE-leszek, Aklapper, Pablo-WMDE, darthmon_wmde, DannyS712, 
wildly_boy, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
JJMC89, _jensen, rosalieper, Agabi10, Wong128hk, Wikidata-bugs, Snowolf, aude, 
Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T225814: m.wikidata: login status not detected

[WMDE-leszek]

WMDE-leszek added a comment.


  Seems to also happen for mediawiki.org.
  Does not happen on test.wikidata.org.
  
  Network connection stack trace:
  ...
  
https://login.wikimedia.org/wiki/Special:CentralAutoLogin/checkLoggedIn?type=script=wikidatawiki=1=https=1
  
https://www.m.wikidata.org/wiki/Special:CentralAutoLogin/createSession?token=...=script=https=1
  
  I believe (but I do not claim to be right on this one) the issue happens 
inside 
https://github.com/wikimedia/mediawiki-extensions-CentralAuth/blob/e7ff08db5325ba0d1a4728dcc3d70df06a0cec7f/includes/specials/SpecialCentralAutoLogin.php#L608-L625
  
  Not very extensive testing around `MobileContext::getMobileUrl` has not 
identify issues over there. Current working hypothesis of mine is that it is 
`WikiMap::getForeignURL` what adds the superfluous `www.` to the URL.

TASK DETAIL
  https://phabricator.wikimedia.org/T225814

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: WMDE-leszek
Cc: Lydia_Pintscher, WMDE-leszek, Aklapper, Pablo-WMDE, darthmon_wmde, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs