[Wikidata-bugs] [Maniphest] [Commented On] T230117: Remove type: statement from JSON serialization of statements

[LucasWerkmeister]

LucasWerkmeister added a comment.


  I just discovered that in API requests (`wbsetclaim`, `wbeditentity`, etc.), 
the `type` is //not//, as I had assumed, optional – if you omit it, you’ll get 
some sort of error (though it seems to vary depending on situation – I’ve seen 
`invalid-claim` error responses as well as 
`Deserializers\Exceptions\MissingTypeException` uncaught exceptions). So an 
additional acceptance criterion should be that the `type` is no longer required 
there. (This part is not a breaking change, so it could be done sooner.)

TASK DETAIL
  https://phabricator.wikimedia.org/T230117

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: LucasWerkmeister
Cc: LucasWerkmeister, Aklapper, Lucas_Werkmeister_WMDE, darthmon_wmde, 
DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T230117: Remove type: statement from JSON serialization of statements

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Even Pywikibot, which still calls Statements “Claims”, doesn’t read the 
`type` when deserializing a Statement (`Claim.fromJSON`), although it does emit 
a `type` when serializing it (`Claim.toJSON`).

TASK DETAIL
  https://phabricator.wikimedia.org/T230117

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Lucas_Werkmeister_WMDE, darthmon_wmde, DannyS712, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs