subject:"\[Wikidata\-bugs\] \[Maniphest\] \[Commented On\] T232006\: LDF service does not Vary responses by Accept, sending incorrect cached responses to clients"

[Wikidata-bugs] [Maniphest] [Commented On] T232006: LDF service does not Vary responses by Accept, sending incorrect cached responses to clients

2020-01-24 Thread gerritbot

gerritbot added a comment.


  Change 536168 abandoned by Gehel:
  Add a Vary: Accept header to LDF responses.
  
  Reason:
  handled at nginx
  
  https://gerrit.wikimedia.org/r/536168

TASK DETAIL
  https://phabricator.wikimedia.org/T232006

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mstyles, gerritbot
Cc: Mstyles, Gehel, BBlack, Lucas_Werkmeister_WMDE, Aklapper, Lexie_23Kr, 
Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, 
Meekrab2012, joker88john, Legado_Shulgin, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Davinaclare77, Adrian1985, 
Qtn1293, Cpaulf30, Techguru.pc, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, 
QZanden, EBjune, merbst, LawExplorer, WSH1906, Lewizho99, Zppix, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, Wong128hk, jkroll, Smalyshev, 
Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, faidon, Mbch331, Rxy, 
Jay8g, fgiunchedi
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T232006: LDF service does not Vary responses by Accept, sending incorrect cached responses to clients

2020-01-10 Thread Mstyles

Mstyles added a comment.


  @gehel I think we can consider this closed unless someone is able to reproduce

TASK DETAIL
  https://phabricator.wikimedia.org/T232006

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mstyles
Cc: Mstyles, Gehel, BBlack, Lucas_Werkmeister_WMDE, Aklapper, Lexie_23Kr, 
Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, 
Meekrab2012, joker88john, Legado_Shulgin, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Davinaclare77, Adrian1985, 
Qtn1293, Cpaulf30, Techguru.pc, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, 
QZanden, EBjune, merbst, LawExplorer, WSH1906, Lewizho99, Zppix, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, Wong128hk, jkroll, Smalyshev, 
Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, faidon, Mbch331, Rxy, 
Jay8g, fgiunchedi
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T232006: LDF service does not Vary responses by Accept, sending incorrect cached responses to clients

2019-12-16 Thread Gehel

Gehel added a comment.


  Note that we already set a `Vary: Accept` HTTP header at nginx level 
(https://github.com/wikimedia/puppet/blob/production/modules/query_service/templates/nginx.erb#L112).
 We could discuss if that's really the correct place to set it, but since it is 
there and the behaviour is not what we expect, the immediate issue is probably 
the whitelist / normalization done at the caching layer.

TASK DETAIL
  https://phabricator.wikimedia.org/T232006

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Gehel
Cc: Gehel, BBlack, Lucas_Werkmeister_WMDE, Aklapper, Lexie_23Kr, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Meekrab2012, 
joker88john, Legado_Shulgin, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Davinaclare77, Adrian1985, Qtn1293, 
Cpaulf30, Techguru.pc, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, 
EBjune, merbst, LawExplorer, WSH1906, Lewizho99, Zppix, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Xmlizer, Wong128hk, jkroll, Smalyshev, 
Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, faidon, Mbch331, Rxy, 
Jay8g, fgiunchedi
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T232006: LDF service does not Vary responses by Accept, sending incorrect cached responses to clients

2019-10-01 Thread Gehel

Gehel added a comment.


  The MIME types used are:
  
  - text/html
  - application/rdf+xml
  - application/n-triples
  - application/ld+json
  - text/turtle

TASK DETAIL
  https://phabricator.wikimedia.org/T232006

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Gehel
Cc: Gehel, BBlack, Lucas_Werkmeister_WMDE, Aklapper, Lexie_23Kr, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Meekrab2012, 
joker88john, Legado_Shulgin, DannyS712, CucyNoiD, Nandana, NebulousIris, 
thifranc, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Davinaclare77, 
Adrian1985, Qtn1293, Cpaulf30, Techguru.pc, Lahi, Gq86, Af420, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, 
Liugev6, QZanden, EBjune, merbst, LawExplorer, WSH1906, Lewizho99, Zppix, 
Maathavan, _jensen, rosalieper, Jonas, Xmlizer, Wong128hk, jkroll, Smalyshev, 
Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, faidon, Mbch331, Jay8g, 
fgiunchedi
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T232006: LDF service does not Vary responses by Accept, sending incorrect cached responses to clients

2019-09-19 Thread Lucas_Werkmeister_WMDE

Lucas_Werkmeister_WMDE added a comment.


  Real code: `MIMEParse.java` 

 makes the decision, is initialized with five MIME types 
,
 and then asked for the “best match” for the `Accept` header 
.
 It appears to take the “quality” parameter into account, somehow; on the other 
hand, others have already complained that it doesn’t understand 
`application/ld+json` as equivalent to `application/json` 
.

TASK DETAIL
  https://phabricator.wikimedia.org/T232006

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: BBlack, Lucas_Werkmeister_WMDE, Aklapper, Lexie_23Kr, Hook696, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Meekrab2012, 
joker88john, Legado_Shulgin, DannyS712, CucyNoiD, Nandana, NebulousIris, 
thifranc, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Davinaclare77, 
Adrian1985, Qtn1293, Cpaulf30, Techguru.pc, Lahi, Gq86, Af420, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, 
Liugev6, QZanden, EBjune, merbst, LawExplorer, WSH1906, Lewizho99, Zppix, 
Maathavan, _jensen, rosalieper, Jonas, Xmlizer, Wong128hk, jkroll, Smalyshev, 
Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, faidon, Mbch331, Jay8g, 
fgiunchedi
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T232006: LDF service does not Vary responses by Accept, sending incorrect cached responses to clients

2019-09-18 Thread BBlack

BBlack added a comment.


  We'll also need to normalize the incoming `Accept` headers up in the edge 
cache layer to avoid pointless vary explosions.  Ideally the normalization 
should exactly match the application-layer logic that chooses the output 
content type.  Do you have some pseudo-code (or real code link is fine too) 
description of how accept is parsed to select content-types?

TASK DETAIL
  https://phabricator.wikimedia.org/T232006

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BBlack
Cc: BBlack, Lucas_Werkmeister_WMDE, Aklapper, Lexie_23Kr, Hook696, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Meekrab2012, 
joker88john, Legado_Shulgin, DannyS712, CucyNoiD, Nandana, NebulousIris, 
thifranc, AndyTan, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Davinaclare77, Adrian1985, Qtn1293, Cpaulf30, Techguru.pc, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Hfbn0, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, WSH1906, 
Lewizho99, Zppix, Maathavan, _jensen, rosalieper, Jonas, Xmlizer, Wong128hk, 
jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, 
faidon, Mbch331, Jay8g, fgiunchedi
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T232006: LDF service does not Vary responses by Accept, sending incorrect cached responses to clients

[Wikidata-bugs] [Maniphest] [Commented On] T232006: LDF service does not Vary responses by Accept, sending incorrect cached responses to clients

[Wikidata-bugs] [Maniphest] [Commented On] T232006: LDF service does not Vary responses by Accept, sending incorrect cached responses to clients

[Wikidata-bugs] [Maniphest] [Commented On] T232006: LDF service does not Vary responses by Accept, sending incorrect cached responses to clients

[Wikidata-bugs] [Maniphest] [Commented On] T232006: LDF service does not Vary responses by Accept, sending incorrect cached responses to clients

[Wikidata-bugs] [Maniphest] [Commented On] T232006: LDF service does not Vary responses by Accept, sending incorrect cached responses to clients

6 matches

Site Navigation

Mail list logo

Footer information