[Wikidata-bugs] [Maniphest] [Commented On] T239195: Wikidata: On Minerva skin section always stays expanded even it's disabled in settings

[Addshore]

Addshore added a comment.


  I started rewriting the task description to make the issue clear.
  
  But then I realized, Why should wgMFCollapseSectionsByDefault being false 
mean that this setting should not appear for "Expanding all sections"?
  
  The current behaviour is:
  
  - wgMFCollapseSectionsByDefault is false so the sections on pages are not 
collapsed by default.
  - "Expanding all sections" is false, so MF does no expand any collapsed 
sections
  
  "Expanding all sections" doesn't however say that when it is disabled, it 
will actually collapse sections, it will just do nothing, and leave the page as 
the default, which on wikidata, seems to be expanded.
  
  Pinging @Jdlrobson again to see if he has any thoughts here as I kind of 
agree that everything is working as expected, but perhaps there is something 
for having a collapse by default option in the settings or something like that.

TASK DETAIL
  https://phabricator.wikimedia.org/T239195

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: MaxSem, Ammarpad, thiemowmde, Lydia_Pintscher, Jdlrobson, Addshore, 
Aklapper, Masumrezarock100, 1997kB, darthmon_wmde, Dibya, 94rain, DannyS712, 
Nandana, Guilhermebm, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, 
Zoranzoki21, LawExplorer, DatGuy, Devwaker, Niklitov, _jensen, Urbanecm, 
rosalieper, JEumerus, Scott_WUaS, Ananthsubray, Tulsi_Bhagat, Wong128hk, 
Luke081515, SimmeD, Wikidata-bugs, Snowolf, aude, Dcljr, Jdforrester-WMF, 
Matanya, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T239195: Wikidata: On Minerva skin section always stays expanded even it's disabled in settings

[Ammarpad]

Ammarpad added a comment.


  OK I have looked into this further... I have partly struck my comment in 
T239195#5699077  as a result.
  
  Summary.
  
  1. Mobile section collapsing is disabled by default on Wikidata.
  
  name=wmf-config/InitialiseSettings.php
'wgMFCollapseSectionsByDefault' => [
'default' => true,
'wiktionary' => false,
'wikidata' => false,
],
  
  Why it's disabled is beyond the scope of this task.
  
  2. Setting "wgMFCollapseSectionsByDefault' => false;" means that, per default 
sections are to not be collapsed sitewide. BUT a user can still override this 
setting by going to the Special:MobileOptions and turning on the 'Expand all 
sections.'
  
  3. I investigated this by going to 
https://m.wikidata.org/w/index.php?title=Special:MobileOptions (note: this 
special page only works on mobile) and **turning off** "Expand all sections". 
It works correctly as expected: Sections are not expanded, EXCEPT on some few 
pages. These pages where this collapsing is not taking place have something in 
common,  they have a particular template at the top from what I understand. 
(This is what needs further investigation)
  
  4. Going to the same special page as above (no. 3) and **turning on** "Expand 
all sections" works correctly as expected: Sections are all expanded.

TASK DETAIL
  https://phabricator.wikimedia.org/T239195

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ammarpad
Cc: MaxSem, Ammarpad, thiemowmde, Lydia_Pintscher, Jdlrobson, Addshore, 
Aklapper, Masumrezarock100, 1997kB, darthmon_wmde, Dibya, 94rain, DannyS712, 
Nandana, Guilhermebm, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, 
Zoranzoki21, LawExplorer, DatGuy, Devwaker, Niklitov, _jensen, Urbanecm, 
rosalieper, JEumerus, Scott_WUaS, Ananthsubray, Tulsi_Bhagat, Wong128hk, 
Luke081515, SimmeD, Wikidata-bugs, Snowolf, aude, Dcljr, Jdforrester-WMF, 
Matanya, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T239195: Wikidata: On Minerva skin section always stays expanded even it's disabled in settings

[Masumrezarock100]

Masumrezarock100 added a comment.


  In T239195#5693935 , 
@Jdlrobson wrote:
  
  > According to config wgMFCollapseSectionsByDefault is set to false so 
MobileFrontend is doing what it's supposed to do here.
  
  Indeed. But that option in mobile settings shouldn't appear if 
wgMFCollapseSectionsByDefault is set to false. It looks like a bug if we see it 
in that way.

TASK DETAIL
  https://phabricator.wikimedia.org/T239195

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Masumrezarock100
Cc: MaxSem, Ammarpad, thiemowmde, Lydia_Pintscher, Jdlrobson, Addshore, 
Aklapper, Masumrezarock100, 1997kB, darthmon_wmde, Dibya, 94rain, DannyS712, 
Nandana, Guilhermebm, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, 
Zoranzoki21, LawExplorer, DatGuy, Devwaker, Niklitov, _jensen, Urbanecm, 
rosalieper, JEumerus, Scott_WUaS, Ananthsubray, Tulsi_Bhagat, Wong128hk, 
Luke081515, SimmeD, Wikidata-bugs, Snowolf, aude, Dcljr, Jdforrester-WMF, 
Matanya, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T239195: Wikidata: On Minerva skin section always stays expanded even it's disabled in settings

[1997kB]

1997kB added a comment.


  > Not all changes on Wikimedia projects have community consensus, especially 
for preferences that user can disable and even more so in Wikidata project.
  
  Yeah that's what the issue is, it's not a normal feature which can be 
enabled/disabled, so IMO a consensus should be there.
  
  > Plus, even if there was no consensus, the fact that this was not challenged 
for five years, is enough to make it a consensus itself.
  
  No I don't agree with you on this. IMO this is not challenged is because lack 
of use of mobile site by Wikidata users. And even if it not challenged it is 
really not user friendly, like if somebody go 
https://m.wikidata.org/wiki/Wikidata:Requests_for_deletions you can't even load 
that page properly with those sections expanded.
  
  > Yeah, this is what I think. A separate task for MobileFrontend: if the 
settings has been disabled sitewide, don't show this to end-user which gives 
false impression that a user can change it, when in fact no one could (like we 
have here).
  
  Yeah, I originally tagged mobileFrontend but somebody removed saying 
mobileFrontend is doing what should be. So if you have better luck convincing 
them, feel free to go for another task.

TASK DETAIL
  https://phabricator.wikimedia.org/T239195

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: 1997kB
Cc: MaxSem, Ammarpad, thiemowmde, Lydia_Pintscher, Jdlrobson, Addshore, 
Aklapper, Masumrezarock100, 1997kB, darthmon_wmde, Dibya, 94rain, DannyS712, 
Nandana, Guilhermebm, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, 
Zoranzoki21, LawExplorer, DatGuy, Devwaker, Niklitov, _jensen, Urbanecm, 
rosalieper, JEumerus, Scott_WUaS, Ananthsubray, Tulsi_Bhagat, Wong128hk, 
Luke081515, SimmeD, Wikidata-bugs, Snowolf, aude, Dcljr, Jdforrester-WMF, 
Matanya, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T239195: Wikidata: On Minerva skin section always stays expanded even it's disabled in settings

[Ammarpad]

Ammarpad added a comment.


  In T239195#5699074 , 
@1997kB wrote:
  
  > @Masumrezarock100 @Ammarpad
  > Well I'm not seeing this wrong. If you care to go to settings in Mobile 
site there's a button ''Expand all sections''. And that button doesn't work as 
it says, so I wonder why it's not bug?
  
  I did go before commenting here. I understand what you mean, see below
  
  > Plus even if I try to see it your way there's no community consensus too to 
make it that way. Even if there is that button should be hidden then, beacuse 
it is misleading (maybe another task needed).
  
  Not all changes on Wikimedia projects have community consensus, especially 
for preferences that user can disable and even more so in Wikidata project.
  Plus, even if there was no consensus, the fact that this was not challenged 
for five years, is enough to make it a consensus itself.
  
  > So this task is clear that ''there's a button in settings, which doesn't 
work as it should be".
  
  Yeah, this is what I think. A separate task for MobileFrontend: if the 
settings has been disabled sitewide, don't show this to end-user which gives 
false impression that a user can change it, when in fact no one could (like we 
have here).

TASK DETAIL
  https://phabricator.wikimedia.org/T239195

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ammarpad
Cc: MaxSem, Ammarpad, thiemowmde, Lydia_Pintscher, Jdlrobson, Addshore, 
Aklapper, Masumrezarock100, 1997kB, darthmon_wmde, Dibya, 94rain, DannyS712, 
Nandana, Guilhermebm, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, 
Zoranzoki21, LawExplorer, DatGuy, Devwaker, Niklitov, _jensen, Urbanecm, 
rosalieper, JEumerus, Scott_WUaS, Ananthsubray, Tulsi_Bhagat, Wong128hk, 
Luke081515, SimmeD, Wikidata-bugs, Snowolf, aude, Dcljr, Jdforrester-WMF, 
Matanya, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T239195: Wikidata: On Minerva skin section always stays expanded even it's disabled in settings

[1997kB]

1997kB added a comment.


  Well I'm not seeing this wrong. If you care to go to settings in Mobile site 
there's a button ''Expand all sections''. And that button doesn't work as it 
says, so I wonder why it's not bug?
  
  Plus even if I try to see it your way there's no community consensus too to 
make it that way. Even if there is that button should be hidden then, beacuse 
it is misleading (maybe another task needed).
  
  So this task is clear that ''there's a button in settings, which doesn't work 
as it should be".

TASK DETAIL
  https://phabricator.wikimedia.org/T239195

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: 1997kB
Cc: MaxSem, Ammarpad, thiemowmde, Lydia_Pintscher, Jdlrobson, Addshore, 
Aklapper, Masumrezarock100, 1997kB, darthmon_wmde, Dibya, 94rain, DannyS712, 
Nandana, Guilhermebm, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, 
Zoranzoki21, LawExplorer, DatGuy, Devwaker, Niklitov, _jensen, Urbanecm, 
rosalieper, JEumerus, Scott_WUaS, Ananthsubray, Tulsi_Bhagat, Wong128hk, 
Luke081515, SimmeD, Wikidata-bugs, Snowolf, aude, Dcljr, Jdforrester-WMF, 
Matanya, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T239195: Wikidata: On Minerva skin section always stays expanded even it's disabled in settings

[Ammarpad]

Ammarpad added a comment.


  In T239195#5696583 , 
@1997kB wrote:
  
  > @Ammarpad Why it's not bug report?
  
  As already well-explained above by multiple people, because this is not a 
bug. I wonder why you're not seeing this.
  
  That said, this task currently as written is invalid. Unless it's converted 
to proper request for //enabling// the collapsing, (which itself will only be 
valid after getting community consensus or other appropriate means for making 
such changes to Wikidata)

TASK DETAIL
  https://phabricator.wikimedia.org/T239195

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ammarpad
Cc: MaxSem, Ammarpad, thiemowmde, Lydia_Pintscher, Jdlrobson, Addshore, 
Aklapper, Masumrezarock100, 1997kB, darthmon_wmde, Dibya, 94rain, DannyS712, 
Nandana, Guilhermebm, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, 
Zoranzoki21, LawExplorer, DatGuy, Devwaker, Niklitov, _jensen, Urbanecm, 
rosalieper, JEumerus, Scott_WUaS, Ananthsubray, Tulsi_Bhagat, Wong128hk, 
Luke081515, SimmeD, Wikidata-bugs, Snowolf, aude, Dcljr, Jdforrester-WMF, 
Matanya, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T239195: Wikidata: On Minerva skin section always stays expanded even it's disabled in settings

[Masumrezarock100]

Masumrezarock100 added a comment.


  In T239195#5696583 , 
@1997kB wrote:
  
  > @Ammarpad Why it's not bug report?
  
  Because it's not a bug, but a config problem.

TASK DETAIL
  https://phabricator.wikimedia.org/T239195

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Masumrezarock100
Cc: Ammarpad, thiemowmde, Lydia_Pintscher, Jdlrobson, Addshore, Aklapper, 
Masumrezarock100, 1997kB, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T239195: Wikidata: On Minerva skin section always stays expanded even it's disabled in settings

[Lydia_Pintscher]

Lydia_Pintscher added a comment.


  In T239195#5696345 , 
@Addshore wrote:
  
  > Indeed
  > F31314276: image.png 
  > This seems to have been done in 
https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/179513/
  > There isn't much of a [paper trail so I don't know / remember exactly why 
this was done.
  > @Lydia_Pintscher @thiemowmde any idea?
  
  No unfortunately I don't know either.

TASK DETAIL
  https://phabricator.wikimedia.org/T239195

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Ammarpad, thiemowmde, Lydia_Pintscher, Jdlrobson, Addshore, Aklapper, 
Masumrezarock100, 1997kB, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T239195: Wikidata: On Minerva skin section always stays expanded even it's disabled in settings

[1997kB]

1997kB added a comment.


  No it happens on WD:AN and WD:RFD too.
  
  No it doesn't happen on any other WMF sites.

TASK DETAIL
  https://phabricator.wikimedia.org/T239195

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: 1997kB
Cc: Addshore, Aklapper, Masumrezarock100, 1997kB, darthmon_wmde, DannyS712, 
Nandana, nray, Lahi, Gq86, mojoaxel, GoranSMilovanovic, QZanden, pmiazga, 
LawExplorer, _jensen, rosalieper, Jdrewniak, Scott_WUaS, Niedzielski, 
Wikidata-bugs, Jdlrobson, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T239195: Wikidata: On Minerva skin section always stays expanded even it's disabled in settings

[Addshore]

Addshore added a comment.


  Is this relating to talk pages?
  Does this happen on any other WMF sites? Or only Wikidata?

TASK DETAIL
  https://phabricator.wikimedia.org/T239195

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, Aklapper, Masumrezarock100, 1997kB, darthmon_wmde, DannyS712, 
Nandana, nray, Lahi, Gq86, mojoaxel, GoranSMilovanovic, QZanden, pmiazga, 
LawExplorer, _jensen, rosalieper, Jdrewniak, Scott_WUaS, Niedzielski, 
Wikidata-bugs, Jdlrobson, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs