[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: UX->Dev Sync (impact: medium)

2020-03-16 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  See also the screenshots in T239421#5955854 
 (it’s more obvious at 300% 
zoom).

TASK DETAIL
  https://phabricator.wikimedia.org/T239421

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, WMDE-leszek, darthmon_wmde, Pablo-WMDE, Michael, SaraiSan, 
Lucas_Werkmeister_WMDE, Sarai-WMDE, Aklapper, Charlie_WMDE, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: UX->Dev Sync (impact: medium)

2020-03-16 Thread Michael
Michael added a comment.


  In T239421#5971450 , 
@Charlie_WMDE wrote:
  
  > @Lucas_Werkmeister_WMDE Heyho, for me the top border is still missing. Am I 
looking in the wrong place?
  
  Yes, this was only an issue on mobile. On desktop, the top border is provided 
by the surrounding element and is therefore not part of the header element 
itself. But if you look at the header element on mobile, then you'll see the 
top border there.
  
  (Though honestly, I have yet to understand what purpose it serves there.)

TASK DETAIL
  https://phabricator.wikimedia.org/T239421

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Michael
Cc: Lydia_Pintscher, WMDE-leszek, darthmon_wmde, Pablo-WMDE, Michael, SaraiSan, 
Lucas_Werkmeister_WMDE, Sarai-WMDE, Aklapper, Charlie_WMDE, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: UX->Dev Sync (impact: medium)

2020-03-16 Thread Charlie_WMDE
Charlie_WMDE added a comment.


  @Lucas_Werkmeister_WMDE Heyho, for me the top border is still missing. Am I 
looking in the wrong place?
  F31684274: Screenshot_20200316_105242.png 

  
  F31684273: Screenshot_20200316_105302.png 


TASK DETAIL
  https://phabricator.wikimedia.org/T239421

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Charlie_WMDE
Cc: Lydia_Pintscher, WMDE-leszek, darthmon_wmde, Pablo-WMDE, Michael, SaraiSan, 
Lucas_Werkmeister_WMDE, Sarai-WMDE, Aklapper, Charlie_WMDE, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: UX->Dev Sync (impact: medium)

2020-03-12 Thread gerritbot
gerritbot added a comment.


  Change 578928 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] bridge: add border-top for header on 
mobile
  
  https://gerrit.wikimedia.org/r/578928

TASK DETAIL
  https://phabricator.wikimedia.org/T239421

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lydia_Pintscher, WMDE-leszek, darthmon_wmde, Pablo-WMDE, Michael, SaraiSan, 
Lucas_Werkmeister_WMDE, Sarai-WMDE, Aklapper, Charlie_WMDE, Alter-paule, 
Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, Meekrab2012, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: UX->Dev Sync (impact: medium)

2020-03-12 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  Great, thank you!

TASK DETAIL
  https://phabricator.wikimedia.org/T239421

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, WMDE-leszek, darthmon_wmde, Pablo-WMDE, Michael, SaraiSan, 
Lucas_Werkmeister_WMDE, Sarai-WMDE, Aklapper, Charlie_WMDE, Alter-paule, 
Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, Meekrab2012, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: UX->Dev Sync (impact: medium)

2020-03-12 Thread Charlie_WMDE
Charlie_WMDE added a comment.


  In T239421#5960735 , 
@Lucas_Werkmeister_WMDE wrote:
  
  >> So should we now add a border-top of our own on mobile? (But still no 
border on the other sides?)
  >
  > (The above change assumes that the answer to these questions is “yes”, 
though I’d appreciate a confirmation from UX to be sure.)
  
  @Lucas_Werkmeister_WMDE yes, adding a 1px border on top of the header, so it 
measures 50px altogether is correct.

TASK DETAIL
  https://phabricator.wikimedia.org/T239421

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Charlie_WMDE
Cc: Lydia_Pintscher, WMDE-leszek, darthmon_wmde, Pablo-WMDE, Michael, SaraiSan, 
Lucas_Werkmeister_WMDE, Sarai-WMDE, Aklapper, Charlie_WMDE, Alter-paule, 
Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, Meekrab2012, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs