[Wikidata-bugs] [Maniphest] [Commented On] T243158: Item has label conflict with itself

[gerritbot]

gerritbot added a comment.


  Change 568066 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Validate ChangeOp against the current 
entity instead of an empty one
  
  https://gerrit.wikimedia.org/r/568066

TASK DETAIL
  https://phabricator.wikimedia.org/T243158

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Addshore, Ladsgroup, Aklapper, Liuxinyu970226, Mbch331, Un1tY, Ironie, 
Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, 
darthmon_wmde, alaa_wmde, Jaygray0919, AramBakir, Meekrab2012, joker88john, 
CucyNoiD, Nandana, NebulousIris, Arch2all, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, dmaza, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, DFelten, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, HakanIST, _jensen, rosalieper, Hannolans, Scott_WUaS, Jonas, 
Samwilson, Wikidata-bugs, aude, Lydia_Pintscher, Tpt
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T243158: Item has label conflict with itself

[gerritbot]

gerritbot added a comment.


  Change 568490 **merged** by jenkins-bot:
  [mediawiki/extensions/WikibaseLexeme@master] Throw right exception when 
trying to apply change on non-existent subentity
  
  https://gerrit.wikimedia.org/r/568490

TASK DETAIL
  https://phabricator.wikimedia.org/T243158

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Addshore, Ladsgroup, Aklapper, Liuxinyu970226, Mbch331, Un1tY, Ironie, 
Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, 
darthmon_wmde, alaa_wmde, Jaygray0919, AramBakir, Meekrab2012, joker88john, 
CucyNoiD, Nandana, NebulousIris, Arch2all, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, dmaza, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, DFelten, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, HakanIST, _jensen, rosalieper, Hannolans, Scott_WUaS, Jonas, 
Samwilson, Wikidata-bugs, aude, Lydia_Pintscher, Tpt
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T243158: Item has label conflict with itself

[gerritbot]

gerritbot added a comment.


  Change 568490 had a related patch set uploaded (by Ladsgroup; owner: 
Ladsgroup):
  [mediawiki/extensions/WikibaseLexeme@master] Throw right exception when 
trying to apply change on non-existent subentity
  
  https://gerrit.wikimedia.org/r/568490

TASK DETAIL
  https://phabricator.wikimedia.org/T243158

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Addshore, Ladsgroup, Aklapper, Liuxinyu970226, Mbch331, Un1tY, Ironie, 
Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, 
darthmon_wmde, alaa_wmde, Jaygray0919, AramBakir, Meekrab2012, joker88john, 
CucyNoiD, Nandana, NebulousIris, Arch2all, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, dmaza, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, DFelten, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, HakanIST, _jensen, rosalieper, Hannolans, Scott_WUaS, Jonas, 
Samwilson, Wikidata-bugs, aude, Lydia_Pintscher, Tpt
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T243158: Item has label conflict with itself

[gerritbot]

gerritbot added a comment.


  Change 568066 had a related patch set uploaded (by Ladsgroup; owner: 
Ladsgroup):
  [mediawiki/extensions/Wikibase@master] Validate ChangeOp against the current 
entity instead of an empty one
  
  https://gerrit.wikimedia.org/r/568066

TASK DETAIL
  https://phabricator.wikimedia.org/T243158

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Addshore, Ladsgroup, Aklapper, Liuxinyu970226, Mbch331, Ironie, Iflorez, 
darthmon_wmde, alaa_wmde, Jaygray0919, Nandana, Arch2all, Lahi, Gq86, dmaza, 
GoranSMilovanovic, DFelten, QZanden, LawExplorer, HakanIST, _jensen, 
rosalieper, Hannolans, Scott_WUaS, Jonas, Samwilson, Wikidata-bugs, aude, 
Lydia_Pintscher, Tpt
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T243158: Item has label conflict with itself

[Ladsgroup]

Ladsgroup added a comment.


  Actually I have an idea that might not be too complicated to write, it's 
basically diffing and patching. Are you working on it already @Addshore ?

TASK DETAIL
  https://phabricator.wikimedia.org/T243158

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore, Ladsgroup
Cc: Addshore, Ladsgroup, Aklapper, Liuxinyu970226, Mbch331, Ironie, Iflorez, 
darthmon_wmde, alaa_wmde, Jaygray0919, Nandana, Arch2all, Lahi, Gq86, dmaza, 
GoranSMilovanovic, DFelten, QZanden, LawExplorer, HakanIST, _jensen, 
rosalieper, Hannolans, Scott_WUaS, Jonas, Samwilson, Wikidata-bugs, aude, 
Lydia_Pintscher, Tpt
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T243158: Item has label conflict with itself

[Mbch331]

Mbch331 added a comment.


  I submitted https://github.com/addwiki/wikibase-api/pull/57 to remove the 
clear parameter from addwiki/wikibase-api/src/Api/Service/RevisionSaver.php as 
it isn't needed to remove a statement.
  
  Sending diffs is better, but requires more work in the code, which I'll leave 
to others.

TASK DETAIL
  https://phabricator.wikimedia.org/T243158

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mbch331
Cc: Addshore, Ladsgroup, Aklapper, Liuxinyu970226, Mbch331, Ironie, Iflorez, 
darthmon_wmde, alaa_wmde, Jaygray0919, Nandana, Arch2all, Lahi, Gq86, dmaza, 
GoranSMilovanovic, DFelten, QZanden, LawExplorer, HakanIST, _jensen, 
rosalieper, Hannolans, Scott_WUaS, Jonas, Samwilson, Wikidata-bugs, aude, 
Lydia_Pintscher, Tpt
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T243158: Item has label conflict with itself

[Mbch331]

Mbch331 added a comment.


  For the addwiki part talk to @Addshore he's the maintainer of the addwiki code

TASK DETAIL
  https://phabricator.wikimedia.org/T243158

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mbch331
Cc: Addshore, Ladsgroup, Aklapper, Liuxinyu970226, Mbch331, Ironie, Iflorez, 
darthmon_wmde, alaa_wmde, Jaygray0919, Nandana, Arch2all, Lahi, Gq86, dmaza, 
GoranSMilovanovic, DFelten, QZanden, LawExplorer, HakanIST, _jensen, 
rosalieper, Hannolans, Scott_WUaS, Jonas, Samwilson, Wikidata-bugs, aude, 
Lydia_Pintscher, Tpt
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T243158: Item has label conflict with itself

[Ladsgroup]

Ladsgroup added a comment.


  I think it needs slight more work than that. The current problem can be 
solved in several layers, we should fix it on our side as well but I really 
appreciate if addWiki don't send the whole entity, just diffs what's added and 
removed.

TASK DETAIL
  https://phabricator.wikimedia.org/T243158

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Addshore, Ladsgroup, Aklapper, Liuxinyu970226, Mbch331, Ironie, Iflorez, 
darthmon_wmde, alaa_wmde, Jaygray0919, Nandana, Arch2all, Lahi, Gq86, dmaza, 
GoranSMilovanovic, DFelten, QZanden, LawExplorer, HakanIST, _jensen, 
rosalieper, Hannolans, Scott_WUaS, Jonas, Samwilson, Wikidata-bugs, aude, 
Lydia_Pintscher, Tpt
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T243158: Item has label conflict with itself

[Mbch331]

Mbch331 added a comment.


  Found the culprit in 
vendor/addwiki/wikibase-api/src/Api/Service/RevisionSaver.php :
  // Always clear so that removing elements is possible
  
$params['clear'] = 'true';
  
  And I can't override it in my code, so the solution has to come from the 
addwiki/wikibase-api package.

TASK DETAIL
  https://phabricator.wikimedia.org/T243158

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mbch331
Cc: Addshore, Ladsgroup, Aklapper, Liuxinyu970226, Mbch331, Ironie, Iflorez, 
darthmon_wmde, alaa_wmde, Jaygray0919, Nandana, Arch2all, Lahi, Gq86, dmaza, 
GoranSMilovanovic, DFelten, QZanden, LawExplorer, HakanIST, _jensen, 
rosalieper, Hannolans, Scott_WUaS, Jonas, Samwilson, Wikidata-bugs, aude, 
Lydia_Pintscher, Tpt
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T243158: Item has label conflict with itself

[Mbch331]

Mbch331 added a comment.


  In T243158#5819801 , 
@Ladsgroup wrote:
  
  > Okay I found out what's wrong, it's the "clear" option. It messes with 
perception of ChangeOpResult, because it think it added everything again. This 
is causing all sorts of problem like edit summaries like this: 
https://www.wikidata.org/w/index.php?title=Q81715970=prev=1096133130 
The API request with "clear" true errors out but works just fine if you remove 
the clear option.
  
  Then I need to dig in the Addwiki package to find out how to disable the 
clear. Because it gets added there.

TASK DETAIL
  https://phabricator.wikimedia.org/T243158

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mbch331
Cc: Addshore, Ladsgroup, Aklapper, Liuxinyu970226, Mbch331, Ironie, Iflorez, 
darthmon_wmde, alaa_wmde, Jaygray0919, Nandana, Arch2all, Lahi, Gq86, dmaza, 
GoranSMilovanovic, DFelten, QZanden, LawExplorer, HakanIST, _jensen, 
rosalieper, Hannolans, Scott_WUaS, Jonas, Samwilson, Wikidata-bugs, aude, 
Lydia_Pintscher, Tpt
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T243158: Item has label conflict with itself

[Ladsgroup]

Ladsgroup added a comment.


  Okay I found out what's wrong, it's the "clear" option. It messes with 
perception of ChangeOpResult, because it think it added everything again. This 
is causing all sorts of problem like edit summaries like this: 
https://www.wikidata.org/w/index.php?title=Q81715970=prev=1096133130 
The API request with "clear" true errors out but works just fine if you remove 
the clear option.

TASK DETAIL
  https://phabricator.wikimedia.org/T243158

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Addshore, Ladsgroup, Aklapper, Liuxinyu970226, Mbch331, Ironie, Iflorez, 
darthmon_wmde, alaa_wmde, Jaygray0919, Nandana, Arch2all, Lahi, Gq86, dmaza, 
GoranSMilovanovic, DFelten, QZanden, LawExplorer, HakanIST, _jensen, 
rosalieper, Hannolans, Scott_WUaS, Jonas, Samwilson, Wikidata-bugs, aude, 
Lydia_Pintscher, Tpt
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T243158: Item has label conflict with itself

[Ladsgroup]

Ladsgroup added a comment.


  Looking at the history 
, I think I 
know what's going on here. Frontend and API usually send baserevid and that 
determines what's going to change on the item, if it thinks that it's going to 
change the label, it's going to try to make sure it doesn't violate the 
uniqueness constraint, I suggested back then to make sure you remove 
self-conflict errors for this exact reason, we never know if it would make its 
way to conflict check or not. First, let me reproduce it and then apply a fix.

TASK DETAIL
  https://phabricator.wikimedia.org/T243158

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Addshore, Ladsgroup, Aklapper, Liuxinyu970226, Mbch331, Ironie, Iflorez, 
darthmon_wmde, alaa_wmde, Jaygray0919, Nandana, Arch2all, Lahi, Gq86, dmaza, 
GoranSMilovanovic, DFelten, QZanden, LawExplorer, HakanIST, _jensen, 
rosalieper, Hannolans, Scott_WUaS, Jonas, Samwilson, Wikidata-bugs, aude, 
Lydia_Pintscher, Tpt
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T243158: Item has label conflict with itself

[Ladsgroup]

Ladsgroup added a comment.


  Can you give us more detail on what was the original API call?

TASK DETAIL
  https://phabricator.wikimedia.org/T243158

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Ladsgroup, Aklapper, Liuxinyu970226, Mbch331, Ironie, darthmon_wmde, 
Jaygray0919, Nandana, Arch2all, Lahi, Gq86, dmaza, GoranSMilovanovic, DFelten, 
QZanden, LawExplorer, HakanIST, _jensen, rosalieper, Hannolans, Scott_WUaS, 
Samwilson, Wikidata-bugs, aude, Tpt, Addshore
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs