[Wikidata-bugs] [Maniphest] [Commented On] T243729: Check Wikibase services for expensive setup patterns (db & api calls etc) & fix / remove
gerritbot added a comment. Change 572664 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Make sure WikibaseServices services getters don't access the DB https://gerrit.wikimedia.org/r/572664 TASK DETAIL https://phabricator.wikimedia.org/T243729 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo, gerritbot Cc: Ladsgroup, Michael, WMDE-leszek, Bawolff, Addshore, Aklapper, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, alaa_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T243729: Check Wikibase services for expensive setup patterns (db & api calls etc) & fix / remove
gerritbot added a comment. Change 572664 had a related patch set uploaded (by Hoo man; owner: Hoo man): [mediawiki/extensions/Wikibase@master] Make sure WikibaseServices services getters don't access the DB https://gerrit.wikimedia.org/r/572664 TASK DETAIL https://phabricator.wikimedia.org/T243729 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo, gerritbot Cc: Ladsgroup, Michael, WMDE-leszek, Bawolff, Addshore, Aklapper, Iflorez, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T243729: Check Wikibase services for expensive setup patterns (db & api calls etc) & fix / remove
hoo added a comment. We now have fairly conclusive test coverage of this (covers all from-global-state-factory methods I could find), so I think we can consider this done. TASK DETAIL https://phabricator.wikimedia.org/T243729 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Ladsgroup, Michael, WMDE-leszek, Bawolff, Addshore, Aklapper, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, alaa_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T243729: Check Wikibase services for expensive setup patterns (db & api calls etc) & fix / remove
gerritbot added a comment. Change 571474 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Test that factory methods don't access the DB/ do http requests https://gerrit.wikimedia.org/r/571474 TASK DETAIL https://phabricator.wikimedia.org/T243729 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo, gerritbot Cc: Ladsgroup, Michael, WMDE-leszek, Bawolff, Addshore, Aklapper, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, alaa_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T243729: Check Wikibase services for expensive setup patterns (db & api calls etc) & fix / remove
gerritbot added a comment. Change 571474 had a related patch set uploaded (by Hoo man; owner: Hoo man): [mediawiki/extensions/Wikibase@master] Test that factory methods don't access the DB/ do http requests https://gerrit.wikimedia.org/r/571474 TASK DETAIL https://phabricator.wikimedia.org/T243729 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo, gerritbot Cc: Ladsgroup, Michael, WMDE-leszek, Bawolff, Addshore, Aklapper, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, alaa_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T243729: Check Wikibase services for expensive setup patterns (db & api calls etc) & fix / remove
gerritbot added a comment. Change 571318 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Assert service getters never access the DB/ do http requests https://gerrit.wikimedia.org/r/571318 TASK DETAIL https://phabricator.wikimedia.org/T243729 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo, gerritbot Cc: Ladsgroup, Michael, WMDE-leszek, Bawolff, Addshore, Aklapper, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, alaa_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T243729: Check Wikibase services for expensive setup patterns (db & api calls etc) & fix / remove
gerritbot added a comment. Change 571318 had a related patch set uploaded (by Hoo man; owner: Hoo man): [mediawiki/extensions/Wikibase@master] Assert service getters never access the DB/ do http requests https://gerrit.wikimedia.org/r/571318 TASK DETAIL https://phabricator.wikimedia.org/T243729 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo, gerritbot Cc: Ladsgroup, Michael, WMDE-leszek, Bawolff, Addshore, Aklapper, Iflorez, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T243729: Check Wikibase services for expensive setup patterns (db & api calls etc) & fix / remove
Addshore added a comment. So this taks still needs to look for the same pattern of service construction where one of the things injected into the service ends up doing dB calls or API calls (what was happening with the language fallback chain issue). Less of a profiling thing and more of a looking by eye thing. Might be able to do something clever actually where a test replaces the db layer and http call later and calls all of the wikibase repo getters, making sure no http or SQL calls are done. TASK DETAIL https://phabricator.wikimedia.org/T243729 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Ladsgroup, Michael, WMDE-leszek, Bawolff, Addshore, Aklapper, Iflorez, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
