[Wikidata-bugs] [Maniphest] [Commented On] T245422: Update vue cli

2020-03-03 Thread gerritbot 
gerritbot added a comment.


  Change 572692 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] bridge: remove vue cli from Dockerfile
  
  https://gerrit.wikimedia.org/r/572692

TASK DETAIL
  https://phabricator.wikimedia.org/T245422

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Tonina_Zhelyazkova_WMDE, Michael, Lucas_Werkmeister_WMDE, 
Pablo-WMDE, Beast1978, Un1tY, Sarai-WMDE, Hook696, Daryl-TTMG, RomaAmorRoma, 
E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T245422: Update vue cli

2020-02-17 Thread gerritbot 
gerritbot added a comment.


  Change 572692 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
owner: Lucas Werkmeister (WMDE)):
  [mediawiki/extensions/Wikibase@master] bridge: remove vue cli from Dockerfile
  
  https://gerrit.wikimedia.org/r/572692

TASK DETAIL
  https://phabricator.wikimedia.org/T245422

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Tonina_Zhelyazkova_WMDE, Michael, Lucas_Werkmeister_WMDE, 
Pablo-WMDE, Sarai-WMDE, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T245422: Update vue cli

2020-02-17 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  Okay, as far as I can tell we don’t need it at all – we use `npm run build` 
instead of `vue build`, `npm run serve` instead of `vue serve`, and so on. If I 
understand correctly, it can be useful to have vue cli globally installed in 
general, but it doesn’t really belong in this Dockerfile, I think.

TASK DETAIL
  https://phabricator.wikimedia.org/T245422

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Tonina_Zhelyazkova_WMDE, Michael, Lucas_Werkmeister_WMDE, 
Pablo-WMDE, Sarai-WMDE, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T245422: Update vue cli

2020-02-17 Thread Pablo-WMDE 
Pablo-WMDE added a comment.


  > Wait, why do we install vue cli in the dockerfile
  
  It allows the global (`-g`) installation of packages resulting in a binary in 
path.
  This allows for usage as document 
 and maybe known to/expected by 
vue devs.
  
  That said: I'm not sure any one of us actually uses it in their workflow.

TASK DETAIL
  https://phabricator.wikimedia.org/T245422

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: Aklapper, Tonina_Zhelyazkova_WMDE, Michael, Lucas_Werkmeister_WMDE, 
Pablo-WMDE, Sarai-WMDE, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T245422: Update vue cli

2020-02-17 Thread Pablo-WMDE 
Pablo-WMDE added a comment.


  I'm sorry for having put this in "Task overflow" (apparently) - that was not 
my intention.
  Meant "tech things".

TASK DETAIL
  https://phabricator.wikimedia.org/T245422

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: Aklapper, Tonina_Zhelyazkova_WMDE, Michael, Lucas_Werkmeister_WMDE, 
Pablo-WMDE, Sarai-WMDE, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T245422: Update vue cli

2020-02-17 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  Wait, why do we install vue cli in the dockerfile? And what does that even 
do? Because I don’t use the dockerfile, and apparently I’m still able to run 
tests and produce builds that pass the `distnodiff` check in CI.

TASK DETAIL
  https://phabricator.wikimedia.org/T245422

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Tonina_Zhelyazkova_WMDE, Michael, Lucas_Werkmeister_WMDE, 
Pablo-WMDE, Sarai-WMDE, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs