[Wikidata-bugs] [Maniphest] [Commented On] T246227: Add small version of close/cancel button

[gerritbot]

gerritbot added a comment.


  Change 577609 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] bridge: add size M for icon-only 
EventEmittingButton
  
  https://gerrit.wikimedia.org/r/577609

TASK DETAIL
  https://phabricator.wikimedia.org/T246227

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Charlie_WMDE, Aklapper, Lucas_Werkmeister_WMDE, Alter-paule, Beast1978, 
Un1tY, Sarai-WMDE, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, 
darthmon_wmde, Meekrab2012, joker88john, Michael, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T246227: Add small version of close/cancel button

[gerritbot]

gerritbot added a comment.


  Change 577609 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
owner: Lucas Werkmeister (WMDE)):
  [mediawiki/extensions/Wikibase@master] bridge: add size M for icon-only 
EventEmittingButton
  
  https://gerrit.wikimedia.org/r/577609

TASK DETAIL
  https://phabricator.wikimedia.org/T246227

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Charlie_WMDE, Aklapper, Lucas_Werkmeister_WMDE, Sarai-WMDE, darthmon_wmde, 
Michael, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T246227: Add small version of close/cancel button

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  > the close icon itself is currently 14×14 in all sizes in the app
  
  (Side note: the computed `background-size` is 20px, but the image itself 
contains some padding. I got the 14px by zooming in and using the “measure a 
portion of the page” tool.)
  
  F31668410: Screenshot from 2020-03-06 17-23-51.png 


TASK DETAIL
  https://phabricator.wikimedia.org/T246227

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Charlie_WMDE, Aklapper, Lucas_Werkmeister_WMDE, Sarai-WMDE, darthmon_wmde, 
Michael, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T246227: Add small version of close/cancel button

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  “Small” here means “size M”, i. e. 32px high just like the ordinary size-M 
EventEmittingButton. See Bridge Figma 

 and WiKit Figma 
.

TASK DETAIL
  https://phabricator.wikimedia.org/T246227

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Lucas_Werkmeister_WMDE, Sarai-WMDE, darthmon_wmde, Michael, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs