subject:"\[Wikidata\-bugs\] \[Maniphest\] \[Commented On\] T246231\: Browser tests for license modal"

[Wikidata-bugs] [Maniphest] [Commented On] T246231: Browser tests for license modal

2020-03-16 Thread gerritbot

gerritbot added a comment.


  Change 580071 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] bridge: Add test for license closing 
behavior
  
  https://gerrit.wikimedia.org/r/580071

TASK DETAIL
  https://phabricator.wikimedia.org/T246231

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, gerritbot
Cc: Lucas_Werkmeister_WMDE, Aklapper, Alter-paule, Beast1978, Un1tY, 
Sarai-WMDE, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, 
Meekrab2012, joker88john, Michael, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T246231: Browser tests for license modal

2020-03-16 Thread Michael

Michael added a comment.


  I added an extra e2e test, there the trade-offs might be worth it more 

TASK DETAIL
  https://phabricator.wikimedia.org/T246231

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Aklapper, Alter-paule, Beast1978, Un1tY, 
Sarai-WMDE, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, 
Meekrab2012, joker88john, Michael, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T246231: Browser tests for license modal

2020-03-16 Thread gerritbot

gerritbot added a comment.


  Change 580071 had a related patch set uploaded (by Michael Große; owner: 
Michael Große):
  [mediawiki/extensions/Wikibase@master] bridge: Add test for license closing 
behavior
  
  https://gerrit.wikimedia.org/r/580071

TASK DETAIL
  https://phabricator.wikimedia.org/T246231

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, gerritbot
Cc: Lucas_Werkmeister_WMDE, Aklapper, Sarai-WMDE, darthmon_wmde, Michael, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T246231: Browser tests for license modal

2020-03-16 Thread Lucas_Werkmeister_WMDE

Lucas_Werkmeister_WMDE added a comment.


  I’m not sure what the test would look like – it could just click the save 
button once, or click that and then cancel the license popup, or do that but 
then click the save button again (but then still leave the license popup open 
without saving again)…
  
  And as I said I’m not sure if this is worth it at all. We already have more 
detailed non-browser tests for this, after all.

TASK DETAIL
  https://phabricator.wikimedia.org/T246231

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Sarai-WMDE, darthmon_wmde, Michael, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T246231: Browser tests for license modal

2020-03-16 Thread Michael

Michael added a comment.


  In T246231#5972015 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > I was thinking that a test for no change being saved when you don’t 
acknowledge the license popup could be added, but I’m not sure if that’s worth 
it.
  
  So a separate test instead or in addition to clicking the cancel button in 
one of the tests: 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/579581/12/client/data-bridge/tests/selenium/specs/canSave.js
 ?

TASK DETAIL
  https://phabricator.wikimedia.org/T246231

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Aklapper, Sarai-WMDE, darthmon_wmde, Michael, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T246231: Browser tests for license modal

2020-03-16 Thread Lucas_Werkmeister_WMDE

Lucas_Werkmeister_WMDE added a comment.


  I was thinking that a test for no change being saved when you don’t 
acknowledge the license popup could be added, but I’m not sure if that’s worth 
it.

TASK DETAIL
  https://phabricator.wikimedia.org/T246231

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Alter-paule, Beast1978, Un1tY, 
Sarai-WMDE, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, 
Meekrab2012, joker88john, Michael, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T246231: Browser tests for license modal

2020-03-16 Thread Michael

Michael added a comment.


  I consider this implemented, but please have a look and let me know if there 
should be more testing done for this.

TASK DETAIL
  https://phabricator.wikimedia.org/T246231

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Aklapper, Alter-paule, Beast1978, Un1tY, 
Sarai-WMDE, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, 
Meekrab2012, joker88john, Michael, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T246231: Browser tests for license modal

2020-03-16 Thread gerritbot

gerritbot added a comment.


  Change 579581 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] bridge: Wire up License
  
  https://gerrit.wikimedia.org/r/579581

TASK DETAIL
  https://phabricator.wikimedia.org/T246231

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, gerritbot
Cc: Lucas_Werkmeister_WMDE, Aklapper, Alter-paule, Beast1978, Un1tY, 
Sarai-WMDE, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, 
Meekrab2012, joker88john, Michael, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T246231: Browser tests for license modal

2020-03-16 Thread gerritbot

gerritbot added a comment.


  Change 579581 had a related patch set uploaded (by Michael Große; owner: 
Michael Große):
  [mediawiki/extensions/Wikibase@master] bridge: Wire up License
  
  https://gerrit.wikimedia.org/r/579581

TASK DETAIL
  https://phabricator.wikimedia.org/T246231

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lucas_Werkmeister_WMDE, Aklapper, Sarai-WMDE, darthmon_wmde, Michael, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T246231: Browser tests for license modal

[Wikidata-bugs] [Maniphest] [Commented On] T246231: Browser tests for license modal

[Wikidata-bugs] [Maniphest] [Commented On] T246231: Browser tests for license modal

[Wikidata-bugs] [Maniphest] [Commented On] T246231: Browser tests for license modal

[Wikidata-bugs] [Maniphest] [Commented On] T246231: Browser tests for license modal

[Wikidata-bugs] [Maniphest] [Commented On] T246231: Browser tests for license modal

[Wikidata-bugs] [Maniphest] [Commented On] T246231: Browser tests for license modal

[Wikidata-bugs] [Maniphest] [Commented On] T246231: Browser tests for license modal

[Wikidata-bugs] [Maniphest] [Commented On] T246231: Browser tests for license modal

9 matches

Site Navigation

Mail list logo

Footer information