[Wikidata-bugs] [Maniphest] [Commented On] T246676: Step 1: anonymous edit warning (impact: high)

[gerritbot]

gerritbot added a comment.


  Change 595902 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] bridge: Remove erroneous margin from 
anon warning message
  
  https://gerrit.wikimedia.org/r/595902

TASK DETAIL
  https://phabricator.wikimedia.org/T246676

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Michael, Lucas_Werkmeister_WMDE, Sarai-WMDE, Charlie_WMDE, Aklapper, 
Lydia_Pintscher, Blissjay007, Oblanco79, Alter-paule, Beast1978, Un1tY, 
Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Kent7301, 
Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T246676: Step 1: anonymous edit warning (impact: high)

[gerritbot]

gerritbot added a comment.


  Change 595902 had a related patch set uploaded (by Michael Große; owner: 
Michael Große):
  [mediawiki/extensions/Wikibase@master] bridge: Remove erroneous margin from 
anon warning message
  
  https://gerrit.wikimedia.org/r/595902

TASK DETAIL
  https://phabricator.wikimedia.org/T246676

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Michael, Lucas_Werkmeister_WMDE, Sarai-WMDE, Charlie_WMDE, Aklapper, 
Lydia_Pintscher, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T246676: Step 1: anonymous edit warning (impact: high)

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Okay, then I think that’s what my current changes already do. Thanks!

TASK DETAIL
  https://phabricator.wikimedia.org/T246676

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Sarai-WMDE, Charlie_WMDE, Aklapper, 
Lydia_Pintscher, darthmon_wmde, Michael, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T246676: Step 1: anonymous edit warning (impact: high)

[Charlie_WMDE]

Charlie_WMDE added a comment.


  okay, that is indeed unfortunate. I would still keep this order then
  
  1. warning
  2. error
  3. bridge
  
  loading screen where necessary but none of the screens above should be 
"interrupted" by any other screen (including the loading screen)

TASK DETAIL
  https://phabricator.wikimedia.org/T246676

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Charlie_WMDE
Cc: Lucas_Werkmeister_WMDE, Sarai-WMDE, Charlie_WMDE, Aklapper, 
Lydia_Pintscher, darthmon_wmde, Michael, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T246676: Step 1: anonymous edit warning (impact: high)

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  > ideally the error would be shown before anything else. that should be 
possible for repo protection etc, no?
  
  No, unfortunately. We only know if the page is protected on the repo after 
making an API request, which takes a while. On the other hand, we know if this 
warning should be shown or not as soon as the bridge is opened, without further 
delay. There //might// be some error that can also happen immediately (I can’t 
think of one at the moment), but in general, the warning is going to happen 
before an error, unless we delay the warning (but you already said the warning 
should take precedence over the loading screen).

TASK DETAIL
  https://phabricator.wikimedia.org/T246676

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Sarai-WMDE, Charlie_WMDE, Aklapper, 
Lydia_Pintscher, darthmon_wmde, Michael, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T246676: Step 1: anonymous edit warning (impact: high)

[Charlie_WMDE]

Charlie_WMDE added a comment.


  hey @Lucas_Werkmeister_WMDE those are all very good questions.
  
  warning should take precedence over the loading screen = yes
  loading still happens in the background = yes
  what's more important, the warning or the error = the error
  
  which brings me to the last question
  
  what happens when there's an error? ideally the error would be shown before 
anything else. that should be possible for repo protection etc, no? for server 
problems maybe not? but in that case it's fine to show the warning, then i 
guess the loading in the background would have failed anyway, and then we'd see 
the server error. once the warning screen (or any screen except for the loading 
screen) is shown in general, we should leave it until the moment the user 
interacts with it. so if they see an error, then until they fix it or dismiss 
it, the warning isn't shown. same goes the other way round. if we show the 
warning, we don't "interrupt" the screen by showing the error when it's ready.
  
  hope this is helpful

TASK DETAIL
  https://phabricator.wikimedia.org/T246676

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Charlie_WMDE
Cc: Lucas_Werkmeister_WMDE, Sarai-WMDE, Charlie_WMDE, Aklapper, 
Lydia_Pintscher, darthmon_wmde, Michael, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T246676: Step 1: anonymous edit warning (impact: high)

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  I assume the warning should take precedence over the loading screen, but the 
loading should still happen in the background. What happens, then, if there is 
an error (e. g. page protected on repo) while loading, before the user has 
dismissed the warning? What’s more important, the warning or the error? Do we 
leave the warning on the screen until the user has dismissed it, or replace it 
with an error as soon as the error happens?

TASK DETAIL
  https://phabricator.wikimedia.org/T246676

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Sarai-WMDE, Charlie_WMDE, Aklapper, 
Lydia_Pintscher, darthmon_wmde, Michael, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T246676: Step 1: anonymous edit warning (impact: high)

[Sarai-WMDE]

Sarai-WMDE added a comment.


  For the record, I made some suggested copy changes in the mocks (will only 
update them in case the new copy is agreed upon).
  
  F31699989: Warning_IP_Edit.png 
  
  What changed:
  
  - The primary button label now says "Edit as IP user" rather than "Edit 
without logging in". Although the latest is the common copy used in the WP 
environment, I believe the proposed copy could be more communicative of the 
actual compromise (reduced anonymity) that users are making.
  
  Let's discuss this soon.

TASK DETAIL
  https://phabricator.wikimedia.org/T246676

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Sarai-WMDE, Charlie_WMDE, Aklapper, Lydia_Pintscher, darthmon_wmde, 
Michael, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs