[Wikidata-bugs] [Maniphest] [Commented On] T254525: Don't use internal FallbackTemplate inside code
gerritbot added a comment. Change 602772 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Don't use FallbackTemplate inside tests https://gerrit.wikimedia.org/r/602772 TASK DETAIL https://phabricator.wikimedia.org/T254525 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Krinkle, Aklapper, Jdlrobson, Blissjay007, CostasAthan, Oblanco79, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Kent7301, Gsklayploy, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Dinoguy1000, Florian, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T254525: Don't use internal FallbackTemplate inside code
Jdlrobson added a comment. CookieWarning is not deployed anywhere on Wikimedia from what I can see so I don't think that should block the core change. TASK DETAIL https://phabricator.wikimedia.org/T254525 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Krinkle, Aklapper, Jdlrobson, Blissjay007, CostasAthan, Oblanco79, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Kent7301, Gsklayploy, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Dinoguy1000, Florian, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T254525: Don't use internal FallbackTemplate inside code
gerritbot added a comment. Change 602772 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson): [mediawiki/extensions/Wikibase@master] Don't use FallbackTemplate inside tests https://gerrit.wikimedia.org/r/602772 TASK DETAIL https://phabricator.wikimedia.org/T254525 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Krinkle, Aklapper, Jdlrobson, CostasAthan, darthmon_wmde, Gsklayploy, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Dinoguy1000, Florian, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T254525: Don't use internal FallbackTemplate inside code
Krinkle added a comment. They were likely picked because BaseTemplate is abstract so SkinFallbackTemplate was the only somewhat neutral non-abstract implementation in core to pick. Should straight-forward to replace by direct use of BaseTemplate with `createMock()`. TASK DETAIL https://phabricator.wikimedia.org/T254525 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Aklapper, Jdlrobson, CostasAthan, darthmon_wmde, Gsklayploy, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Florian, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
