[Wikidata-bugs] [Maniphest] [Commented On] T255883: Don’t reference WikibaseRepo EntityContent class in WikibaseLib’s EntityChange

2020-06-23 Thread gerritbot 
gerritbot added a comment.


  Change 605837 abandoned by Lucas Werkmeister (WMDE):
  Move EntityContent access out of EntityChange
  
  Reason:
  superseded by I08ea10a8a4
  
  https://gerrit.wikimedia.org/r/605837

TASK DETAIL
  https://phabricator.wikimedia.org/T255883

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Addshore, Aklapper, Lucas_Werkmeister_WMDE, Alter-paule, Beast1978, Un1tY, 
Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T255883: Don’t reference WikibaseRepo EntityContent class in WikibaseLib’s EntityChange

2020-06-23 Thread gerritbot 
gerritbot added a comment.


  Change 607019 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Don’t access content in 
EntityChange::setRevisionInfo
  
  https://gerrit.wikimedia.org/r/607019

TASK DETAIL
  https://phabricator.wikimedia.org/T255883

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Addshore, Aklapper, Lucas_Werkmeister_WMDE, Alter-paule, Beast1978, Un1tY, 
Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T255883: Don’t reference WikibaseRepo EntityContent class in WikibaseLib’s EntityChange

2020-06-22 Thread gerritbot 
gerritbot added a comment.


  Change 607019 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
owner: Lucas Werkmeister (WMDE)):
  [mediawiki/extensions/Wikibase@master] Don’t access content in 
EntityChange::setRevisionInfo
  
  https://gerrit.wikimedia.org/r/607019

TASK DETAIL
  https://phabricator.wikimedia.org/T255883

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Addshore, Aklapper, Lucas_Werkmeister_WMDE, Blissjay007, Oblanco79, 
Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, 
darthmon_wmde, Kent7301, Meekrab2012, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T255883: Don’t reference WikibaseRepo EntityContent class in WikibaseLib’s EntityChange

2020-06-20 Thread Addshore 
Addshore added a comment.


  Just an interesting note here that might impact what is being done.
  Content objects, and thus EntityContent objects, are important for ENtity 
retrieval, and thus should perhaps be alongside whatever code is needed for 
data retrieval withing Wikibase (Of course this depends on how the client repo 
dependency continues to evolve.
  To get content of an entity you start with a revision, which has slots, which 
have content.
  
  It appears that our current legacy code goes around this, but any sort of new 
entity lookup based on the new services in core would likely need content to be 
accessible for clients that do direct DB access.
  (prototype example at 
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/605333/)

TASK DETAIL
  https://phabricator.wikimedia.org/T255883

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Addshore
Cc: Addshore, Aklapper, Lucas_Werkmeister_WMDE, Blissjay007, Oblanco79, 
Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, 
darthmon_wmde, Kent7301, Meekrab2012, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T255883: Don’t reference WikibaseRepo EntityContent class in WikibaseLib’s EntityChange

2020-06-19 Thread gerritbot 
gerritbot added a comment.


  Change 605837 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
owner: Lucas Werkmeister (WMDE)):
  [mediawiki/extensions/Wikibase@master] Move EntityContent access out of 
EntityChange
  
  https://gerrit.wikimedia.org/r/605837

TASK DETAIL
  https://phabricator.wikimedia.org/T255883

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Aklapper, Lucas_Werkmeister_WMDE, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs