[Wikidata-bugs] [Maniphest] [Commented On] T256021: Import WMF truth as nested JSON

[Pablo-WMDE]

Pablo-WMDE added a comment.


  We reached the conclusion that we can best build a system if we only let in 
outside //values//, but not entire tokens (i.e. incl the key). Consequently, 
there is no requirement for the imported token to follow a structure, we can 
use them in the shallow way we get them. Updated our feature branch 
 to do that.

TASK DETAIL
  https://phabricator.wikimedia.org/T256021

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: Aklapper, Pablo-WMDE, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T256021: Import WMF truth as nested JSON

[Pablo-WMDE]

Pablo-WMDE added a comment.


  Upon closer inspection I now realize that the problem of "concrete values and 
child nodes on the same level" is insurmountable for style-dictionary, too. Its 
CTI structure  
does not allow for that. Values which are specified "below" (in the hierarchy) 
another concrete value do not make it to the output file(s). 
`@background-color-base--hover`, for example, is not part of the output in our 
current  way of 
mangling keys.

TASK DETAIL
  https://phabricator.wikimedia.org/T256021

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: Aklapper, Pablo-WMDE, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T256021: Import WMF truth as nested JSON

[Pablo-WMDE]

Pablo-WMDE added a comment.


  Looked into https://www.npmjs.com/package/flat 's `unflatten()`  but that 
struggles with concrete values and child nodes on the same level, e.g. 
`@background-color-base` vs `@background-color-base--hover`. Ironically this 
seems to coincide quite a bit with the double dash notation which is a 
challenge in itself.

TASK DETAIL
  https://phabricator.wikimedia.org/T256021

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: Aklapper, Pablo-WMDE, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs