[Wikidata-bugs] [Maniphest] [Commented On] T256855: Create visalization for line height

[Tonina_Zhelyazkova_WMDE]

Tonina_Zhelyazkova_WMDE added a comment.


  In T256855#6293409 , 
@Pablo-WMDE wrote:
  
  > @Sarai-WMDE
  >
  > I tried to incorporate the new decision into 
https://github.com/wmde/wikit/pull/60 - please verify visually.
  >
  > Also created https://github.com/wmde/wikit/pull/68 which shows the idea as 
discussed in the meeting, demoing each line height at 3 font sizes (the ones 
mentioned earlier ). Don't 
know if anyone needs that but had some time during a meeting which I had no 
business being in. Take a look at the storybook, please, and decide if this 
solves the problem you initially wanted to tackle.
  
  In light of https://github.com/wmde/wikit/pull/60 being merged and 
https://github.com/wmde/wikit/pull/68 receiving a comment by UX not approving 
of the proposal, I consider this task done and will move it to the appropriate 
column.

TASK DETAIL
  https://phabricator.wikimedia.org/T256855

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tonina_Zhelyazkova_WMDE
Cc: Pablo-WMDE, Aklapper, Sarai-WMDE, Jakob_WMDE, Tonina_Zhelyazkova_WMDE, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T256855: Create visalization for line height

[Pablo-WMDE]

Pablo-WMDE added a comment.


  @Sarai-WMDE
  
  I tried to incorporate the new decision into 
https://github.com/wmde/wikit/pull/60 - please verify visually.
  
  Also created https://github.com/wmde/wikit/pull/68 which shows the idea as 
discussed in the meeting, demoing each line height at 3 font sizes (the ones 
mentioned earlier ). Don't 
know if anyone needs that but had some time during a meeting which I had no 
business being in. Take a look at the storybook, please, and decide if this 
solves the problem you initially wanted to tackle.

TASK DETAIL
  https://phabricator.wikimedia.org/T256855

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tonina_Zhelyazkova_WMDE, Pablo-WMDE
Cc: Pablo-WMDE, Aklapper, Sarai-WMDE, Jakob_WMDE, Tonina_Zhelyazkova_WMDE, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T256855: Create visalization for line height

[Pablo-WMDE]

Pablo-WMDE added a comment.


  I wrote down what was said during a call of 3 people (= messenger). I don't 
know why the requirement was changed again despite the explanation (implying it 
was intentional).
  
  During that conversation it was also mentioned that a more useful way of 
illustrating the relationship between line height and font size could be to 
show them in a matrix (i.e. show [the same] set of multiple font sizes for each 
line height, instead of one arbitrary font size). This idea was not turned into 
a requirement, however.
  
  >> But since said block cannot be used, I'd agree that we can go back to 
using 16px: although imprecise.
  >
  > Bending requirements and making the implementation imprecise in favor of 
code consistency is fundamentally wrong.
  
  I largely agree. However, it was a designer, not a developer who wrote the 
original quote - and they make the requirements.

TASK DETAIL
  https://phabricator.wikimedia.org/T256855

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tonina_Zhelyazkova_WMDE, Pablo-WMDE
Cc: Pablo-WMDE, Aklapper, Sarai-WMDE, Jakob_WMDE, Tonina_Zhelyazkova_WMDE, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T256855: Create visalization for line height

[Tonina_Zhelyazkova_WMDE]

Tonina_Zhelyazkova_WMDE added a comment.


  In T256855#6292663 , 
@Pablo-WMDE wrote:
  
  > In a comment on the PR 

  >
  >> we can go back to using 16px:
  >
  > and again during a conversation after the daily, it was decided to use the 
same font size, 16px, to present all line heights.
  
  An explanation was provided why there are different font sizes, which answers 
your initial `why` @Pablo-WMDE 
  The comment from the PR with a context
  
  > But since said block cannot be used, I'd agree that we can go back to using 
16px: although imprecise.
  
  Bending requirements and making the implementation imprecise in favor of code 
consistency is fundamentally wrong.
  Not using Typeset block is not a problem. We have other presenters which do 
not come from Storybook's blocks as well.

TASK DETAIL
  https://phabricator.wikimedia.org/T256855

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tonina_Zhelyazkova_WMDE
Cc: Pablo-WMDE, Aklapper, Sarai-WMDE, Jakob_WMDE, Tonina_Zhelyazkova_WMDE, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T256855: Create visalization for line height

[Pablo-WMDE]

Pablo-WMDE added a comment.


  In a comment on the PR 

  
  > we can go back to using 16px:
  
  and again during a conversation after the daily, it was decided to use the 
same font size, 16px, to present all line heights.

TASK DETAIL
  https://phabricator.wikimedia.org/T256855

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tonina_Zhelyazkova_WMDE, Pablo-WMDE
Cc: Pablo-WMDE, Aklapper, Sarai-WMDE, Jakob_WMDE, Tonina_Zhelyazkova_WMDE, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T256855: Create visalization for line height

[Pablo-WMDE]

Pablo-WMDE added a comment.


  @Sarai-WMDE I have a question about
  
  > apply the following sizes to each specimen (none: 16px, 1.25: 18px, 1.5: 
16px, 1.6: 14px)
  
  We are changing the font //size// depending on the token value (line-height), 
thereby changing two variables at once and making it hard to grasp to impact of 
one or the other. Are we sure this is in the best interest of the user?
  
  Thanks

TASK DETAIL
  https://phabricator.wikimedia.org/T256855

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tonina_Zhelyazkova_WMDE, Pablo-WMDE
Cc: Pablo-WMDE, Aklapper, Sarai-WMDE, Jakob_WMDE, Tonina_Zhelyazkova_WMDE, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T256855: Create visalization for line height

[Sarai-WMDE]

Sarai-WMDE added a comment.


  Checked! Looks good. Ready to move to done.

TASK DETAIL
  https://phabricator.wikimedia.org/T256855

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tonina_Zhelyazkova_WMDE, Sarai-WMDE
Cc: Pablo-WMDE, Aklapper, Sarai-WMDE, Jakob_WMDE, Tonina_Zhelyazkova_WMDE, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T256855: Create visalization for line height

[Pablo-WMDE]

Pablo-WMDE added a comment.


  @Sarai-WMDE Kindly take a look at the storybook linked in the PR 
.

TASK DETAIL
  https://phabricator.wikimedia.org/T256855

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tonina_Zhelyazkova_WMDE, Pablo-WMDE
Cc: Pablo-WMDE, Aklapper, Sarai-WMDE, Jakob_WMDE, Tonina_Zhelyazkova_WMDE, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T256855: Create visalization for line height

[Tonina_Zhelyazkova_WMDE]

Tonina_Zhelyazkova_WMDE added a comment.


  In T256855#6277459 , 
@Sarai-WMDE wrote:
  
  > Leaving here a couple of improvements:
  >
  > 1. Make the font size of the value column 14px.
  > 2. It may make sense to use typeset here too (like in the rest of the font 
pages) rather than the blue background. If it does, then I would apply the 
following sizes to each specimen (none: 16px, 1.25: 18px, 1.5: 16px, 1.6: 14px)
  
  https://github.com/wmde/wikit/pull/60

TASK DETAIL
  https://phabricator.wikimedia.org/T256855

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tonina_Zhelyazkova_WMDE
Cc: Pablo-WMDE, Aklapper, Sarai-WMDE, Jakob_WMDE, Tonina_Zhelyazkova_WMDE, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T256855: Create visalization for line height

[Sarai-WMDE]

Sarai-WMDE added a comment.


  Leaving here a couple of improvements:
  
  1. Make the font size of the value column 14px.
  2. It may make sense to use typeset here too (like in the rest of the font 
pages) rather than the blue background. If it does, then I would apply the 
following sizes to each specimen (none: 16px, 1.25: 18px, 1.5: 16px, 1.6: 14px)

TASK DETAIL
  https://phabricator.wikimedia.org/T256855

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE, Sarai-WMDE
Cc: Pablo-WMDE, Aklapper, Sarai-WMDE, Jakob_WMDE, Tonina_Zhelyazkova_WMDE, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T256855: Create visalization for line height

[Pablo-WMDE]

Pablo-WMDE added a comment.


  @Sarai-WMDE 
https://wmde.github.io/wikit/?path=/docs/design-tokens-font-line-height--page

TASK DETAIL
  https://phabricator.wikimedia.org/T256855

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: Pablo-WMDE, Aklapper, Sarai-WMDE, Jakob_WMDE, Tonina_Zhelyazkova_WMDE, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T256855: Create visalization for line height

[Pablo-WMDE]

Pablo-WMDE added a comment.


  https://github.com/wmde/wikit/pull/46

TASK DETAIL
  https://phabricator.wikimedia.org/T256855

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: Pablo-WMDE, Aklapper, Sarai-WMDE, Jakob_WMDE, Tonina_Zhelyazkova_WMDE, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs