[Wikidata-bugs] [Maniphest] [Commented On] T87283: Wikidata dumps should have revision ID or other sequence mark
Lydia_Pintscher added a comment. \o/ TASK DETAIL https://phabricator.wikimedia.org/T87283 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Lydia_Pintscher, Pintoch, Addshore, Ivan_A_Krestinin, TorbenRahbekKoch, Ricordisamoa, Denis.bykov, Jimkont, Magnus, mkroetzsch, JanZerebecki, hoo, Aklapper, Smalyshev, darthmon_wmde, alaa_wmde, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T87283: Wikidata dumps should have revision ID or other sequence mark
Pintoch added a comment. Thanks all for your patience for this! Excited to see my first commit making it into Wikibase \o/ TASK DETAIL https://phabricator.wikimedia.org/T87283 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pintoch Cc: Lydia_Pintscher, Pintoch, Addshore, Ivan_A_Krestinin, TorbenRahbekKoch, Ricordisamoa, Denis.bykov, Jimkont, Magnus, mkroetzsch, JanZerebecki, hoo, Aklapper, Smalyshev, darthmon_wmde, alaa_wmde, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T87283: Wikidata dumps should have revision ID or other sequence mark
gerritbot added a comment. Change 500806 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] dumps: Add lastrevid to JSON entity dumps. https://gerrit.wikimedia.org/r/500806 TASK DETAIL https://phabricator.wikimedia.org/T87283 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Lydia_Pintscher, Pintoch, Addshore, Ivan_A_Krestinin, TorbenRahbekKoch, Ricordisamoa, Denis.bykov, Jimkont, Magnus, mkroetzsch, JanZerebecki, hoo, Aklapper, Smalyshev, darthmon_wmde, alaa_wmde, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T87283: Wikidata dumps should have revision ID or other sequence mark
Pintoch added a comment. Ok great! I'll move the field to the end and try to make Jenkins happy then. TASK DETAIL https://phabricator.wikimedia.org/T87283 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pintoch Cc: Lydia_Pintscher, Pintoch, Addshore, Ivan_A_Krestinin, TorbenRahbekKoch, Ricordisamoa, Denis.bykov, Jimkont, Magnus, mkroetzsch, JanZerebecki, hoo, Aklapper, Smalyshev, alaa_wmde, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T87283: Wikidata dumps should have revision ID or other sequence mark
Lydia_Pintscher added a comment. Thanks for working on this! :) Yeah this seems fine. I think keeping the naming consistent with the same field in Special:EntityData is good. Lucas and I also quickly talked about if this should go to the end or the beginning of the line and we're leaning to the end so the first thing you see is the entity id and type. But that's more a preference than a must. TASK DETAIL https://phabricator.wikimedia.org/T87283 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Lydia_Pintscher, Pintoch, Addshore, Ivan_A_Krestinin, TorbenRahbekKoch, Ricordisamoa, Denis.bykov, Jimkont, Magnus, mkroetzsch, JanZerebecki, hoo, Aklapper, Smalyshev, alaa_wmde, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T87283: Wikidata dumps should have revision ID or other sequence mark
Smalyshev added a comment. It's a 4 year old task, so I myself is not 100% clear which one it was back then. So I think having it here is fine. TASK DETAIL https://phabricator.wikimedia.org/T87283 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev Cc: Pintoch, Addshore, Ivan_A_Krestinin, TorbenRahbekKoch, Ricordisamoa, Denis.bykov, Jimkont, Magnus, mkroetzsch, JanZerebecki, daniel, hoo, Aklapper, Smalyshev, alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T87283: Wikidata dumps should have revision ID or other sequence mark
Pintoch added a comment. @Smalyshev okay! Sorry if this is not the right place: I would be happy to migrate the patch to another ticket. Indeed this only adds entity-level metadata, not dump-level metadata. I think this would be less of a breaking change, given that it does not require changing the dump structure (and of course it is more useful to me, haha!) TASK DETAIL https://phabricator.wikimedia.org/T87283 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pintoch Cc: Pintoch, Addshore, Ivan_A_Krestinin, TorbenRahbekKoch, Ricordisamoa, Denis.bykov, Jimkont, Magnus, mkroetzsch, JanZerebecki, daniel, hoo, Aklapper, Smalyshev, alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T87283: Wikidata dumps should have revision ID or other sequence mark
Smalyshev added a comment. OK it seems to be a bit unclear whether this was asking for revision IDs on particular entity or on the dump as a whole. I think that we need both, but the patch above seems to add the revision ID to entities. I think it makes sense. TASK DETAIL https://phabricator.wikimedia.org/T87283 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev Cc: Pintoch, Addshore, Ivan_A_Krestinin, TorbenRahbekKoch, Ricordisamoa, Denis.bykov, Jimkont, Magnus, mkroetzsch, JanZerebecki, daniel, hoo, Aklapper, Smalyshev, alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T87283: Wikidata dumps should have revision ID or other sequence mark
Smalyshev added a comment. I think, if I can recall correctly (this is 4+ years old by now :) that the idea was to have means to quickly identify that one dump is more recent than the other one, or less recent, and where in the sequence of dumps the particular dump falls. Individual entities may be helpful there but it's a matter of luck - maybe one particular entity didn't change between dumps? If I remember it correctly, then your patch seems to satisfy that need. TASK DETAIL https://phabricator.wikimedia.org/T87283 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev Cc: Pintoch, Addshore, Ivan_A_Krestinin, TorbenRahbekKoch, Ricordisamoa, Denis.bykov, Jimkont, Magnus, mkroetzsch, JanZerebecki, daniel, hoo, Aklapper, Smalyshev, alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T87283: Wikidata dumps should have revision ID or other sequence mark
gerritbot added a comment. Change 500806 had a related patch set uploaded (by Pintoch; owner: Pintoch): [mediawiki/extensions/Wikibase@master] dumps: Add lastrevid to JSON entity dumps. https://gerrit.wikimedia.org/r/500806 TASK DETAIL https://phabricator.wikimedia.org/T87283 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Pintoch, Addshore, Ivan_A_Krestinin, TorbenRahbekKoch, Ricordisamoa, Denis.bykov, Jimkont, Magnus, mkroetzsch, JanZerebecki, daniel, hoo, Aklapper, Smalyshev, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T87283: Wikidata dumps should have revision ID or other sequence mark
Pintoch added a comment. I am wondering what is the status of this: is more discussion needed about what version information to include, or are we simply waiting for a patch? I vote for the revision id to serve as version id (possibly with other metadata such as timestamp, as in Special:EntityData). If there is consensus for that, and if directed to the relevant part of the code, I could contribute patch. TASK DETAIL https://phabricator.wikimedia.org/T87283 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pintoch Cc: Pintoch, Addshore, Ivan_A_Krestinin, TorbenRahbekKoch, Ricordisamoa, Denis.bykov, Jimkont, Magnus, mkroetzsch, JanZerebecki, daniel, hoo, Aklapper, Smalyshev, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
